Sign upLogin

qcubed/framework

View on GitHub
Star
assets/php/examples/events_actions/low_priority_js.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '12', column '28').
Open

            $this->dtgButtons = new QDataGrid($this);
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '41', column '51').
Open

                $objControl->AddAction(new QClickEvent(), new QAjaxAction("renderLowPriorityButton_Click"));
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '57', column '51').
Open

                $objControl->AddAction(new QClickEvent(), new QAjaxAction("renderButton_Click"));
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '41', column '32').
Open

                $objControl->AddAction(new QClickEvent(), new QAjaxAction("renderLowPriorityButton_Click"));
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '38', column '23').
Open

                $objControl = new QJqButton($this->dtgButtons, $objControlId);
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '54', column '23').
Open

                $objControl = new QJqButton($this->dtgButtons, $objControlId);
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '57', column '32').
Open

                $objControl->AddAction(new QClickEvent(), new QAjaxAction("renderButton_Click"));
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'QApplication' in method 'renderButton_Click'.
Open

            QApplication::ExecuteJsFunction('alert', 'alert 1: a standard priority script');
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'QApplication' in method 'renderButton_Click'.
Open

            QApplication::ExecuteSelectorFunction(".ui-button", 'addClass', "ui-state-error");
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'QApplication' in method 'renderLowPriorityButton_Click'.
Open

            QApplication::ExecuteJsFunction('alert', 'Just updated the datagrid: --> the javascript for adding the css class to the buttons is executed first!',  QJsPriority::Low);
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'QApplication' in method 'renderLowPriorityButton_Click'.
Open

            QApplication::ExecuteJsFunction('alert', 'alert 2: a low priority script',  QJsPriority::Low);
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'QApplication' in method 'renderButton_Click'.
Open

            QApplication::ExecuteJsFunction('alert', 'Just updated the datagrid: the javascript for adding the css class to the buttons is not executed yet!');
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'QApplication' in method 'renderButton_Click'.
Open

            QApplication::ExecuteJsFunction('alert', 'alert 2: a standard priority script');
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'QApplication' in method 'renderLowPriorityButton_Click'.
Open

            QApplication::ExecuteSelectorFunction(".ui-button", 'addClass', "ui-state-error");
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'QApplication' in method 'renderLowPriorityButton_Click'.
Open

            QApplication::ExecuteJsFunction('alert', 'alert 1: a low priority script',  QJsPriority::Low);
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$strFormId'.
Open

        public function renderButton_Click($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$strControlId'.
Open

        public function renderButton_Click($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$strFormId'.
Open

        public function renderLowPriorityButton_Click($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$strControlId'.
Open

        public function renderLowPriorityButton_Click($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$strParameter'.
Open

        public function renderButton_Click($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$strParameter'.
Open

        public function renderLowPriorityButton_Click($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method Form_Create is not named in camelCase.
Open

        protected function Form_Create() {
            // Define the DataGrid
            $this->dtgButtons = new QDataGrid($this);

                        $this->dtgButtons->UseAjax=true;
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method dtgButtons_Bind is not named in camelCase.
Open

        protected function dtgButtons_Bind() {
            // We load the data source, and set it to the datagrid's DataSource parameter
            $this->dtgButtons->DataSource = $this->arRows;
        }
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method renderLowPriorityButton_Click is not named in camelCase.
Open

        public function renderLowPriorityButton_Click($strFormId, $strControlId, $strParameter) {
            $this->intHitCnt++;
            $this->dtgButtons->MarkAsModified();

            QApplication::ExecuteJsFunction('alert', 'alert 2: a low priority script',  QJsPriority::Low);
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method renderButton_Click is not named in camelCase.
Open

        public function renderButton_Click($strFormId, $strControlId, $strParameter) {
            $this->intHitCnt++;
            $this->dtgButtons->MarkAsModified();
            QApplication::ExecuteJsFunction('alert', 'alert 2: a standard priority script');
            QApplication::ExecuteJsFunction('alert', 'alert 1: a standard priority script');
Severity: Minor
Found in assets/php/examples/events_actions/low_priority_js.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status