qcubed/framework

View on GitHub
includes/base_controls/QDataGridBase.class.php

Summary

Maintainability
D
2 days
Test Coverage

The class QDataGridBase has an overall complexity of 91 which is very high. The configured complexity threshold is 50.
Open

class QDataGridBase extends QHtmlTable
{
    /** Numbers than can be used to multiply against the results of comparison functions to reverse the order. */
    const SortAscending = 1;
    const SortDescending = -1;

File QDataGridBase.class.php has 304 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * A HtmlTable that is connected to data. Detects and responds to sort clicks.
 *
Severity: Minor
Found in includes/base_controls/QDataGridBase.class.php - About 3 hrs to fix

    Function GetHeaderRowHtml has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function GetHeaderRowHtml() {
            $strToReturn = '';
            for ($i = 0; $i < $this->intHeaderRowCount; $i++) {
                $this->intCurrentHeaderRowIndex = $i;
    
    
    Severity: Minor
    Found in includes/base_controls/QDataGridBase.class.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __set has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __set($strName, $mixValue) {
            switch ($strName) {
                case "SortColumnId":
                    try {
                        $this->strSortColumnId = QType::Cast($mixValue, QType::String);
    Severity: Minor
    Found in includes/base_controls/QDataGridBase.class.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __set has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __set($strName, $mixValue) {
            switch ($strName) {
                case "SortColumnId":
                    try {
                        $this->strSortColumnId = QType::Cast($mixValue, QType::String);
    Severity: Major
    Found in includes/base_controls/QDataGridBase.class.php - About 2 hrs to fix

      Function SortClick has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function SortClick($strFormId, $strControlId, $mixParameter) {
      
              $intColumnIndex = QType::Cast($mixParameter, QType::Integer);
              $objColumn = $this->GetColumn ($intColumnIndex, true);
      
      
      Severity: Minor
      Found in includes/base_controls/QDataGridBase.class.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function GetOrderByInfo has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          public function GetOrderByInfo() {
              if ($this->strSortColumnId !== null) {
                  $objColumn = $this->GetColumnById($this->strSortColumnId);
                  if ($objColumn && $objColumn->OrderByClause) {
                      if ($this->intSortDirection == self::SortAscending) {
      Severity: Minor
      Found in includes/base_controls/QDataGridBase.class.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method SortClick has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function SortClick($strFormId, $strControlId, $mixParameter) {
      
              $intColumnIndex = QType::Cast($mixParameter, QType::Integer);
              $objColumn = $this->GetColumn ($intColumnIndex, true);
      
      
      Severity: Minor
      Found in includes/base_controls/QDataGridBase.class.php - About 1 hr to fix

        Function GetHeaderCellContent has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function GetHeaderCellContent($objColumn) {
                $blnSortable = false;
                $strCellValue = $objColumn->FetchHeaderCellValue();
                if ($objColumn->HtmlEntities) {
                    $strCellValue = QApplication::HtmlEntities($strCellValue);
        Severity: Minor
        Found in includes/base_controls/QDataGridBase.class.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function ClearCheckedItems has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function ClearCheckedItems($strColId = null) {
                foreach ($this->objColumnArray as $objColumn) {
                    if ($objColumn instanceof QDataGrid_CheckboxColumn) {
                        if (is_null($strColId) || $objColumn->Id === $strColId) {
                            $objColumn->ClearCheckedItems();
        Severity: Minor
        Found in includes/base_controls/QDataGridBase.class.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function GetCheckedItemIds has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function GetCheckedItemIds($strColId = null) {
                foreach ($this->objColumnArray as $objColumn) {
                    if ($objColumn instanceof QDataGrid_CheckboxColumn) {
                        if (is_null($strColId) ||
                                $objColumn->Id === $strColId) {
        Severity: Minor
        Found in includes/base_controls/QDataGridBase.class.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function PutState has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function PutState($state) {
                // use the name as the column key because columns might be added or removed for some reason
                if (isset ($state["c"])) {
                    $this->strSortColumnId = $state["c"];
                }
        Severity: Minor
        Found in includes/base_controls/QDataGridBase.class.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function GetSortColumnIndex has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function GetSortColumnIndex() {
                if ($this->objColumnArray && ($count = count($this->objColumnArray))) {
                    for($i = 0; $i < $count; $i++) {
                        if ($this->objColumnArray[$i]->Id == $this->SortColumnId) {
                            return $i;
        Severity: Minor
        Found in includes/base_controls/QDataGridBase.class.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                    return null;
        Severity: Major
        Found in includes/base_controls/QDataGridBase.class.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return parent::__get($strName);
          Severity: Major
          Found in includes/base_controls/QDataGridBase.class.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        case "SortInfo": return ['id'=>$this->strSortColumnId, 'dir'=>$this->intSortDirection];
            Severity: Major
            Found in includes/base_controls/QDataGridBase.class.php - About 30 mins to fix

              The method __set() has a Cyclomatic Complexity of 18. The configured cyclomatic complexity threshold is 10.
              Open

                  public function __set($strName, $mixValue) {
                      switch ($strName) {
                          case "SortColumnId":
                              try {
                                  $this->strSortColumnId = QType::Cast($mixValue, QType::String);

              CyclomaticComplexity

              Since: 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example

              // Cyclomatic Complexity = 11
              class Foo {
              1   public function example() {
              2       if ($a == $b) {
              3           if ($a1 == $b1) {
                              fiddle();
              4           } elseif ($a2 == $b2) {
                              fiddle();
                          } else {
                              fiddle();
                          }
              5       } elseif ($c == $d) {
              6           while ($c == $d) {
                              fiddle();
                          }
              7        } elseif ($e == $f) {
              8           for ($n = 0; $n < $h; $n++) {
                              fiddle();
                          }
                      } else {
                          switch ($z) {
              9               case 1:
                                  fiddle();
                                  break;
              10              case 2:
                                  fiddle();
                                  break;
              11              case 3:
                                  fiddle();
                                  break;
                              default:
                                  fiddle();
                                  break;
                          }
                      }
                  }
              }

              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

              The class QDataGridBase has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
              Open

              class QDataGridBase extends QHtmlTable
              {
                  /** Numbers than can be used to multiply against the results of comparison functions to reverse the order. */
                  const SortAscending = 1;
                  const SortDescending = -1;

              CouplingBetweenObjects

              Since: 1.1.0

              A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

              Example

              class Foo {
                  /**
                   * @var \foo\bar\X
                   */
                  private $x = null;
              
                  /**
                   * @var \foo\bar\Y
                   */
                  private $y = null;
              
                  /**
                   * @var \foo\bar\Z
                   */
                  private $z = null;
              
                  public function setFoo(\Foo $foo) {}
                  public function setBar(\Bar $bar) {}
                  public function setBaz(\Baz $baz) {}
              
                  /**
                   * @return \SplObjectStorage
                   * @throws \OutOfRangeException
                   * @throws \InvalidArgumentException
                   * @throws \ErrorException
                   */
                  public function process(\Iterator $it) {}
              
                  // ...
              }

              Source https://phpmd.org/rules/design.html#couplingbetweenobjects

              Missing class import via use statement (line '114', column '67').
              Open

                      $this->AddAction(new QHtmlTableCheckBoxColumn_ClickEvent(), new QAjaxControlAction ($this, 'CheckClick'));

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '115', column '67').
              Open

                      $this->AddAction(new QHtmlTableCheckBoxColumn_ClickEvent(), new QStopPropagationAction()); // prevent check click from bubbling as a row click.

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '115', column '24').
              Open

                      $this->AddAction(new QHtmlTableCheckBoxColumn_ClickEvent(), new QStopPropagationAction()); // prevent check click from bubbling as a row click.

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '114', column '24').
              Open

                      $this->AddAction(new QHtmlTableCheckBoxColumn_ClickEvent(), new QAjaxControlAction ($this, 'CheckClick'));

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '117', column '24').
              Open

                      $this->AddAction(new QDataGrid_SortEvent(), new QAjaxControlAction ($this, 'SortClick'));

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '117', column '51').
              Open

                      $this->AddAction(new QDataGrid_SortEvent(), new QAjaxControlAction ($this, 'SortClick'));

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '371', column '14').
              Open

                      return new QDataGrid_CodeGenerator($strClass);

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Avoid using static access to class 'QHtml' in method 'GetHeaderCellContent'.
              Open

                              $strCellValue = $strCellValue . ' ' . QHtml::RenderTag('i', ['class'=>'fa fa-sort-asc fa-lg']);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method SortClick uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                              } else {
                                  // Nope -- can we reverse?
                                  if ($objColumn->ReverseOrderByClause) {
                                      $this->intSortDirection = self::SortDescending;
                                  }

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method SortClick uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                          } else {
                              // Nope -- so let's set it to this column
                              $this->strSortColumnId = $strId;
                              $this->intSortDirection = self::SortAscending;
                          }

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid using static access to class 'QHtml' in method 'RenderPaginator'.
              Open

                      $strHtml = QHtml::RenderTag('span', ['class'=>'paginator-control'], $strHtml);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method GetHeaderCellContent uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                          } else {
                              $strCellValue = $strCellValue . ' ' . QHtml::RenderTag('i', ['class'=>'fa fa-sort-asc fa-lg']);
                          }

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid using static access to class 'QApplication' in method 'RenderPaginator'.
              Open

                          $strHtml = '<span>' . QApplication::HtmlEntities($this->strCaption) . '</span>' . $strHtml;

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method SortClick uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                      } else {
                          // It isn't -- clear all sort properties
                          $this->intSortDirection = self::SortAscending;
                          $this->strSortColumnId = null;
                      }

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid using static access to class 'QType' in method '__set'.
              Open

                                  $intIndex = QType::Cast($mixValue, QType::Integer);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QApplication' in method 'GetHeaderCellContent'.
              Open

                          $strCellValue = QApplication::HtmlEntities($strCellValue);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QHtml' in method 'RenderPaginator'.
              Open

                      $strHtml = QHtml::RenderTag('caption', null, $strHtml);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QHtml' in method 'GetHeaderCellContent'.
              Open

                      $strCellValue = QHtml::RenderTag('span', null, $strCellValue);    // wrap in a span for positioning

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QType' in method '__set'.
              Open

                                  $this->strSortColumnId = QType::Cast($mixValue, QType::String);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QApplication' in method 'GetEndScript'.
              Open

                      QApplication::ExecuteJsFunction('qcubed.datagrid2', $this->ControlId);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method GetOrderByInfo uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                              else {
                                  if ($objColumn->ReverseOrderByClause) {
                                      return $objColumn->ReverseOrderByClause;
                                  }
                                  else {

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method GetOrderByInfo uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                          else {
                              return null;
                          }

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid using static access to class 'QType' in method '__set'.
              Open

                                      $this->strSortColumnId = QType::Cast($mixValue['id'], QType::String);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QHtml' in method 'GetHeaderRowHtml'.
              Open

                                  $strCells .= QHtml::RenderTag('th', $aParams, $strCellValue);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method GetOrderByInfo uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                      } else {
                          return null;
                      }

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid using static access to class 'QHtml' in method 'GetHeaderRowHtml'.
              Open

                          $strToReturn .= QHtml::RenderTag('tr', $this->GetHeaderRowParams(), $strCells);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QHtml' in method 'GetHeaderCellContent'.
              Open

                          $strCellValue = QHtml::RenderTag('a', ['href'=>'javascript:;'], $strCellValue); // action will be handled by qcubed.js click handler in qcubed.datagrid2()

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method GetHeaderRowHtml uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                                      } else {
                                          $aParams['class'] = 'sortable';
                                      }

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid using static access to class 'QHtml' in method 'GetHeaderCellContent'.
              Open

                          $strCellValue = QHtml::RenderTag('div', null, $strCellValue);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method GetOrderByInfo uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                                  else {
                                      return $objColumn->OrderByClause;
                                  }

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid using static access to class 'QType' in method 'SortClick'.
              Open

                      $intColumnIndex = QType::Cast($mixParameter, QType::Integer);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QHtml' in method 'GetHeaderCellContent'.
              Open

                          $strCellValue = $strCellValue . ' ' . QHtml::RenderTag('i', ['class'=>'fa fa-sort fa-lg', 'style'=>'opacity:0.8']);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method __set uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                                  } else {
                                      // no columns
                                      $objColumn = null;
                                  }

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid using static access to class 'QType' in method '__set'.
              Open

                                  $this->intSortDirection = QType::Cast($mixValue, QType::Integer);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QType' in method '__set'.
              Open

                                      $this->intSortDirection = QType::Cast($mixValue['dir'], QType::Integer);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QHtml' in method 'GetHeaderCellContent'.
              Open

                              $strCellValue = $strCellValue . ' ' . QHtml::RenderTag('i', ['class'=>'fa fa-sort-desc fa-lg']);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid assigning values to variables in if clauses and the like (line '381', column '33').
              Open

                  public function GetSortColumnIndex() {
                      if ($this->objColumnArray && ($count = count($this->objColumnArray))) {
                          for($i = 0; $i < $count; $i++) {
                              if ($this->objColumnArray[$i]->Id == $this->SortColumnId) {
                                  return $i;

              IfStatementAssignment

              Since: 2.7.0

              Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($foo = 'bar') { // possible typo
                          // ...
                      }
                      if ($baz = 0) { // always false
                          // ...
                      }
                  }
              }

              Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

              Avoid unused parameters such as '$strFormId'.
              Open

                  protected function CheckClick($strFormId, $strControlId, $strParameter) {

              UnusedFormalParameter

              Since: 0.2

              Avoid passing parameters to methods or constructors and then not using those parameters.

              Example

              class Foo
              {
                  private function bar($howdy)
                  {
                      // $howdy is not used
                  }
              }

              Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

              Avoid unused parameters such as '$strControlId'.
              Open

                  protected function CheckClick($strFormId, $strControlId, $strParameter) {

              UnusedFormalParameter

              Since: 0.2

              Avoid passing parameters to methods or constructors and then not using those parameters.

              Example

              class Foo
              {
                  private function bar($howdy)
                  {
                      // $howdy is not used
                  }
              }

              Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

              Avoid unused parameters such as '$strFormId'.
              Open

                  protected function SortClick($strFormId, $strControlId, $mixParameter) {

              UnusedFormalParameter

              Since: 0.2

              Avoid passing parameters to methods or constructors and then not using those parameters.

              Example

              class Foo
              {
                  private function bar($howdy)
                  {
                      // $howdy is not used
                  }
              }

              Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

              Avoid unused parameters such as '$strControlId'.
              Open

                  protected function SortClick($strFormId, $strControlId, $mixParameter) {

              UnusedFormalParameter

              Since: 0.2

              Avoid passing parameters to methods or constructors and then not using those parameters.

              Example

              class Foo
              {
                  private function bar($howdy)
                  {
                      // $howdy is not used
                  }
              }

              Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

              The class QDataGrid_SortEvent is not named in CamelCase.
              Open

              class QDataGrid_SortEvent extends QEvent {
                  const JsReturnParam = 'ui'; // returns the col id
                  const EventName = 'qdg2sort';
              }

              CamelCaseClassName

              Since: 0.2

              It is considered best practice to use the CamelCase notation to name classes.

              Example

              class class_name {
              }

              Source

              Constant JsReturnParam should be defined in uppercase
              Open

                  const JsReturnParam = 'ui'; // returns the col id

              ConstantNamingConventions

              Since: 0.2

              Class/Interface constant names should always be defined in uppercase.

              Example

              class Foo {
                  const MY_NUM = 0; // ok
                  const myTest = ""; // fail
              }

              Source https://phpmd.org/rules/naming.html#constantnamingconventions

              Constant EventName should be defined in uppercase
              Open

                  const EventName = 'qdg2sort';

              ConstantNamingConventions

              Since: 0.2

              Class/Interface constant names should always be defined in uppercase.

              Example

              class Foo {
                  const MY_NUM = 0; // ok
                  const myTest = ""; // fail
              }

              Source https://phpmd.org/rules/naming.html#constantnamingconventions

              Constant SortAscending should be defined in uppercase
              Open

                  const SortAscending = 1;

              ConstantNamingConventions

              Since: 0.2

              Class/Interface constant names should always be defined in uppercase.

              Example

              class Foo {
                  const MY_NUM = 0; // ok
                  const myTest = ""; // fail
              }

              Source https://phpmd.org/rules/naming.html#constantnamingconventions

              Constant SortDescending should be defined in uppercase
              Open

                  const SortDescending = -1;

              ConstantNamingConventions

              Since: 0.2

              Class/Interface constant names should always be defined in uppercase.

              Example

              class Foo {
                  const MY_NUM = 0; // ok
                  const myTest = ""; // fail
              }

              Source https://phpmd.org/rules/naming.html#constantnamingconventions

              The method ClearCheckedItems is not named in camelCase.
              Open

                  public function ClearCheckedItems($strColId = null) {
                      foreach ($this->objColumnArray as $objColumn) {
                          if ($objColumn instanceof QDataGrid_CheckboxColumn) {
                              if (is_null($strColId) || $objColumn->Id === $strColId) {
                                  $objColumn->ClearCheckedItems();

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderCaption is not named in camelCase.
              Open

                  protected function RenderCaption() {
                      return $this->RenderPaginator();
                  }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method GetCheckedItemIds is not named in camelCase.
              Open

                  public function GetCheckedItemIds($strColId = null) {
                      foreach ($this->objColumnArray as $objColumn) {
                          if ($objColumn instanceof QDataGrid_CheckboxColumn) {
                              if (is_null($strColId) ||
                                      $objColumn->Id === $strColId) {

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method GetHeaderRowHtml is not named in camelCase.
              Open

                  protected function GetHeaderRowHtml() {
                      $strToReturn = '';
                      for ($i = 0; $i < $this->intHeaderRowCount; $i++) {
                          $this->intCurrentHeaderRowIndex = $i;
              
              

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method AddColumnAt is not named in camelCase.
              Open

                  public function AddColumnAt($intColumnIndex, QAbstractHtmlTableColumn $objColumn) {
                      parent::AddColumnAt($intColumnIndex, $objColumn);
                      // Make sure the column has an Id, since we use that to track sorting.
                      if (!$objColumn->Id) {
                          $objColumn->Id = $this->ControlId . '_col_' . $this->intLastColumnId++;

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderPaginator is not named in camelCase.
              Open

                  protected function RenderPaginator () {
                      $objPaginator = $this->objPaginator;
                      if (!$objPaginator) return '';
              
                      $strHtml = $objPaginator->Render(false);

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method GetHeaderCellContent is not named in camelCase.
              Open

                  protected function GetHeaderCellContent($objColumn) {
                      $blnSortable = false;
                      $strCellValue = $objColumn->FetchHeaderCellValue();
                      if ($objColumn->HtmlEntities) {
                          $strCellValue = QApplication::HtmlEntities($strCellValue);

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method PutState is not named in camelCase.
              Open

                  public function PutState($state) {
                      // use the name as the column key because columns might be added or removed for some reason
                      if (isset ($state["c"])) {
                          $this->strSortColumnId = $state["c"];
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method AddActions is not named in camelCase.
              Open

                  public function AddActions() {
                      $this->AddAction(new QHtmlTableCheckBoxColumn_ClickEvent(), new QAjaxControlAction ($this, 'CheckClick'));
                      $this->AddAction(new QHtmlTableCheckBoxColumn_ClickEvent(), new QStopPropagationAction()); // prevent check click from bubbling as a row click.
              
                      $this->AddAction(new QDataGrid_SortEvent(), new QAjaxControlAction ($this, 'SortClick'));

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method GetState is not named in camelCase.
              Open

                  public function GetState() {
                      $state = array();
                      if ($this->strSortColumnId !== null) {
                          $state["c"] = $this->strSortColumnId;
                          $state["d"] = $this->intSortDirection;

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method GetSortColumnIndex is not named in camelCase.
              Open

                  public function GetSortColumnIndex() {
                      if ($this->objColumnArray && ($count = count($this->objColumnArray))) {
                          for($i = 0; $i < $count; $i++) {
                              if ($this->objColumnArray[$i]->Id == $this->SortColumnId) {
                                  return $i;

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method CheckClick is not named in camelCase.
              Open

                  protected function CheckClick($strFormId, $strControlId, $strParameter) {
                      $intColumnIndex = $strParameter['col'];
                      $objColumn = $this->GetColumn ($intColumnIndex, true);
              
                      if ($objColumn instanceof QDataGrid_CheckboxColumn) {

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method SortClick is not named in camelCase.
              Open

                  protected function SortClick($strFormId, $strControlId, $mixParameter) {
              
                      $intColumnIndex = QType::Cast($mixParameter, QType::Integer);
                      $objColumn = $this->GetColumn ($intColumnIndex, true);
              
              

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method GetCodeGenerator is not named in camelCase.
              Open

                  public static function GetCodeGenerator($strClass = 'QDataGrid') {
                      return new QDataGrid_CodeGenerator($strClass);
                  }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method GetOrderByInfo is not named in camelCase.
              Open

                  public function GetOrderByInfo() {
                      if ($this->strSortColumnId !== null) {
                          $objColumn = $this->GetColumnById($this->strSortColumnId);
                          if ($objColumn && $objColumn->OrderByClause) {
                              if ($this->intSortDirection == self::SortAscending) {

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method GetEndScript is not named in camelCase.
              Open

                  public function GetEndScript() {
                      $strJS = parent::GetEndScript();
                      QApplication::ExecuteJsFunction('qcubed.datagrid2', $this->ControlId);
                      return $strJS;
                  }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              There are no issues that match your filters.

              Category
              Status