qcubed/framework

View on GitHub
includes/base_controls/QDateTimeTextBox.class.php

Summary

Maintainability
D
2 days
Test Coverage

ParsePostData accesses the super-global variable $_POST.
Open

        public function ParsePostData() {
            // Check to see if this Control's Value was passed in via the POST data
            if (array_key_exists($this->strControlId, $_POST)) {
                parent::ParsePostData();
                $this->dttDateTime = QDateTimeTextBox::ParseForDateTimeValue($this->strText);

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Function Validate has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

        public function Validate() {
            if (parent::Validate()) {
                if ($this->strText != "") {
                    $dttTest = QDateTimeTextBox::ParseForDateTimeValue($this->strText);

Severity: Minor
Found in includes/base_controls/QDateTimeTextBox.class.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The class QDateTimeTextBox has an overall complexity of 50 which is very high. The configured complexity threshold is 50.
Open

    class QDateTimeTextBox extends QTextBox {
        ///////////////////////////
        // Private Member Variables
        ///////////////////////////

Method __set has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public function __set($strName, $mixValue) {
            $this->blnModified = true;

            switch ($strName) {
                // MISC
Severity: Major
Found in includes/base_controls/QDateTimeTextBox.class.php - About 2 hrs to fix

    Function ParseForDateTimeValue has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

            public static function ParseForDateTimeValue($strText) {
                // Trim and Clean
                $strText = strtolower(trim($strText));
                while(strpos($strText, '  ') !== false)
                    $strText = str_replace('  ', ' ', $strText);
    Severity: Minor
    Found in includes/base_controls/QDateTimeTextBox.class.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __set has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

            public function __set($strName, $mixValue) {
                $this->blnModified = true;
    
                switch ($strName) {
                    // MISC
    Severity: Minor
    Found in includes/base_controls/QDateTimeTextBox.class.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Validate has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public function Validate() {
                if (parent::Validate()) {
                    if ($this->strText != "") {
                        $dttTest = QDateTimeTextBox::ParseForDateTimeValue($this->strText);
    
    
    Severity: Minor
    Found in includes/base_controls/QDateTimeTextBox.class.php - About 1 hr to fix

      Method ParseForDateTimeValue has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public static function ParseForDateTimeValue($strText) {
                  // Trim and Clean
                  $strText = strtolower(trim($strText));
                  while(strpos($strText, '  ') !== false)
                      $strText = str_replace('  ', ' ', $strText);
      Severity: Minor
      Found in includes/base_controls/QDateTimeTextBox.class.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                                return parent::__get($strName);
        Severity: Major
        Found in includes/base_controls/QDateTimeTextBox.class.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return true;
          Severity: Major
          Found in includes/base_controls/QDateTimeTextBox.class.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            case 'LabelForInvalid': return $this->strLabelForInvalid;
            Severity: Major
            Found in includes/base_controls/QDateTimeTextBox.class.php - About 30 mins to fix

              The method __set() has a Cyclomatic Complexity of 17. The configured cyclomatic complexity threshold is 10.
              Open

                      public function __set($strName, $mixValue) {
                          $this->blnModified = true;
              
                          switch ($strName) {
                              // MISC

              CyclomaticComplexity

              Since: 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example

              // Cyclomatic Complexity = 11
              class Foo {
              1   public function example() {
              2       if ($a == $b) {
              3           if ($a1 == $b1) {
                              fiddle();
              4           } elseif ($a2 == $b2) {
                              fiddle();
                          } else {
                              fiddle();
                          }
              5       } elseif ($c == $d) {
              6           while ($c == $d) {
                              fiddle();
                          }
              7        } elseif ($e == $f) {
              8           for ($n = 0; $n < $h; $n++) {
                              fiddle();
                          }
                      } else {
                          switch ($z) {
              9               case 1:
                                  fiddle();
                                  break;
              10              case 2:
                                  fiddle();
                                  break;
              11              case 3:
                                  fiddle();
                                  break;
                              default:
                                  fiddle();
                                  break;
                          }
                      }
                  }
              }

              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

              The method ParseForDateTimeValue() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
              Open

                      public static function ParseForDateTimeValue($strText) {
                          // Trim and Clean
                          $strText = strtolower(trim($strText));
                          while(strpos($strText, '  ') !== false)
                              $strText = str_replace('  ', ' ', $strText);

              CyclomaticComplexity

              Since: 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example

              // Cyclomatic Complexity = 11
              class Foo {
              1   public function example() {
              2       if ($a == $b) {
              3           if ($a1 == $b1) {
                              fiddle();
              4           } elseif ($a2 == $b2) {
                              fiddle();
                          } else {
                              fiddle();
                          }
              5       } elseif ($c == $d) {
              6           while ($c == $d) {
                              fiddle();
                          }
              7        } elseif ($e == $f) {
              8           for ($n = 0; $n < $h; $n++) {
                              fiddle();
                          }
                      } else {
                          switch ($z) {
              9               case 1:
                                  fiddle();
                                  break;
              10              case 2:
                                  fiddle();
                                  break;
              11              case 3:
                                  fiddle();
                                  break;
                              default:
                                  fiddle();
                                  break;
                          }
                      }
                  }
              }

              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

              The method Validate() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
              Open

                      public function Validate() {
                          if (parent::Validate()) {
                              if ($this->strText != "") {
                                  $dttTest = QDateTimeTextBox::ParseForDateTimeValue($this->strText);
              
              

              CyclomaticComplexity

              Since: 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example

              // Cyclomatic Complexity = 11
              class Foo {
              1   public function example() {
              2       if ($a == $b) {
              3           if ($a1 == $b1) {
                              fiddle();
              4           } elseif ($a2 == $b2) {
                              fiddle();
                          } else {
                              fiddle();
                          }
              5       } elseif ($c == $d) {
              6           while ($c == $d) {
                              fiddle();
                          }
              7        } elseif ($e == $f) {
              8           for ($n = 0; $n < $h; $n++) {
                              fiddle();
                          }
                      } else {
                          switch ($z) {
              9               case 1:
                                  fiddle();
                                  break;
              10              case 2:
                                  fiddle();
                                  break;
              11              case 3:
                                  fiddle();
                                  break;
                              default:
                                  fiddle();
                                  break;
                          }
                      }
                  }
              }

              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

              Missing class import via use statement (line '56', column '24').
              Open

                              $dttToReturn = new QDateTime($strText);

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '110', column '28').
              Open

                                          $dttToCompare = new QDateTime(QDateTime::Now);

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '76', column '23').
              Open

                          $dttToReturn = new QDateTime($strText);

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '95', column '28').
              Open

                                          $dttToCompare = new QDateTime(QDateTime::Now);

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Avoid using static access to class 'QApplication' in method 'Validate'.
              Open

                                          $strError = QApplication::Translate('in the past');

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QApplication' in method 'Validate'.
              Open

                                          $strError = QApplication::Translate('after ') . $dttToCompare->__toString();

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QType' in method '__set'.
              Open

                                          $this->dttMaximum = QType::Cast($mixValue, QType::DateTime);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QDateTimeTextBox' in method '__set'.
              Open

                                  $this->dttDateTime = QDateTimeTextBox::ParseForDateTimeValue($this->strText);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QApplication' in method 'Validate'.
              Open

                                          $this->ValidationError = QApplication::Translate('Date cannot be ') . $strError;

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QType' in method '__set'.
              Open

                                      return ($this->strLabelForInvalid = QType::Cast($mixValue, QType::String));

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QType' in method '__set'.
              Open

                                      $this->strDateTimeFormat = QType::Cast($mixValue, QType::String);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QDateTimeTextBox' in method 'Validate'.
              Open

                                  $dttTest = QDateTimeTextBox::ParseForDateTimeValue($this->strText);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QApplication' in method 'Validate'.
              Open

                                          $strError = QApplication::Translate('before ') . $dttToCompare->__toString();

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QApplication' in method 'Validate'.
              Open

                                          $this->ValidationError = QApplication::Translate('Date cannot be ') . $strError;

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QType' in method '__set'.
              Open

                                          $this->dttMinimum = QType::Cast($mixValue, QType::DateTime);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QDateTimeTextBox' in method 'ParsePostData'.
              Open

                              $this->dttDateTime = QDateTimeTextBox::ParseForDateTimeValue($this->strText);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QType' in method '__set'.
              Open

                                      $this->dttDateTime = QType::Cast($mixValue, QType::DateTime);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'QApplication' in method 'Validate'.
              Open

                                          $strError = QApplication::Translate('in the future');

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method __set uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                                      } else {
                                          parent::__set('Text', $this->dttDateTime->qFormat($this->strDateTimeFormat));
                                      }

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method Validate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                                      } else {
                                          $dttToCompare = $this->dttMinimum;
                                          $strError = QApplication::Translate('before ') . $dttToCompare->__toString();
                                      }

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method Validate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                                      } else {
                                          $dttToCompare = $this->dttMaximum;
                                          $strError = QApplication::Translate('after ') . $dttToCompare->__toString();
                                      }

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if (!is_null($this->dttMinimum)) {
                                      if ($this->dttMinimum == QDateTime::Now) {
                                          $dttToCompare = new QDateTime(QDateTime::Now);
                                          $strError = QApplication::Translate('in the past');
                                      } else {
              Severity: Major
              Found in includes/base_controls/QDateTimeTextBox.class.php and 1 other location - About 2 hrs to fix
              includes/base_controls/QDateTimeTextBox.class.php on lines 108..121

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 131.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if (!is_null($this->dttMaximum)) {
                                      if ($this->dttMaximum == QDateTime::Now) {
                                          $dttToCompare = new QDateTime(QDateTime::Now);
                                          $strError = QApplication::Translate('in the future');
                                      } else {
              Severity: Major
              Found in includes/base_controls/QDateTimeTextBox.class.php and 1 other location - About 2 hrs to fix
              includes/base_controls/QDateTimeTextBox.class.php on lines 93..106

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 131.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              The method Validate is not named in camelCase.
              Open

                      public function Validate() {
                          if (parent::Validate()) {
                              if ($this->strText != "") {
                                  $dttTest = QDateTimeTextBox::ParseForDateTimeValue($this->strText);
              
              

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method Codegen_VarName is not named in camelCase.
              Open

                      public static function Codegen_VarName($strPropName) {
                          return 'cal' . $strPropName;
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method ParseForDateTimeValue is not named in camelCase.
              Open

                      public static function ParseForDateTimeValue($strText) {
                          // Trim and Clean
                          $strText = strtolower(trim($strText));
                          while(strpos($strText, '  ') !== false)
                              $strText = str_replace('  ', ' ', $strText);

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method ParsePostData is not named in camelCase.
              Open

                      public function ParsePostData() {
                          // Check to see if this Control's Value was passed in via the POST data
                          if (array_key_exists($this->strControlId, $_POST)) {
                              parent::ParsePostData();
                              $this->dttDateTime = QDateTimeTextBox::ParseForDateTimeValue($this->strText);

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              There are no issues that match your filters.

              Category
              Status