qcubed/framework

View on GitHub
includes/base_controls/QPaginatedControl.class.php

Summary

Maintainability
F
3 days
Test Coverage

Function __set has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

        public function __set($strName, $mixValue) {
            switch ($strName) {
                // APPEARANCE
                case "Noun":
                    try {
Severity: Minor
Found in includes/base_controls/QPaginatedControl.class.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __set has 119 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public function __set($strName, $mixValue) {
            switch ($strName) {
                // APPEARANCE
                case "Noun":
                    try {
Severity: Major
Found in includes/base_controls/QPaginatedControl.class.php - About 4 hrs to fix

    The class QPaginatedControl has an overall complexity of 62 which is very high. The configured complexity threshold is 50.
    Open

        abstract class QPaginatedControl extends QControl {
            use QDataBinder;
    
            // APPEARANCE
            /** @var string Name of the items which are being paginated (books, movies, posts etc.) */

    Method __get has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public function __get($strName) {
                switch ($strName) {
                    // APPEARANCE
                    case "Noun": return $this->strNoun;
                    case "NounPlural": return $this->strNounPlural;
    Severity: Major
    Found in includes/base_controls/QPaginatedControl.class.php - About 2 hrs to fix

      Function __get has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

              public function __get($strName) {
                  switch ($strName) {
                      // APPEARANCE
                      case "Noun": return $this->strNoun;
                      case "NounPlural": return $this->strNounPlural;
      Severity: Minor
      Found in includes/base_controls/QPaginatedControl.class.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function DataBind has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

              public function DataBind() {
                  // Run the DataBinder (if applicable)
                  if (($this->objDataSource === null) && ($this->HasDataBinder()) && (!$this->blnRendered))
                  {
                      try {
      Severity: Minor
      Found in includes/base_controls/QPaginatedControl.class.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                              return ($this->objPaginator->PageNumber - 1) * $this->objPaginator->ItemsPerPage;
      Severity: Major
      Found in includes/base_controls/QPaginatedControl.class.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                                return null;
        Severity: Major
        Found in includes/base_controls/QPaginatedControl.class.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          case "UseAjax": return $this->blnUseAjax;
          Severity: Major
          Found in includes/base_controls/QPaginatedControl.class.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                    return null;
            Severity: Major
            Found in includes/base_controls/QPaginatedControl.class.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                      return $this->objPaginator->PageNumber;
              Severity: Major
              Found in includes/base_controls/QPaginatedControl.class.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                            return $intOffset . ',' . $this->objPaginator->ItemsPerPage;
                Severity: Major
                Found in includes/base_controls/QPaginatedControl.class.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                              return QQ::LimitInfo($this->objPaginator->ItemsPerPage, $intOffset);
                  Severity: Major
                  Found in includes/base_controls/QPaginatedControl.class.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                            return parent::__get($strName);
                    Severity: Major
                    Found in includes/base_controls/QPaginatedControl.class.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                          return null;
                      Severity: Major
                      Found in includes/base_controls/QPaginatedControl.class.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                        case "ItemCount": return count($this->objDataSource);
                        Severity: Major
                        Found in includes/base_controls/QPaginatedControl.class.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                                  return null;
                          Severity: Major
                          Found in includes/base_controls/QPaginatedControl.class.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                                    return $this->objPaginator->ItemsPerPage;
                            Severity: Major
                            Found in includes/base_controls/QPaginatedControl.class.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                                      return $this->objPaginator->TotalItemCount;
                              Severity: Major
                              Found in includes/base_controls/QPaginatedControl.class.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                        return null;
                                Severity: Major
                                Found in includes/base_controls/QPaginatedControl.class.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                          return null;
                                  Severity: Major
                                  Found in includes/base_controls/QPaginatedControl.class.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                    case "DataSource": return $this->objDataSource;
                                    Severity: Major
                                    Found in includes/base_controls/QPaginatedControl.class.php - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                          return null;
                                      Severity: Major
                                      Found in includes/base_controls/QPaginatedControl.class.php - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                                return $this->objPaginator->PageCount;
                                        Severity: Major
                                        Found in includes/base_controls/QPaginatedControl.class.php - About 30 mins to fix

                                          The method __set() has 137 lines of code. Current threshold is set to 100. Avoid really long methods.
                                          Open

                                                  public function __set($strName, $mixValue) {
                                                      switch ($strName) {
                                                          // APPEARANCE
                                                          case "Noun":
                                                              try {

                                          The method __set() has a Cyclomatic Complexity of 30. The configured cyclomatic complexity threshold is 10.
                                          Open

                                                  public function __set($strName, $mixValue) {
                                                      switch ($strName) {
                                                          // APPEARANCE
                                                          case "Noun":
                                                              try {

                                          CyclomaticComplexity

                                          Since: 0.1

                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                          Example

                                          // Cyclomatic Complexity = 11
                                          class Foo {
                                          1   public function example() {
                                          2       if ($a == $b) {
                                          3           if ($a1 == $b1) {
                                                          fiddle();
                                          4           } elseif ($a2 == $b2) {
                                                          fiddle();
                                                      } else {
                                                          fiddle();
                                                      }
                                          5       } elseif ($c == $d) {
                                          6           while ($c == $d) {
                                                          fiddle();
                                                      }
                                          7        } elseif ($e == $f) {
                                          8           for ($n = 0; $n < $h; $n++) {
                                                          fiddle();
                                                      }
                                                  } else {
                                                      switch ($z) {
                                          9               case 1:
                                                              fiddle();
                                                              break;
                                          10              case 2:
                                                              fiddle();
                                                              break;
                                          11              case 3:
                                                              fiddle();
                                                              break;
                                                          default:
                                                              fiddle();
                                                              break;
                                                      }
                                                  }
                                              }
                                          }

                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                          The method __get() has a Cyclomatic Complexity of 23. The configured cyclomatic complexity threshold is 10.
                                          Open

                                                  public function __get($strName) {
                                                      switch ($strName) {
                                                          // APPEARANCE
                                                          case "Noun": return $this->strNoun;
                                                          case "NounPlural": return $this->strNounPlural;

                                          CyclomaticComplexity

                                          Since: 0.1

                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                          Example

                                          // Cyclomatic Complexity = 11
                                          class Foo {
                                          1   public function example() {
                                          2       if ($a == $b) {
                                          3           if ($a1 == $b1) {
                                                          fiddle();
                                          4           } elseif ($a2 == $b2) {
                                                          fiddle();
                                                      } else {
                                                          fiddle();
                                                      }
                                          5       } elseif ($c == $d) {
                                          6           while ($c == $d) {
                                                          fiddle();
                                                      }
                                          7        } elseif ($e == $f) {
                                          8           for ($n = 0; $n < $h; $n++) {
                                                          fiddle();
                                                      }
                                                  } else {
                                                      switch ($z) {
                                          9               case 1:
                                                              fiddle();
                                                              break;
                                          10              case 2:
                                                              fiddle();
                                                              break;
                                          11              case 3:
                                                              fiddle();
                                                              break;
                                                          default:
                                                              fiddle();
                                                              break;
                                                      }
                                                  }
                                              }
                                          }

                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                          Missing class import via use statement (line '200', column '19').
                                          Open

                                                                          throw new QCallerException('The assigned paginator must belong to the same form that this control belongs to.');

                                          MissingImport

                                          Since: 2.7.0

                                          Importing all external classes in a file through use statements makes them clearly visible.

                                          Example

                                          function make() {
                                              return new \stdClass();
                                          }

                                          Source http://phpmd.org/rules/cleancode.html#MissingImport

                                          Missing class import via use statement (line '297', column '17').
                                          Open

                                                                  throw new QCallerException('Setting PageNumber requires a Paginator to be set');

                                          MissingImport

                                          Since: 2.7.0

                                          Importing all external classes in a file through use statements makes them clearly visible.

                                          Example

                                          function make() {
                                              return new \stdClass();
                                          }

                                          Source http://phpmd.org/rules/cleancode.html#MissingImport

                                          Missing class import via use statement (line '214', column '18').
                                          Open

                                                                      throw new QCallerException('The assigned paginator must belong to the same form that this control belongs to.');

                                          MissingImport

                                          Since: 2.7.0

                                          Importing all external classes in a file through use statements makes them clearly visible.

                                          Example

                                          function make() {
                                              return new \stdClass();
                                          }

                                          Source http://phpmd.org/rules/cleancode.html#MissingImport

                                          Missing class import via use statement (line '273', column '17').
                                          Open

                                                                  throw new QCallerException('Setting TotalItemCount requires a Paginator to be set');

                                          MissingImport

                                          Since: 2.7.0

                                          Importing all external classes in a file through use statements makes them clearly visible.

                                          Example

                                          function make() {
                                              return new \stdClass();
                                          }

                                          Source http://phpmd.org/rules/cleancode.html#MissingImport

                                          Missing class import via use statement (line '255', column '17').
                                          Open

                                                                  throw new QCallerException('Setting ItemsPerPage requires a Paginator to be set');

                                          MissingImport

                                          Since: 2.7.0

                                          Importing all external classes in a file through use statements makes them clearly visible.

                                          Example

                                          function make() {
                                              return new \stdClass();
                                          }

                                          Source http://phpmd.org/rules/cleancode.html#MissingImport

                                          Avoid using static access to class 'QType' in method '__set'.
                                          Open

                                                                      $intItemsPerPage = QType::Cast($mixValue, QType::Integer);

                                          StaticAccess

                                          Since: 1.4.0

                                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                          Example

                                          class Foo
                                          {
                                              public function bar()
                                              {
                                                  Bar::baz();
                                              }
                                          }

                                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                                          Avoid using static access to class 'QType' in method '__set'.
                                          Open

                                                                  $this->strNounPlural = QType::Cast($mixValue, QType::String);

                                          StaticAccess

                                          Since: 1.4.0

                                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                          Example

                                          class Foo
                                          {
                                              public function bar()
                                              {
                                                  Bar::baz();
                                              }
                                          }

                                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                                          Avoid using static access to class 'QType' in method '__set'.
                                          Open

                                                                  $this->objPaginator = QType::Cast($mixValue, 'QPaginatorBase');

                                          StaticAccess

                                          Since: 1.4.0

                                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                          Example

                                          class Foo
                                          {
                                              public function bar()
                                              {
                                                  Bar::baz();
                                              }
                                          }

                                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                                          Avoid using static access to class 'QQ' in method '__get'.
                                          Open

                                                                      return QQ::LimitInfo($this->objPaginator->ItemsPerPage, $intOffset);

                                          StaticAccess

                                          Since: 1.4.0

                                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                          Example

                                          class Foo
                                          {
                                              public function bar()
                                              {
                                                  Bar::baz();
                                              }
                                          }

                                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                                          Avoid using static access to class 'QType' in method '__set'.
                                          Open

                                                                      $intTotalCount = QType::Cast($mixValue, QType::Integer);

                                          StaticAccess

                                          Since: 1.4.0

                                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                          Example

                                          class Foo
                                          {
                                              public function bar()
                                              {
                                                  Bar::baz();
                                              }
                                          }

                                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                                          Avoid using static access to class 'QType' in method '__set'.
                                          Open

                                                                      $intPageNumber = QType::Cast($mixValue, QType::Integer);

                                          StaticAccess

                                          Since: 1.4.0

                                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                          Example

                                          class Foo
                                          {
                                              public function bar()
                                              {
                                                  Bar::baz();
                                              }
                                          }

                                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                                          Avoid using static access to class 'QApplication' in method '__construct'.
                                          Open

                                                      $this->strNounPlural = QApplication::Translate('items');

                                          StaticAccess

                                          Since: 1.4.0

                                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                          Example

                                          class Foo
                                          {
                                              public function bar()
                                              {
                                                  Bar::baz();
                                              }
                                          }

                                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                                          Avoid using static access to class 'QType' in method '__set'.
                                          Open

                                                                  $this->objPaginatorAlternate = QType::Cast($mixValue, 'QPaginatorBase');

                                          StaticAccess

                                          Since: 1.4.0

                                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                          Example

                                          class Foo
                                          {
                                              public function bar()
                                              {
                                                  Bar::baz();
                                              }
                                          }

                                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                                          Avoid using static access to class 'QApplication' in method '__construct'.
                                          Open

                                                      $this->strNoun = QApplication::Translate('item');

                                          StaticAccess

                                          Since: 1.4.0

                                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                          Example

                                          class Foo
                                          {
                                              public function bar()
                                              {
                                                  Bar::baz();
                                              }
                                          }

                                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                                          Avoid using static access to class 'QType' in method '__set'.
                                          Open

                                                                  $this->blnUseAjax = QType::Cast($mixValue, QType::Boolean);

                                          StaticAccess

                                          Since: 1.4.0

                                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                          Example

                                          class Foo
                                          {
                                              public function bar()
                                              {
                                                  Bar::baz();
                                              }
                                          }

                                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                                          Avoid using static access to class 'QType' in method '__set'.
                                          Open

                                                                  $this->strNoun = QType::Cast($mixValue, QType::String);

                                          StaticAccess

                                          Since: 1.4.0

                                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                          Example

                                          class Foo
                                          {
                                              public function bar()
                                              {
                                                  Bar::baz();
                                              }
                                          }

                                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                                          Similar blocks of code found in 3 locations. Consider refactoring.
                                          Open

                                                          case "PageNumber":
                                                              if ($this->objPaginator) {
                                                                  try {
                                                                      $intPageNumber = QType::Cast($mixValue, QType::Integer);
                                                                      $this->objPaginator->PageNumber = $intPageNumber;
                                          Severity: Major
                                          Found in includes/base_controls/QPaginatedControl.class.php and 2 other locations - About 1 hr to fix
                                          includes/base_controls/QPaginatedControl.class.php on lines 238..255
                                          includes/base_controls/QPaginatedControl.class.php on lines 256..273

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 105.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 3 locations. Consider refactoring.
                                          Open

                                                          case "ItemsPerPage":
                                                              if ($this->objPaginator) {
                                                                  try {
                                                                      $intItemsPerPage = QType::Cast($mixValue, QType::Integer);
                                                                      $this->objPaginator->ItemsPerPage = $intItemsPerPage;
                                          Severity: Major
                                          Found in includes/base_controls/QPaginatedControl.class.php and 2 other locations - About 1 hr to fix
                                          includes/base_controls/QPaginatedControl.class.php on lines 256..273
                                          includes/base_controls/QPaginatedControl.class.php on lines 281..297

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 105.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 3 locations. Consider refactoring.
                                          Open

                                                          case "TotalItemCount":
                                                              if ($this->objPaginator) {
                                                                  try {
                                                                      $intTotalCount = QType::Cast($mixValue, QType::Integer);
                                                                      $this->objPaginator->TotalItemCount = $intTotalCount;
                                          Severity: Major
                                          Found in includes/base_controls/QPaginatedControl.class.php and 2 other locations - About 1 hr to fix
                                          includes/base_controls/QPaginatedControl.class.php on lines 238..255
                                          includes/base_controls/QPaginatedControl.class.php on lines 281..297

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 105.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Avoid excessively long variable names like $objPaginatorAlternate. Keep variable name length under 20.
                                          Open

                                                  protected $objPaginatorAlternate = null;

                                          LongVariable

                                          Since: 0.2

                                          Detects when a field, formal or local variable is declared with a long name.

                                          Example

                                          class Something {
                                              protected $reallyLongIntName = -3; // VIOLATION - Field
                                              public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                                                  $otherReallyLongName = -5; // VIOLATION - Local
                                                  for ($interestingIntIndex = 0; // VIOLATION - For
                                                       $interestingIntIndex < 10;
                                                       $interestingIntIndex++ ) {
                                                  }
                                              }
                                          }

                                          Source https://phpmd.org/rules/naming.html#longvariable

                                          The method DataBind is not named in camelCase.
                                          Open

                                                  public function DataBind() {
                                                      // Run the DataBinder (if applicable)
                                                      if (($this->objDataSource === null) && ($this->HasDataBinder()) && (!$this->blnRendered))
                                                      {
                                                          try {

                                          CamelCaseMethodName

                                          Since: 0.2

                                          It is considered best practice to use the camelCase notation to name methods.

                                          Example

                                          class ClassName {
                                              public function get_name() {
                                              }
                                          }

                                          Source

                                          The method Validate is not named in camelCase.
                                          Open

                                                  public function Validate() {
                                                      return true;
                                                  }

                                          CamelCaseMethodName

                                          Since: 0.2

                                          It is considered best practice to use the camelCase notation to name methods.

                                          Example

                                          class ClassName {
                                              public function get_name() {
                                              }
                                          }

                                          Source

                                          There are no issues that match your filters.

                                          Category
                                          Status