qcubed/framework

View on GitHub
includes/base_controls/QTabsBase.class.php

Summary

Maintainability
C
7 hrs
Test Coverage

The class QTabsBase has an overall complexity of 53 which is very high. The configured complexity threshold is 50.
Open

    class QTabsBase extends QTabsGen
    {
        /** @var array Names of tabs. Can also specify with Name attribute of child controls. */
        protected $objTabHeadersArray = array();
        /** @var bool Automatically render the children by default, since these are the tabs. */

Function FindTabIndex has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

        protected function FindTabIndex ($mixTab) {
            if ($mixTab === null) return false;

            if ($this->objTabHeadersArray) {
                $count = count($this->objTabHeadersArray);
Severity: Minor
Found in includes/base_controls/QTabsBase.class.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method FindTabIndex has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        protected function FindTabIndex ($mixTab) {
            if ($mixTab === null) return false;

            if ($this->objTabHeadersArray) {
                $count = count($this->objTabHeadersArray);
Severity: Minor
Found in includes/base_controls/QTabsBase.class.php - About 1 hr to fix

    Function GetTabHeaderHtml has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            protected function GetTabHeaderHtml() {
                $strHtml = '';
                $childControls = $this->GetChildControls();
                for ($i = 0, $cnt = count($childControls); $i < $cnt; ++$i) {
                    $strControlId = $childControls[$i]->ControlId;
    Severity: Minor
    Found in includes/base_controls/QTabsBase.class.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function EnableTab has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            public function EnableTab ($mixTab = null, $blnEnable = true) {
    
                if (is_null($mixTab)) {
                    if ($blnEnable) {
                        parent::Enable();
    Severity: Minor
    Found in includes/base_controls/QTabsBase.class.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function ValidateControlAndChildren has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            public function ValidateControlAndChildren() {
                // Initially Assume Validation is True
                $blnToReturn = true;
    
                // Check the Control Itself
    Severity: Minor
    Found in includes/base_controls/QTabsBase.class.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                        return $i;
    Severity: Major
    Found in includes/base_controls/QTabsBase.class.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return false;
      Severity: Major
      Found in includes/base_controls/QTabsBase.class.php - About 30 mins to fix

        Function __set has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                public function __set($strName, $mixValue) {
                    switch ($strName) {
                        case 'Headers':
                            try {
                                $this->objTabHeadersArray = QType::Cast($mixValue, QType::ArrayType);
        Severity: Minor
        Found in includes/base_controls/QTabsBase.class.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        The method FindTabIndex() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
        Open

                protected function FindTabIndex ($mixTab) {
                    if ($mixTab === null) return false;
        
                    if ($this->objTabHeadersArray) {
                        $count = count($this->objTabHeadersArray);

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        The method EnableTab has a boolean flag argument $blnEnable, which is a certain sign of a Single Responsibility Principle violation.
        Open

                public function EnableTab ($mixTab = null, $blnEnable = true) {

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
            public function bar($flag = true) {
            }
        }

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        The method RenderChildren has a boolean flag argument $blnDisplayOutput, which is a certain sign of a Single Responsibility Principle violation.
        Open

                protected function RenderChildren($blnDisplayOutput = true) {

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
            public function bar($flag = true) {
            }
        }

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        Avoid assigning values to variables in if clauses and the like (line '88', column '13').
        Open

                protected function GetTabHeaderHtml() {
                    $strHtml = '';
                    $childControls = $this->GetChildControls();
                    for ($i = 0, $cnt = count($childControls); $i < $cnt; ++$i) {
                        $strControlId = $childControls[$i]->ControlId;

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($foo = 'bar') { // possible typo
                    // ...
                }
                if ($baz = 0) { // always false
                    // ...
                }
            }
        }

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid assigning values to variables in if clauses and the like (line '226', column '19').
        Open

                public function EnableTab ($mixTab = null, $blnEnable = true) {
        
                    if (is_null($mixTab)) {
                        if ($blnEnable) {
                            parent::Enable();

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($foo = 'bar') { // possible typo
                    // ...
                }
                if ($baz = 0) { // always false
                    // ...
                }
            }
        }

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        The method EnableTab uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                        } else {
                            parent::Disable1($i);
                        }

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($flag) {
                    // one branch
                } else {
                    // another branch
                }
            }
        }

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid using static access to class 'QHtml' in method 'GetTabHeaderHtml'.
        Open

                        $strHtml .= QHtml::RenderTag ('li', null, $strAnchor);

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
        {
            public function bar()
            {
                Bar::baz();
            }
        }

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class 'QHtml' in method 'GetTabHeaderHtml'.
        Open

                        $strAnchor = QHtml::RenderTag('a', ['href'=>'#' . $strControlId], $strText, false, true);

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
        {
            public function bar()
            {
                Bar::baz();
            }
        }

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        The method FindTabIndex uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                    else {
                        $childControls = $this->GetChildControls();
                        $count = count ($childControls);
                    }

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($flag) {
                    // one branch
                } else {
                    // another branch
                }
            }
        }

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid using static access to class 'QApplication' in method 'GetEndScript'.
        Open

                    QApplication::ExecuteJsFunction('qcubed.tabs', $this->GetJqControlId(), QJsPriority::High);

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
        {
            public function bar()
            {
                Bar::baz();
            }
        }

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class 'QControl' in method 'Refresh'.
        Open

                    QControl::Refresh();

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
        {
            public function bar()
            {
                Bar::baz();
            }
        }

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class 'QHtml' in method 'RenderChildren'.
        Open

                            $strToReturn .= QHtml::RenderTag('div', null, $objControl->$renderMethod($blnDisplayOutput));

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
        {
            public function bar()
            {
                Bar::baz();
            }
        }

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        The method EnableTab uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                        } else {
                            parent::Disable();
                        }

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($flag) {
                    // one branch
                } else {
                    // another branch
                }
            }
        }

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid assigning values to variables in if clauses and the like (line '80', column '24').
        Open

                protected function GetTabHeaderHtml() {
                    $strHtml = '';
                    $childControls = $this->GetChildControls();
                    for ($i = 0, $cnt = count($childControls); $i < $cnt; ++$i) {
                        $strControlId = $childControls[$i]->ControlId;

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($foo = 'bar') { // possible typo
                    // ...
                }
                if ($baz = 0) { // always false
                    // ...
                }
            }
        }

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid using static access to class 'QHtml' in method 'GetTabHeaderHtml'.
        Open

                    return QHtml::RenderTag('ul', null, $strHtml);

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
        {
            public function bar()
            {
                Bar::baz();
            }
        }

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid assigning values to variables in if clauses and the like (line '79', column '26').
        Open

                protected function GetTabHeaderHtml() {
                    $strHtml = '';
                    $childControls = $this->GetChildControls();
                    for ($i = 0, $cnt = count($childControls); $i < $cnt; ++$i) {
                        $strControlId = $childControls[$i]->ControlId;

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($foo = 'bar') { // possible typo
                    // ...
                }
                if ($baz = 0) { // always false
                    // ...
                }
            }
        }

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid using static access to class 'QType' in method '__set'.
        Open

                                $this->objTabHeadersArray = QType::Cast($mixValue, QType::ArrayType);

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
        {
            public function bar()
            {
                Bar::baz();
            }
        }

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        The method GetTabHeaderHtml uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                        else {
                            $strText = 'Tab '. ($i+1);
                        }

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($flag) {
                    // one branch
                } else {
                    // another branch
                }
            }
        }

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid assigning values to variables in if clauses and the like (line '205', column '19').
        Open

                public function ActivateTab ($mixTab) {
                    if (false !== ($i = $this->FindTabIndex($mixTab))) {
                        parent::Option2('active', $i);
                    }
                }

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($foo = 'bar') { // possible typo
                    // ...
                }
                if ($baz = 0) { // always false
                    // ...
                }
            }
        }

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        The method GetTabHeaderHtml uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                            } else {
                                $strText = (string)$objHeader;
                            }

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($flag) {
                    // one branch
                } else {
                    // another branch
                }
            }
        }

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid excessively long variable names like $blnAutoRenderChildren. Keep variable name length under 20.
        Open

                protected $blnAutoRenderChildren = true;

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
            protected $reallyLongIntName = -3; // VIOLATION - Field
            public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                $otherReallyLongName = -5; // VIOLATION - Local
                for ($interestingIntIndex = 0; // VIOLATION - For
                     $interestingIntIndex < 10;
                     $interestingIntIndex++ ) {
                }
            }
        }

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid variables with short names like $i. Configured minimum length is 3.
        Open

                    if (false !== ($i = $this->FindTabIndex($mixTab))) {

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
            private $q = 15; // VIOLATION - Field
            public static function main( array $as ) { // VIOLATION - Formal
                $r = 20 + $this->q; // VIOLATION - Local
                for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                    $r += $this->q;
                }
            }
        }

        Source https://phpmd.org/rules/naming.html#shortvariable

        Avoid variables with short names like $i. Configured minimum length is 3.
        Open

                    if (false !== ($i = $this->FindTabIndex($mixTab))) {

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
            private $q = 15; // VIOLATION - Field
            public static function main( array $as ) { // VIOLATION - Formal
                $r = 20 + $this->q; // VIOLATION - Local
                for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                    $r += $this->q;
                }
            }
        }

        Source https://phpmd.org/rules/naming.html#shortvariable

        The method FindTabIndex is not named in camelCase.
        Open

                protected function FindTabIndex ($mixTab) {
                    if ($mixTab === null) return false;
        
                    if ($this->objTabHeadersArray) {
                        $count = count($this->objTabHeadersArray);

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
            public function get_name() {
            }
        }

        Source

        The method Refresh is not named in camelCase.
        Open

                public function Refresh() {
                    parent::Refresh();
                    QControl::Refresh();
                }

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
            public function get_name() {
            }
        }

        Source

        The method ActivateTab is not named in camelCase.
        Open

                public function ActivateTab ($mixTab) {
                    if (false !== ($i = $this->FindTabIndex($mixTab))) {
                        parent::Option2('active', $i);
                    }
                }

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
            public function get_name() {
            }
        }

        Source

        The method PutState is not named in camelCase.
        Open

                protected function PutState($state) {
                    if (isset($state['active'])) {
                        $this->Active = $state['active'];
                        $this->strSelectedId = $state['selectedId'];
                    }

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
            public function get_name() {
            }
        }

        Source

        The method GetEndScript is not named in camelCase.
        Open

                public function GetEndScript() {
                    $strJS = parent::GetEndScript();
                    QApplication::ExecuteJsFunction('qcubed.tabs', $this->GetJqControlId(), QJsPriority::High);
        
                    return $strJS;

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
            public function get_name() {
            }
        }

        Source

        The method AddChildControl is not named in camelCase.
        Open

                public function AddChildControl(QControl $objControl) {
                    parent::AddChildControl($objControl);
                    if (count ($this->objChildControlArray) == 1) {
                        $this->strSelectedId = $objControl->strControlId;    // default to first item added being selected
                        $this->mixActive = 0;

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
            public function get_name() {
            }
        }

        Source

        The method ValidateControlAndChildren is not named in camelCase.
        Open

                public function ValidateControlAndChildren() {
                    // Initially Assume Validation is True
                    $blnToReturn = true;
        
                    // Check the Control Itself

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
            public function get_name() {
            }
        }

        Source

        The method GetTabHeaderHtml is not named in camelCase.
        Open

                protected function GetTabHeaderHtml() {
                    $strHtml = '';
                    $childControls = $this->GetChildControls();
                    for ($i = 0, $cnt = count($childControls); $i < $cnt; ++$i) {
                        $strControlId = $childControls[$i]->ControlId;

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
            public function get_name() {
            }
        }

        Source

        The method GetState is not named in camelCase.
        Open

                protected function GetState() {
                    return ['active'=>$this->Active, 'selectedId'=>$this->strSelectedId];
                }

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
            public function get_name() {
            }
        }

        Source

        The method SetHeader is not named in camelCase.
        Open

                public function SetHeader($mixHeaderIndicator, $mixHeader) {
                    $key = ($mixHeaderIndicator instanceof QControl) ? $mixHeaderIndicator->ControlId : $mixHeaderIndicator;
                    $this->objTabHeadersArray[$key] = $mixHeader;
                }

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
            public function get_name() {
            }
        }

        Source

        The method EnableTab is not named in camelCase.
        Open

                public function EnableTab ($mixTab = null, $blnEnable = true) {
        
                    if (is_null($mixTab)) {
                        if ($blnEnable) {
                            parent::Enable();

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
            public function get_name() {
            }
        }

        Source

        The method RenderChildren is not named in camelCase.
        Open

                protected function RenderChildren($blnDisplayOutput = true) {
                    $strToReturn = $this->GetTabHeaderHtml();
        
                    foreach ($this->GetChildControls() as $objControl) {
                        if (!$objControl->Rendered) {

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
            public function get_name() {
            }
        }

        Source

        There are no issues that match your filters.

        Category
        Status