qcubed/framework

View on GitHub
includes/base_controls/_actions.inc.php

Summary

Maintainability
F
4 days
Test Coverage

File _actions.inc.php has 564 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
    /**
     * This file contains all basic action classes: QAction, QServerAction, QAjaxAction, etc.
     *
     * @package Actions
Severity: Major
Found in includes/base_controls/_actions.inc.php - About 1 day to fix

    Function RenderActions has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
    Open

            public static function RenderActions(QControl $objControl, $strEventName, $objActions) {
                $strToReturn = '';
                $strJqUiProperty = null;
    
                if ($objControl->ActionsMustTerminate) {
    Severity: Minor
    Found in includes/base_controls/_actions.inc.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method RenderActions has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public static function RenderActions(QControl $objControl, $strEventName, $objActions) {
                $strToReturn = '';
                $strJqUiProperty = null;
    
                if ($objControl->ActionsMustTerminate) {
    Severity: Major
    Found in includes/base_controls/_actions.inc.php - About 2 hrs to fix

      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              public function __construct(QControl $objControl, $strMethodName, $objWaitIconControl = 'default',
                                          $mixCausesValidationOverride = null, $strJsReturnParam = "", $blnAsync = false) {
      Severity: Minor
      Found in includes/base_controls/_actions.inc.php - About 45 mins to fix

        Function RenderScript has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

                public function RenderScript(QControl $objControl) {
                    $strWaitIconControlId = null;
                    if ($this->strId == null) {
                        $this->strId = $objControl->Form->GenerateAjaxActionId();
                    }
        Severity: Minor
        Found in includes/base_controls/_actions.inc.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                public function __construct($strMethodName = null, $objWaitIconControl = 'default',
                                            $mixCausesValidationOverride = null, $strJsReturnParam = "", $blnAsync = false) {
        Severity: Minor
        Found in includes/base_controls/_actions.inc.php - About 35 mins to fix

          Avoid too many return statements within this method.
          Open

                                  return parent::__get($strName);
          Severity: Major
          Found in includes/base_controls/_actions.inc.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return $this->strId;
            Severity: Major
            Found in includes/base_controls/_actions.inc.php - About 30 mins to fix

              The method RenderActions() has an NPath complexity of 910. The configured NPath complexity threshold is 200.
              Open

                      public static function RenderActions(QControl $objControl, $strEventName, $objActions) {
                          $strToReturn = '';
                          $strJqUiProperty = null;
              
                          if ($objControl->ActionsMustTerminate) {

              NPathComplexity

              Since: 0.1

              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

              Example

              class Foo {
                  function bar() {
                      // lots of complicated code
                  }
              }

              Source https://phpmd.org/rules/codesize.html#npathcomplexity

              The method RenderActions() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10.
              Open

                      public static function RenderActions(QControl $objControl, $strEventName, $objActions) {
                          $strToReturn = '';
                          $strJqUiProperty = null;
              
                          if ($objControl->ActionsMustTerminate) {

              CyclomaticComplexity

              Since: 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example

              // Cyclomatic Complexity = 11
              class Foo {
              1   public function example() {
              2       if ($a == $b) {
              3           if ($a1 == $b1) {
                              fiddle();
              4           } elseif ($a2 == $b2) {
                              fiddle();
                          } else {
                              fiddle();
                          }
              5       } elseif ($c == $d) {
              6           while ($c == $d) {
                              fiddle();
                          }
              7        } elseif ($e == $f) {
              8           for ($n = 0; $n < $h; $n++) {
                              fiddle();
                          }
                      } else {
                          switch ($z) {
              9               case 1:
                                  fiddle();
                                  break;
              10              case 2:
                                  fiddle();
                                  break;
              11              case 3:
                                  fiddle();
                                  break;
                              default:
                                  fiddle();
                                  break;
                          }
                      }
                  }
              }

              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

              The class QAction has 25 children. Consider to rebalance this class hierarchy to keep number of children under 15.
              Open

                  abstract class QAction extends QBaseClass {
                      /**
                       * Abstract method, implemented in derived classes. Returns the JS needed for the action to work
                       *
                       * @param QControl $objControl

              NumberOfChildren

              Since: 0.2

              A class with an excessive number of children is an indicator for an unbalanced class hierarchy. You should consider to refactor this class hierarchy.

              Example

              Source https://phpmd.org/rules/design.html#numberofchildren

              Missing class import via use statement (line '1001', column '15').
              Open

                              throw new QCallerException('First parameter of constructor is expecting an object of type QDialog');

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '1037', column '15').
              Open

                              throw new QCallerException('First parameter of constructor is expecting an object of type QControl');

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              The method __construct has a boolean flag argument $blnAsync, which is a certain sign of a Single Responsibility Principle violation.
              Open

                                                  $mixCausesValidationOverride = null, $strJsReturnParam = "", $blnAsync = false) {

              BooleanArgumentFlag

              Since: 1.4.0

              A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

              Example

              class Foo {
                  public function bar($flag = true) {
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

              Missing class import via use statement (line '1075', column '15').
              Open

                              throw new QCallerException('First parameter of constructor is expecting an object of type QControl');

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              The method __construct has a boolean flag argument $blnAsync, which is a certain sign of a Single Responsibility Principle violation.
              Open

                                                  $mixCausesValidationOverride = null, $strJsReturnParam = "", $blnAsync = false) {

              BooleanArgumentFlag

              Since: 1.4.0

              A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

              Example

              class Foo {
                  public function bar($flag = true) {
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

              Missing class import via use statement (line '761', column '15').
              Open

                              throw new QCallerException('First parameter of constructor is expecting an object of type QControl');

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '964', column '15').
              Open

                              throw new QCallerException('First parameter of constructor is expecting an object of type QDialog');

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '1303', column '15').
              Open

                              throw new QCallerException('First parameter of constructor is expecting an object of type QCalendar');

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '47', column '17').
              Open

                                      throw new Exception('Invalid Action Event in this entry in the ActionArray');

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '927', column '15').
              Open

                              throw new QCallerException('First parameter of constructor is expecting an object of type QDialogBox');

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '1110', column '15').
              Open

                              throw new QCallerException('First parameter of constructor is expecting an object of type QTextBox');

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              The method __construct has a boolean flag argument $blnOverride, which is a certain sign of a Single Responsibility Principle violation.
              Open

                      public function __construct($strTemporaryCssClass = null, $blnOverride = false) {

              BooleanArgumentFlag

              Since: 1.4.0

              A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

              Example

              class Foo {
                  public function bar($flag = true) {
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

              Missing class import via use statement (line '1270', column '15').
              Open

                              throw new QCallerException('First parameter of constructor is expecting an object of type QCalendar');

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '890', column '15').
              Open

                              throw new QCallerException('First parameter of constructor is expecting an object of type QDialogBox');

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '814', column '15').
              Open

                              throw new QCallerException('First parameter of constructor is expecting an object of type QControl');

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
                  return new \stdClass();
              }

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Avoid using static access to class 'QString' in method '__construct'.
              Open

                          if (QString::LastCharacter($this->strJavaScript) == ';') {

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'JavaScriptHelper' in method 'RenderScript'.
              Open

                          $strMessage = JavaScriptHelper::toJsObject($this->strMessage);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'JavaScriptHelper' in method 'RenderScript'.
              Open

                          $strMessage = JavaScriptHelper::toJsObject($this->strMessage);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method RenderScript uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                          } else {
                              $strSelector = '#' . $objControl->ControlId;
                          }

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method RenderActions uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                              } else {
                                  $strOut = sprintf('$j("#%s").on("%s", function(event, ui){%s});',
                                      $objControl->getJqControlId(),
                                      $strEventName, $strToReturn);
              
              

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method RenderActions uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                                  } else {
                                      $strOut = sprintf('$j("#%s").on("%s", "[data-qpxy=\'%s\']", function(event, ui){%s});', $objControl->Form->FormId, $strEventName, $objControl->ControlId, $strToReturn);
                                  }

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid using static access to class 'QType' in method '__set'.
              Open

                                  return ($this->objEvent = QType::Cast($mixValue, 'QEvent'));

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method RenderScript uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                              } else {
                                  $strEnableOrDisable = '';
                              }

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid assigning values to variables in if clauses and the like (line '238', column '8').
              Open

                      protected function getActionParameter($objControl) {
                          if ($objActionParameter = $this->strJsReturnParam) {
                              return $objActionParameter;
                          }
                          if ($objActionParameter = $this->objEvent->JsReturnParam) {

              IfStatementAssignment

              Since: 2.7.0

              Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($foo = 'bar') { // possible typo
                          // ...
                      }
                      if ($baz = 0) { // always false
                          // ...
                      }
                  }
              }

              Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

              The method RenderScript uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                              } else {
                                  // Use Temp Css Class Outright
                                  return sprintf("qc.getC('%s').className = '%s';", $objControl->ControlId, $this->strTemporaryCssClass);
                              }

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid assigning values to variables in if clauses and the like (line '383', column '8').
              Open

                      protected function getActionParameter($objControl) {
                          if ($objActionParameter = $this->strJsReturnParam) {
                              return $objActionParameter;
                          }
                          if ($objActionParameter = $this->objEvent->JsReturnParam) {

              IfStatementAssignment

              Since: 2.7.0

              Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($foo = 'bar') { // possible typo
                          // ...
                      }
                      if ($baz = 0) { // always false
                          // ...
                      }
                  }
              }

              Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

              The method RenderScript uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                          } else {
                              if ($this->objWaitIconControl) {
                                  $strWaitIconControlId = $this->objWaitIconControl->ControlId;
                              }
                          }

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method RenderScript uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                          } else {
                              if ($this->blnDisplay === false) {
                                  $strShowOrHide = 'hide';
                              } else {
                                  $strShowOrHide = '';

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid using static access to class 'QType' in method '__construct'.
              Open

                              $this->blnDisplay = QType::Cast($blnDisplay, QType::Boolean);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method RenderScript uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                              } else {
                                  $strShowOrHide = '';
                              }

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid using static access to class 'QType' in method '__construct'.
              Open

                              $this->blnEnabled = QType::Cast($blnEnabled, QType::Boolean);

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method RenderScript uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                          } else {
                              // Are we overriding or are we displaying this temporary css class outright?
                              if ($this->blnOverride) {
                                  // Overriding
                                  return sprintf("qc.getC('%s').className = '%s %s';", $objControl->ControlId, $objControl->CssClass, $this->strTemporaryCssClass);

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid assigning values to variables in if clauses and the like (line '380', column '8').
              Open

                      protected function getActionParameter($objControl) {
                          if ($objActionParameter = $this->strJsReturnParam) {
                              return $objActionParameter;
                          }
                          if ($objActionParameter = $this->objEvent->JsReturnParam) {

              IfStatementAssignment

              Since: 2.7.0

              Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($foo = 'bar') { // possible typo
                          // ...
                      }
                      if ($baz = 0) { // always false
                          // ...
                      }
                  }
              }

              Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

              The method RenderScript uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                          } else {
                              if ($this->blnEnabled === false) {
                                  $strEnableOrDisable = 'disable';
                              } else {
                                  $strEnableOrDisable = '';

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid assigning values to variables in if clauses and the like (line '241', column '8').
              Open

                      protected function getActionParameter($objControl) {
                          if ($objActionParameter = $this->strJsReturnParam) {
                              return $objActionParameter;
                          }
                          if ($objActionParameter = $this->objEvent->JsReturnParam) {

              IfStatementAssignment

              Since: 2.7.0

              Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($foo = 'bar') { // possible typo
                          // ...
                      }
                      if ($baz = 0) { // always false
                          // ...
                      }
                  }
              }

              Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

              TODO found
              Open

                   * a "loading" state. TODO: Convert this to a FontAwesome animated icon.

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  class QToggleDisplayAction extends QAction {
                      /** @var string Control ID of the control */
                      protected $strControlId = null;
                      /** @var boolean|null Enforce 'show' or 'hide' action */
                      protected $blnDisplay = null;
              Severity: Major
              Found in includes/base_controls/_actions.inc.php and 1 other location - About 5 hrs to fix
              includes/base_controls/_actions.inc.php on lines 800..844

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 195.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  class QToggleEnableAction extends QAction {
                      /** @var null|string Control ID of the control to be Enabled/Disabled */
                      protected $strControlId = null;
                      /** @var boolean|null Enforce the Enabling or Disabling action */
                      protected $blnEnabled = null;
              Severity: Major
              Found in includes/base_controls/_actions.inc.php and 1 other location - About 5 hrs to fix
              includes/base_controls/_actions.inc.php on lines 747..792

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 195.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  class QConfirmAction extends QAction {
                      /** @var string Message to be shown to the user on the confirmation prompt */
                      protected $strMessage;
              
                      /**
              Severity: Major
              Found in includes/base_controls/_actions.inc.php and 1 other location - About 1 hr to fix
              includes/base_controls/_actions.inc.php on lines 635..682

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 120.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  class QAlertAction extends QAction {
                      /** @var string Message to be shown as the alert */
                      protected $strMessage;
              
                      /**
              Severity: Major
              Found in includes/base_controls/_actions.inc.php and 1 other location - About 1 hr to fix
              includes/base_controls/_actions.inc.php on lines 583..628

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 120.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  class QShowDialog extends QAction {
                      /** @var null|string The JS to show the dialog */
                      protected $strJavaScript = null;
              
                      /**
              Severity: Minor
              Found in includes/base_controls/_actions.inc.php and 1 other location - About 30 mins to fix
              includes/base_controls/_actions.inc.php on lines 988..1018

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 91.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  class QHideDialog extends QAction {
                      /** @var null|string JS to be executed on the client side for closing the dialog */
                      protected $strJavaScript = null;
              
                      /**
              Severity: Minor
              Found in includes/base_controls/_actions.inc.php and 1 other location - About 30 mins to fix
              includes/base_controls/_actions.inc.php on lines 951..981

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 91.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid excessively long variable names like $mixCausesValidationOverride. Keep variable name length under 20.
              Open

                      protected $mixCausesValidationOverride;

              LongVariable

              Since: 0.2

              Detects when a field, formal or local variable is declared with a long name.

              Example

              class Something {
                  protected $reallyLongIntName = -3; // VIOLATION - Field
                  public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                      $otherReallyLongName = -5; // VIOLATION - Local
                      for ($interestingIntIndex = 0; // VIOLATION - For
                           $interestingIntIndex < 10;
                           $interestingIntIndex++ ) {
                      }
                  }
              }

              Source https://phpmd.org/rules/naming.html#longvariable

              Avoid excessively long variable names like $mixCausesValidationOverride. Keep variable name length under 20.
              Open

                      public function __construct(QControl $objControl, $strMethodName, $mixCausesValidationOverride = null,

              LongVariable

              Since: 0.2

              Detects when a field, formal or local variable is declared with a long name.

              Example

              class Something {
                  protected $reallyLongIntName = -3; // VIOLATION - Field
                  public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                      $otherReallyLongName = -5; // VIOLATION - Local
                      for ($interestingIntIndex = 0; // VIOLATION - For
                           $interestingIntIndex < 10;
                           $interestingIntIndex++ ) {
                      }
                  }
              }

              Source https://phpmd.org/rules/naming.html#longvariable

              Avoid excessively long variable names like $mixCausesValidationOverride. Keep variable name length under 20.
              Open

                                                  $mixCausesValidationOverride = null, $strJsReturnParam = "", $blnAsync = false) {

              LongVariable

              Since: 0.2

              Detects when a field, formal or local variable is declared with a long name.

              Example

              class Something {
                  protected $reallyLongIntName = -3; // VIOLATION - Field
                  public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                      $otherReallyLongName = -5; // VIOLATION - Local
                      for ($interestingIntIndex = 0; // VIOLATION - For
                           $interestingIntIndex < 10;
                           $interestingIntIndex++ ) {
                      }
                  }
              }

              Source https://phpmd.org/rules/naming.html#longvariable

              Avoid excessively long variable names like $mixCausesValidationOverride. Keep variable name length under 20.
              Open

                                                  $mixCausesValidationOverride = null, $strJsReturnParam = "", $blnAsync = false) {

              LongVariable

              Since: 0.2

              Detects when a field, formal or local variable is declared with a long name.

              Example

              class Something {
                  protected $reallyLongIntName = -3; // VIOLATION - Field
                  public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                      $otherReallyLongName = -5; // VIOLATION - Local
                      for ($interestingIntIndex = 0; // VIOLATION - For
                           $interestingIntIndex < 10;
                           $interestingIntIndex++ ) {
                      }
                  }
              }

              Source https://phpmd.org/rules/naming.html#longvariable

              Avoid excessively long variable names like $mixCausesValidationOverride. Keep variable name length under 20.
              Open

                      protected $mixCausesValidationOverride;

              LongVariable

              Since: 0.2

              Detects when a field, formal or local variable is declared with a long name.

              Example

              class Something {
                  protected $reallyLongIntName = -3; // VIOLATION - Field
                  public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                      $otherReallyLongName = -5; // VIOLATION - Local
                      for ($interestingIntIndex = 0; // VIOLATION - For
                           $interestingIntIndex < 10;
                           $interestingIntIndex++ ) {
                      }
                  }
              }

              Source https://phpmd.org/rules/naming.html#longvariable

              Avoid excessively long variable names like $mixCausesValidationOverride. Keep variable name length under 20.
              Open

                      public function __construct($strMethodName = null, $mixCausesValidationOverride = null,

              LongVariable

              Since: 0.2

              Detects when a field, formal or local variable is declared with a long name.

              Example

              class Something {
                  protected $reallyLongIntName = -3; // VIOLATION - Field
                  public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                      $otherReallyLongName = -5; // VIOLATION - Local
                      for ($interestingIntIndex = 0; // VIOLATION - For
                           $interestingIntIndex < 10;
                           $interestingIntIndex++ ) {
                      }
                  }
              }

              Source https://phpmd.org/rules/naming.html#longvariable

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          return sprintf("qcubed.clearTimeout('%s');", $objControl->ControlId);
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          return sprintf("qc.getW('%s').select();", $this->strControlId);
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          return sprintf('%s;', $this->strJavaScript);
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          $strMessage = JavaScriptHelper::toJsObject($this->strMessage);
              
                          return sprintf("if (!confirm(%s)) return false;", $strMessage);
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          return $this->strJavaScript;
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          if ($this->strControlId == null) {
                              $this->strControlId = $objControl->ControlId;
                          }
              
              

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          return sprintf("jQuery('#%s').val('%s');", $this->strControlId, $this->strValue);
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          if ($this->blnDisplay === true) {
                              $strShowOrHide = 'show';
                          } else {
                              if ($this->blnDisplay === false) {

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          return sprintf("qc.getC('%s').showCalendar();", $this->strControlId);
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          return sprintf('%s;', $this->strJavaScript);
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          return sprintf("qc.pB('%s', '%s', '%s', %s);",
                              $objControl->Form->FormId, $objControl->ControlId, get_class($this->objEvent), $this->getActionParameter($objControl));
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          return (sprintf('%s; qcubed.recordControlModification("%s", "Display", "1");', $this->strJavaScript, $this->strControlId));
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          return sprintf("qc.getC('%s').hideCalendar();", $this->strControlId);
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      abstract public function RenderScript(QControl $objControl);

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          $strMessage = JavaScriptHelper::toJsObject($this->strMessage);
              
                          return sprintf("alert(%s);", $strMessage);
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          // Specified a Temporary Css Class to use?
                          if (is_null($this->strTemporaryCssClass)) {
                              // No Temporary CSS Class -- use the Control's already-defined one
                              return sprintf("qc.getC('%s').className = '%s';", $objControl->ControlId, $objControl->CssClass);

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          $strWaitIconControlId = null;
                          if ($this->strId == null) {
                              $this->strId = $objControl->Form->GenerateAjaxActionId();
                          }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          if ($this->blnEnabled === true) {
                              $strEnableOrDisable = 'enable';
                          } else {
                              if ($this->blnEnabled === false) {

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          return sprintf("qc.getW('%s').blur();", $this->strControlId);
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          return 'event.stopPropagation();';
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          return $this->strJavaScript;
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          // for firefox focus is special when in a blur or in a focusout event
                          // http://stackoverflow.com/questions/7046798/jquery-focus-fails-on-firefox/7046837#7046837
                          return sprintf("setTimeout(function(){qc.getW('%s').focus();},0);", $this->strControlId);
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          return 'event.preventDefault();';
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          // Specified a Temporary Css Class to use?
                          if ($this->strTargetSelector) {
                              $strSelector = $this->strTargetSelector;
                          } else {

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderActions is not named in camelCase.
              Open

                      public static function RenderActions(QControl $objControl, $strEventName, $objActions) {
                          $strToReturn = '';
                          $strJqUiProperty = null;
              
                          if ($objControl->ActionsMustTerminate) {

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          return sprintf("qc.getW('%s').registerClickPosition(event);", $objControl->ControlId);
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              The method RenderScript is not named in camelCase.
              Open

                      public function RenderScript(QControl $objControl) {
                          return $this->strJavaScript;
                      }

              CamelCaseMethodName

              Since: 0.2

              It is considered best practice to use the camelCase notation to name methods.

              Example

              class ClassName {
                  public function get_name() {
                  }
              }

              Source

              There are no issues that match your filters.

              Category
              Status