qcubed/framework

View on GitHub
includes/codegen/QSqlTable.class.php

Summary

Maintainability
D
1 day
Test Coverage

Function HasExtendedArrayExpansions has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

        public function HasExtendedArrayExpansions(QDatabaseCodeGen $objCodeGen, $objCheckedTableArray = array()) {
            $objCheckedTableArray[] = $this;
            foreach ($this->ColumnArray as $objColumn) {
                if (($objReference = $objColumn->Reference) && !$objReference->IsType) {
                    if ($objTable2 = $objCodeGen->GetTable($objReference->Table)) {
Severity: Minor
Found in includes/codegen/QSqlTable.class.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __get has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public function __get($strName) {
            switch ($strName) {
                case 'OwnerDbIndex':
                    return $this->intOwnerDbIndex;
                case 'Name':
Severity: Minor
Found in includes/codegen/QSqlTable.class.php - About 1 hr to fix

    Function __get has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

            public function __get($strName) {
                switch ($strName) {
                    case 'OwnerDbIndex':
                        return $this->intOwnerDbIndex;
                    case 'Name':
    Severity: Minor
    Found in includes/codegen/QSqlTable.class.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __set has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public function __set($strName, $mixValue) {
                try {
                    switch ($strName) {
                        case 'OwnerDbIndex':
                            return $this->intOwnerDbIndex = QType::Cast($mixValue, QType::Integer);
    Severity: Minor
    Found in includes/codegen/QSqlTable.class.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                              return $this->objManyToManyReferenceArray = QType::Cast($mixValue, QType::ArrayType);
      Severity: Major
      Found in includes/codegen/QSqlTable.class.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                                return parent::__get($strName);
        Severity: Major
        Found in includes/codegen/QSqlTable.class.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                                  return parent::__set($strName, $mixValue);
          Severity: Major
          Found in includes/codegen/QSqlTable.class.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return (array) $this->objManyToManyReferenceArray;
            Severity: Major
            Found in includes/codegen/QSqlTable.class.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return (array) $this->objColumnArray;
              Severity: Major
              Found in includes/codegen/QSqlTable.class.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                        return $this->objIndexArray = QType::Cast($mixValue, QType::ArrayType);
                Severity: Major
                Found in includes/codegen/QSqlTable.class.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                          return $this->objColumnArray = QType::Cast($mixValue, QType::ArrayType);
                  Severity: Major
                  Found in includes/codegen/QSqlTable.class.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                        return (array) $this->objReverseReferenceArray;
                    Severity: Major
                    Found in includes/codegen/QSqlTable.class.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                              return $this->options = QType::Cast($mixValue, QType::ArrayType);
                      Severity: Major
                      Found in includes/codegen/QSqlTable.class.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                            return $this->options;
                        Severity: Major
                        Found in includes/codegen/QSqlTable.class.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                              return (array) $this->objIndexArray;
                          Severity: Major
                          Found in includes/codegen/QSqlTable.class.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                                    return $objToReturn;
                            Severity: Major
                            Found in includes/codegen/QSqlTable.class.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                                  return $intCount;
                              Severity: Major
                              Found in includes/codegen/QSqlTable.class.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                        return null;
                                Severity: Major
                                Found in includes/codegen/QSqlTable.class.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                          return $this->objReverseReferenceArray = QType::Cast($mixValue, QType::ArrayType);
                                  Severity: Major
                                  Found in includes/codegen/QSqlTable.class.php - About 30 mins to fix

                                    Function GetColumnByName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                            public function GetColumnByName($strColumnName) {
                                                if ($this->objColumnArray) {
                                                    foreach ($this->objColumnArray as $objColumn){
                                                        if ($objColumn->Name == $strColumnName)
                                                            return $objColumn;
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php - About 25 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    The method __get() has a Cyclomatic Complexity of 18. The configured cyclomatic complexity threshold is 10.
                                    Open

                                            public function __get($strName) {
                                                switch ($strName) {
                                                    case 'OwnerDbIndex':
                                                        return $this->intOwnerDbIndex;
                                                    case 'Name':
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    CyclomaticComplexity

                                    Since: 0.1

                                    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                    Example

                                    // Cyclomatic Complexity = 11
                                    class Foo {
                                    1   public function example() {
                                    2       if ($a == $b) {
                                    3           if ($a1 == $b1) {
                                                    fiddle();
                                    4           } elseif ($a2 == $b2) {
                                                    fiddle();
                                                } else {
                                                    fiddle();
                                                }
                                    5       } elseif ($c == $d) {
                                    6           while ($c == $d) {
                                                    fiddle();
                                                }
                                    7        } elseif ($e == $f) {
                                    8           for ($n = 0; $n < $h; $n++) {
                                                    fiddle();
                                                }
                                            } else {
                                                switch ($z) {
                                    9               case 1:
                                                        fiddle();
                                                        break;
                                    10              case 2:
                                                        fiddle();
                                                        break;
                                    11              case 3:
                                                        fiddle();
                                                        break;
                                                    default:
                                                        fiddle();
                                                        break;
                                                }
                                            }
                                        }
                                    }

                                    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                    The method __set() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                                    Open

                                            public function __set($strName, $mixValue) {
                                                try {
                                                    switch ($strName) {
                                                        case 'OwnerDbIndex':
                                                            return $this->intOwnerDbIndex = QType::Cast($mixValue, QType::Integer);
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    CyclomaticComplexity

                                    Since: 0.1

                                    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                    Example

                                    // Cyclomatic Complexity = 11
                                    class Foo {
                                    1   public function example() {
                                    2       if ($a == $b) {
                                    3           if ($a1 == $b1) {
                                                    fiddle();
                                    4           } elseif ($a2 == $b2) {
                                                    fiddle();
                                                } else {
                                                    fiddle();
                                                }
                                    5       } elseif ($c == $d) {
                                    6           while ($c == $d) {
                                                    fiddle();
                                                }
                                    7        } elseif ($e == $f) {
                                    8           for ($n = 0; $n < $h; $n++) {
                                                    fiddle();
                                                }
                                            } else {
                                                switch ($z) {
                                    9               case 1:
                                                        fiddle();
                                                        break;
                                    10              case 2:
                                                        fiddle();
                                                        break;
                                    11              case 3:
                                                        fiddle();
                                                        break;
                                                    default:
                                                        fiddle();
                                                        break;
                                                }
                                            }
                                        }
                                    }

                                    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                    Avoid assigning values to variables in if clauses and the like (line '145', column '10').
                                    Open

                                            public function HasExtendedArrayExpansions(QDatabaseCodeGen $objCodeGen, $objCheckedTableArray = array()) {
                                                $objCheckedTableArray[] = $this;
                                                foreach ($this->ColumnArray as $objColumn) {
                                                    if (($objReference = $objColumn->Reference) && !$objReference->IsType) {
                                                        if ($objTable2 = $objCodeGen->GetTable($objReference->Table)) {
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    IfStatementAssignment

                                    Since: 2.7.0

                                    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                    Example

                                    class Foo
                                    {
                                        public function bar($flag)
                                        {
                                            if ($foo = 'bar') { // possible typo
                                                // ...
                                            }
                                            if ($baz = 0) { // always false
                                                // ...
                                            }
                                        }
                                    }

                                    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                    Avoid using static access to class 'QType' in method '__set'.
                                    Open

                                                            return $this->objReverseReferenceArray = QType::Cast($mixValue, QType::ArrayType);
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    StaticAccess

                                    Since: 1.4.0

                                    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                    Example

                                    class Foo
                                    {
                                        public function bar()
                                        {
                                            Bar::baz();
                                        }
                                    }

                                    Source https://phpmd.org/rules/cleancode.html#staticaccess

                                    Avoid using static access to class 'QType' in method '__set'.
                                    Open

                                                            return $this->intOwnerDbIndex = QType::Cast($mixValue, QType::Integer);
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    StaticAccess

                                    Since: 1.4.0

                                    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                    Example

                                    class Foo
                                    {
                                        public function bar()
                                        {
                                            Bar::baz();
                                        }
                                    }

                                    Source https://phpmd.org/rules/cleancode.html#staticaccess

                                    Avoid using static access to class 'QType' in method '__set'.
                                    Open

                                                            return $this->strClassName = QType::Cast($mixValue, QType::String);
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    StaticAccess

                                    Since: 1.4.0

                                    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                    Example

                                    class Foo
                                    {
                                        public function bar()
                                        {
                                            Bar::baz();
                                        }
                                    }

                                    Source https://phpmd.org/rules/cleancode.html#staticaccess

                                    Avoid assigning values to variables in if clauses and the like (line '146', column '10').
                                    Open

                                            public function HasExtendedArrayExpansions(QDatabaseCodeGen $objCodeGen, $objCheckedTableArray = array()) {
                                                $objCheckedTableArray[] = $this;
                                                foreach ($this->ColumnArray as $objColumn) {
                                                    if (($objReference = $objColumn->Reference) && !$objReference->IsType) {
                                                        if ($objTable2 = $objCodeGen->GetTable($objReference->Table)) {
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    IfStatementAssignment

                                    Since: 2.7.0

                                    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                    Example

                                    class Foo
                                    {
                                        public function bar($flag)
                                        {
                                            if ($foo = 'bar') { // possible typo
                                                // ...
                                            }
                                            if ($baz = 0) { // always false
                                                // ...
                                            }
                                        }
                                    }

                                    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                    Avoid using static access to class 'QType' in method '__set'.
                                    Open

                                                            return $this->strName = QType::Cast($mixValue, QType::String);
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    StaticAccess

                                    Since: 1.4.0

                                    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                    Example

                                    class Foo
                                    {
                                        public function bar()
                                        {
                                            Bar::baz();
                                        }
                                    }

                                    Source https://phpmd.org/rules/cleancode.html#staticaccess

                                    Avoid using static access to class 'QType' in method '__set'.
                                    Open

                                                            return $this->strClassNamePlural = QType::Cast($mixValue, QType::String);
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    StaticAccess

                                    Since: 1.4.0

                                    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                    Example

                                    class Foo
                                    {
                                        public function bar()
                                        {
                                            Bar::baz();
                                        }
                                    }

                                    Source https://phpmd.org/rules/cleancode.html#staticaccess

                                    Avoid using static access to class 'QType' in method '__set'.
                                    Open

                                                            return $this->objManyToManyReferenceArray = QType::Cast($mixValue, QType::ArrayType);
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    StaticAccess

                                    Since: 1.4.0

                                    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                    Example

                                    class Foo
                                    {
                                        public function bar()
                                        {
                                            Bar::baz();
                                        }
                                    }

                                    Source https://phpmd.org/rules/cleancode.html#staticaccess

                                    Avoid using static access to class 'QType' in method '__set'.
                                    Open

                                                            return $this->objColumnArray = QType::Cast($mixValue, QType::ArrayType);
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    StaticAccess

                                    Since: 1.4.0

                                    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                    Example

                                    class Foo
                                    {
                                        public function bar()
                                        {
                                            Bar::baz();
                                        }
                                    }

                                    Source https://phpmd.org/rules/cleancode.html#staticaccess

                                    Avoid using static access to class 'QType' in method '__set'.
                                    Open

                                                            return $this->options = QType::Cast($mixValue, QType::ArrayType);
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    StaticAccess

                                    Since: 1.4.0

                                    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                    Example

                                    class Foo
                                    {
                                        public function bar()
                                        {
                                            Bar::baz();
                                        }
                                    }

                                    Source https://phpmd.org/rules/cleancode.html#staticaccess

                                    Avoid using static access to class 'QType' in method '__set'.
                                    Open

                                                            return $this->objIndexArray = QType::Cast($mixValue, QType::ArrayType);
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    StaticAccess

                                    Since: 1.4.0

                                    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                    Example

                                    class Foo
                                    {
                                        public function bar()
                                        {
                                            Bar::baz();
                                        }
                                    }

                                    Source https://phpmd.org/rules/cleancode.html#staticaccess

                                    Avoid excessively long variable names like $objReverseReferenceArray. Keep variable name length under 20.
                                    Open

                                            protected $objReverseReferenceArray;
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    LongVariable

                                    Since: 0.2

                                    Detects when a field, formal or local variable is declared with a long name.

                                    Example

                                    class Something {
                                        protected $reallyLongIntName = -3; // VIOLATION - Field
                                        public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                                            $otherReallyLongName = -5; // VIOLATION - Local
                                            for ($interestingIntIndex = 0; // VIOLATION - For
                                                 $interestingIntIndex < 10;
                                                 $interestingIntIndex++ ) {
                                            }
                                        }
                                    }

                                    Source https://phpmd.org/rules/naming.html#longvariable

                                    Avoid excessively long variable names like $objManyToManyReferenceArray. Keep variable name length under 20.
                                    Open

                                            protected $objManyToManyReferenceArray;
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    LongVariable

                                    Since: 0.2

                                    Detects when a field, formal or local variable is declared with a long name.

                                    Example

                                    class Something {
                                        protected $reallyLongIntName = -3; // VIOLATION - Field
                                        public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                                            $otherReallyLongName = -5; // VIOLATION - Local
                                            for ($interestingIntIndex = 0; // VIOLATION - For
                                                 $interestingIntIndex < 10;
                                                 $interestingIntIndex++ ) {
                                            }
                                        }
                                    }

                                    Source https://phpmd.org/rules/naming.html#longvariable

                                    The method LookupColumnPropertyName is not named in camelCase.
                                    Open

                                            public function LookupColumnPropertyName($strColumnName){
                                                $objColumn = $this->GetColumnByName($strColumnName);
                                                if ($objColumn)
                                                    return $objColumn->PropertyName;
                                                else
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    CamelCaseMethodName

                                    Since: 0.2

                                    It is considered best practice to use the camelCase notation to name methods.

                                    Example

                                    class ClassName {
                                        public function get_name() {
                                        }
                                    }

                                    Source

                                    The method HasImmediateArrayExpansions is not named in camelCase.
                                    Open

                                            public function HasImmediateArrayExpansions() { 
                                                $intCount = count($this->objManyToManyReferenceArray);
                                                foreach ($this->objReverseReferenceArray as $objReverseReference) {
                                                    if (!$objReverseReference->Unique) {
                                                        $intCount++;
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    CamelCaseMethodName

                                    Since: 0.2

                                    It is considered best practice to use the camelCase notation to name methods.

                                    Example

                                    class ClassName {
                                        public function get_name() {
                                        }
                                    }

                                    Source

                                    The method HasColumn is not named in camelCase.
                                    Open

                                            public function HasColumn($strColumnName){
                                                return ($this->GetColumnByName($strColumnName) !== null);
                                            }
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    CamelCaseMethodName

                                    Since: 0.2

                                    It is considered best practice to use the camelCase notation to name methods.

                                    Example

                                    class ClassName {
                                        public function get_name() {
                                        }
                                    }

                                    Source

                                    The method GetColumnByName is not named in camelCase.
                                    Open

                                            public function GetColumnByName($strColumnName) {
                                                if ($this->objColumnArray) {
                                                    foreach ($this->objColumnArray as $objColumn){
                                                        if ($objColumn->Name == $strColumnName)
                                                            return $objColumn;
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    CamelCaseMethodName

                                    Since: 0.2

                                    It is considered best practice to use the camelCase notation to name methods.

                                    Example

                                    class ClassName {
                                        public function get_name() {
                                        }
                                    }

                                    Source

                                    The method HasExtendedArrayExpansions is not named in camelCase.
                                    Open

                                            public function HasExtendedArrayExpansions(QDatabaseCodeGen $objCodeGen, $objCheckedTableArray = array()) {
                                                $objCheckedTableArray[] = $this;
                                                foreach ($this->ColumnArray as $objColumn) {
                                                    if (($objReference = $objColumn->Reference) && !$objReference->IsType) {
                                                        if ($objTable2 = $objCodeGen->GetTable($objReference->Table)) {
                                    Severity: Minor
                                    Found in includes/codegen/QSqlTable.class.php by phpmd

                                    CamelCaseMethodName

                                    Since: 0.2

                                    It is considered best practice to use the camelCase notation to name methods.

                                    Example

                                    class ClassName {
                                        public function get_name() {
                                        }
                                    }

                                    Source

                                    There are no issues that match your filters.

                                    Category
                                    Status