qcubed/framework

View on GitHub
includes/framework/QBaseClass.class.php

Summary

Maintainability
C
1 day
Test Coverage

Function OverrideAttributes has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
Open

        public final function OverrideAttributes($mixOverrideArray) {
            // Iterate through the OverrideAttribute Array
            if ($mixOverrideArray) foreach ($mixOverrideArray as $mixOverrideItem) {
                if (is_array($mixOverrideItem)) {
                    foreach ($mixOverrideItem as $strKey=>$mixValue)
Severity: Minor
Found in includes/framework/QBaseClass.class.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method OverrideAttributes has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public final function OverrideAttributes($mixOverrideArray) {
            // Iterate through the OverrideAttribute Array
            if ($mixOverrideArray) foreach ($mixOverrideArray as $mixOverrideItem) {
                if (is_array($mixOverrideItem)) {
                    foreach ($mixOverrideItem as $strKey=>$mixValue)
Severity: Minor
Found in includes/framework/QBaseClass.class.php - About 1 hr to fix

    The method OverrideAttributes() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
    Open

            public final function OverrideAttributes($mixOverrideArray) {
                // Iterate through the OverrideAttribute Array
                if ($mixOverrideArray) foreach ($mixOverrideArray as $mixOverrideItem) {
                    if (is_array($mixOverrideItem)) {
                        foreach ($mixOverrideItem as $strKey=>$mixValue)

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Missing class import via use statement (line '46', column '14').
    Open

                throw new QUndefinedMethodException($objReflection->getName(), $strName);

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '22', column '14').
    Open

                throw new QUndefinedPropertyException("GET", $objReflection->getName(), $strName);

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '39', column '25').
    Open

                $objReflection = new ReflectionClass($this);

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '81', column '17').
    Open

                            throw new QCallerException(sprintf("Improperly formatted OverrideAttribute: %s", $mixOverrideItem));

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '45', column '25').
    Open

                $objReflection = new ReflectionClass($this);

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '40', column '14').
    Open

                throw new QUndefinedPropertyException("SET", $objReflection->getName(), $strName);

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '88', column '18').
    Open

                                throw new QCallerException(sprintf("Improperly formatted OverrideAttribute: %s", $mixOverrideItem));

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '92', column '18').
    Open

                                throw new QCallerException(sprintf("Improperly formatted OverrideAttribute: %s", $mixOverrideItem));

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '21', column '25').
    Open

                $objReflection = new ReflectionClass($this);

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method OverrideAttributes uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                    } else {
                        // Extract the Key and Value for this OverrideAttribute
                        $intPosition = strpos($mixOverrideItem, "=");
                        if ($intPosition === false)
                            throw new QCallerException(sprintf("Improperly formatted OverrideAttribute: %s", $mixOverrideItem));

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($flag) {
                // one branch
            } else {
                // another branch
            }
        }
    }

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method OverrideAttributes is not named in camelCase.
    Open

            public final function OverrideAttributes($mixOverrideArray) {
                // Iterate through the OverrideAttribute Array
                if ($mixOverrideArray) foreach ($mixOverrideArray as $mixOverrideItem) {
                    if (is_array($mixOverrideItem)) {
                        foreach ($mixOverrideItem as $strKey=>$mixValue)

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
        public function get_name() {
        }
    }

    Source

    There are no issues that match your filters.

    Category
    Status