Save accesses the super-global variable $_SESSION. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Save accesses the super-global variable $_SESSION. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Save accesses the super-global variable $_SESSION. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Load accesses the super-global variable $_SESSION. Open
public static function Load($strPostDataState) {
// Pull Out intStateIndex
if (!is_null(QForm::$EncryptionKey)) {
// Use QCryptography to Decrypt
$objCrypto = new QCryptography(QForm::$EncryptionKey, true);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Save accesses the super-global variable $_POST. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Save accesses the super-global variable $_SESSION. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Save accesses the super-global variable $_SESSION. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Save accesses the super-global variable $_SESSION. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Save accesses the super-global variable $_SESSION. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Save accesses the super-global variable $_POST. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Save accesses the super-global variable $_SESSION. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Save accesses the super-global variable $_SESSION. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Save accesses the super-global variable $_SESSION. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Save accesses the super-global variable $_SESSION. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Load accesses the super-global variable $_SESSION. Open
public static function Load($strPostDataState) {
// Pull Out intStateIndex
if (!is_null(QForm::$EncryptionKey)) {
// Use QCryptography to Decrypt
$objCrypto = new QCryptography(QForm::$EncryptionKey, true);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Save accesses the super-global variable $_SESSION. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Function Save
has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method Save
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
The method Save() has an NPath complexity of 304. The configured NPath complexity threshold is 200. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method Save() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Missing class import via use statement (line '37', column '23'). Open
$objCrypto = new QCryptography(QForm::$EncryptionKey, true);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '82', column '22'). Open
$objCrypto = new QCryptography(QForm::$EncryptionKey, true);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '92', column '22'). Open
$objCrypto = new QCryptography(QForm::$EncryptionKey, true);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
The method Save uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$strPriorState = $_POST['Qform__FormState'];
if (!is_null(QForm::$EncryptionKey)) {
// Use QCryptography to Decrypt
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method Save uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
// couldn't find old session variables, so create new one
$strFormInstance = uniqid();
$intFormStateIndex = 1;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method Load uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
return null;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused local variables such as '$val'. Open
foreach ($_SESSION['qformstate'][$a[0]] as $key=>$val) {
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid variables with short names like $a. Configured minimum length is 3. Open
$a = explode ('_', $strPostDataState);
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $a. Configured minimum length is 3. Open
$a = explode ('_', $strPriorState);
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
The method Save is not named in camelCase. Open
public static function Save($strFormState, $blnBackButtonFlag) {
// Compress (if available)
if (function_exists('gzcompress'))
$strFormState = gzcompress($strFormState, 9);
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}
Source
The method Load is not named in camelCase. Open
public static function Load($strPostDataState) {
// Pull Out intStateIndex
if (!is_null(QForm::$EncryptionKey)) {
// Use QCryptography to Decrypt
$objCrypto = new QCryptography(QForm::$EncryptionKey, true);
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}