Sign upLogin

qcubed/framework

View on GitHub
Star
includes/tests/qcubed-unit/ModelConnectorTest.php

Summary

Maintainability
A
1 hr
Test Coverage

Method testReference has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testReference() {
        // test through list control
        $mctProject = ProjectConnector::Create (self::$frmTest, 1);
        $lstControl = $mctProject->ManagerPersonIdControl;
        $this->assertTrue ($lstControl instanceof QListBox);
Severity: Minor
Found in includes/tests/qcubed-unit/ModelConnectorTest.php - About 1 hr to fix

    The class ModelConnectorTests has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13.
    Open

    class ModelConnectorTests extends QUnitTestCaseBase {
    protected static $frmTest;

    /**
     * @beforeClass
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    Missing class import via use statement (line '116', column '20').
    Open

            $mctPerson = new PersonConnector (self::$frmTest, $objPerson);
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '29', column '49').
    Open

            $mctTypeTest->DateTimeControl->DateTime = new QDateTime ('11/11/2011');
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '42', column '42').
    Open

            $this->assertTrue ($dt->IsEqualTo (new QDateTime ('11/11/2011')), 'Date time type saved correctly through connector.');
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '40', column '42').
    Open

            $this->assertTrue ($dt->IsEqualTo (new QDateTime ('10/10/2010', null, QDateTime::DateOnlyType)), 'Date only type saved correctly through connector.');
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '28', column '45').
    Open

            $mctTypeTest->DateControl->DateTime = new QDateTime ('10/10/2010');
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class 'ProjectConnector' in method 'testOverrides'.
    Open

            $mctProject = ProjectConnector::Create (self::$frmTest);
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'TypeTestConnector' in method 'testBasicControls'.
    Open

            $mctTypeTest2 = TypeTestConnector::Create(self::$frmTest, $id);
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'PersonConnector' in method 'testTypeMulti'.
    Open

            $mctPerson = PersonConnector::Create (self::$frmTest, 3);
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'ProjectConnector' in method 'testReference'.
    Open

            $mctProject2 = ProjectConnector::Create (self::$frmTest, 1);
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Project' in method 'testManyToMany'.
    Open

            $a = Project::LoadArrayByPersonAsTeamMember(3);
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'TypeTestConnector' in method 'testBasicControls'.
    Open

            $mctTypeTest = TypeTestConnector::Create(self::$frmTest);
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'QQ' in method 'testManyToMany'.
    Open

            $clauses = array(QQ::ExpandAsArray(QQN::Person()->ProjectAsTeamMember));
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Person' in method 'testManyToMany'.
    Open

            $objPerson = Person::Load (2, $clauses);
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Project' in method 'testManyToMany'.
    Open

            $a = Project::LoadArrayByPersonAsTeamMember(3);
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'AddressConnector' in method 'testReference'.
    Open

            $mctAddress2 = AddressConnector::Create (self::$frmTest, $id);
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'PersonConnector' in method 'testReverseReference'.
    Open

            $mctPerson = PersonConnector::Create (self::$frmTest, 7);
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'AddressConnector' in method 'testOverrides'.
    Open

            $mctAddress = AddressConnector::Create (self::$frmTest);
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'ProjectConnector' in method 'testReference'.
    Open

            $mctProject = ProjectConnector::Create (self::$frmTest, 1);
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'PersonConnector' in method 'testOverrides'.
    Open

            $mctPerson = PersonConnector::Create (self::$frmTest);
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'AddressConnector' in method 'testReference'.
    Open

            $mctAddress = AddressConnector::Create (self::$frmTest);
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'ProjectConnector' in method 'testType1'.
    Open

            $mctProject = ProjectConnector::Create(self::$frmTest,3);
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid variables with short names like $id. Configured minimum length is 3.
    Open

            $id = $mctAddress->SaveAddress();
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $a. Configured minimum length is 3.
    Open

            $a = Project::LoadArrayByPersonAsTeamMember(3);
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $dt. Configured minimum length is 3.
    Open

            $dt = $mctTypeTest2->DateControl->DateTime;
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $id. Configured minimum length is 3.
    Open

            $id = $mctTypeTest->SaveTypeTest();
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    The variable $_FORM is not named in camelCase.
    Open

        public static function setUpClass()
    {
        global $_FORM;
        self::$frmTest = $_FORM;
    }
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $_FORM is not named in camelCase.
    Open

        public static function setUpClass()
    {
        global $_FORM;
        self::$frmTest = $_FORM;
    }
    Severity: Minor
    Found in includes/tests/qcubed-unit/ModelConnectorTest.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status