Sign upLogin

qcubed/framework

View on GitHub
Star
includes/tests/qcubed-unit/QCssTest.php

Summary

Maintainability
F
4 days
Test Coverage

Method testFormatLength has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testFormatLength() {
        $objCaseArray = array( 
            array(
                "Value" => "0", "Expected" => "0", "Msg" => "String zero renders with no 'px'"
            ),
Severity: Major
Found in includes/tests/qcubed-unit/QCssTest.php - About 2 hrs to fix

    Method testJavascriptDataConversions has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function testJavascriptDataConversions() {
        $objCaseArray = array(
            array(
                "Value" => "bob", "Expected" => "bob"
            ),
    Severity: Minor
    Found in includes/tests/qcubed-unit/QCssTest.php - About 1 hr to fix

      Method testSetLength has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function testSetLength() {
        $objCaseArray = array(
            array(
                "OldValue" => "0", "NewValue" => "0", "Changed"=>false, "Expected" => "0", "Msg" => "Zero set to zero."
            ),
      Severity: Minor
      Found in includes/tests/qcubed-unit/QCssTest.php - About 1 hr to fix

        Avoid using static access to class 'JavaScriptHelper' in method 'testJavascriptDataConversions'.
        Open

                    $newValue = JavaScriptHelper::dataNameFromCamelCase($objCase["Value"]);
        Severity: Minor
        Found in includes/tests/qcubed-unit/QCssTest.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class 'QHtml' in method 'helpTest'.
        Open

                $strAttrs = QHtml::FormatLength($strValue);
        Severity: Minor
        Found in includes/tests/qcubed-unit/QCssTest.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class 'QHtml' in method 'helpTest2'.
        Open

                $blnChanged = QHtml::SetLength($strOldValue, $newValue);
        Severity: Minor
        Found in includes/tests/qcubed-unit/QCssTest.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class 'QHtml' in method 'helpTestRemoveClass'.
        Open

                $blnChanged = QHtml::RemoveClass($strOldValue, $newValue);
        Severity: Minor
        Found in includes/tests/qcubed-unit/QCssTest.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class 'JavaScriptHelper' in method 'testJavascriptDataConversions'.
        Open

                    $newValue = JavaScriptHelper::dataNameToCamelCase($objCase["Value"]);
        Severity: Minor
        Found in includes/tests/qcubed-unit/QCssTest.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class 'QHtml' in method 'helpTestAddClass'.
        Open

                $blnChanged = QHtml::AddClass($strOldValue, $newValue);
        Severity: Minor
        Found in includes/tests/qcubed-unit/QCssTest.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                $objCaseArray = array( 
            array(
                "Value" => "0", "Expected" => "0", "Msg" => "String zero renders with no 'px'"
            ),
            array(
        Severity: Major
        Found in includes/tests/qcubed-unit/QCssTest.php and 1 other location - About 2 days to fix
        includes/tests/qcubed-unit/QControlBaseTest.php on lines 44..116

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 461.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function testAddClass() {
        $objCaseArray = array(
            array(
                "OldValue" => "", "NewValue" => "test", "Changed"=>true, "Expected" => "test"
            ),
        Severity: Major
        Found in includes/tests/qcubed-unit/QCssTest.php and 1 other location - About 4 hrs to fix
        includes/tests/qcubed-unit/QCssTest.php on lines 191..213

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 162.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function testRemoveClass() {
        $objCaseArray = array(
            array(
                "OldValue" => "", "NewValue" => "test", "Changed"=>false, "Expected" => ""
            ),
        Severity: Major
        Found in includes/tests/qcubed-unit/QCssTest.php and 1 other location - About 4 hrs to fix
        includes/tests/qcubed-unit/QCssTest.php on lines 157..179

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 162.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status