includes/tests/qcubed-unit/QTestControl.class.php
The method GetWrapperStyleAttributes has a boolean flag argument $blnIsBlockElement, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function GetWrapperStyleAttributes($blnIsBlockElement=false) {- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The method Validate is not named in camelCase. Open
Open
public function Validate() {
return true;
}- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method ParsePostData is not named in camelCase. Open
Open
public function ParsePostData() {
}- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method GetControlHtml is not named in camelCase. Open
Open
protected function GetControlHtml() {
return "";
}- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method GetWrapperStyleAttributes is not named in camelCase. Open
Open
public function GetWrapperStyleAttributes($blnIsBlockElement=false) {
return parent::GetWrapperStyleAttributes($blnIsBlockElement);
}- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}