Sign upLogin

qcubed/framework

View on GitHub
Star
includes/tests/qcubed-unit/QTypeTest.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method testCasting has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testCasting() {
        define('_FAIL_', 'fail');
        $cases = array( 
            //array(value, display, expected result, cast to type),
                array("25.0", "25.0", (float)25.0, QType::Float),
Severity: Major
Found in includes/tests/qcubed-unit/QTypeTest.php - About 2 hrs to fix

    Missing class import via use statement (line '90', column '14').
    Open

            $dt1 = new QDateTime('Jan 15 2006');
    Severity: Minor
    Found in includes/tests/qcubed-unit/QTypeTest.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '91', column '14').
    Open

            $dt2 = new QDateTime('Mar 15 2006');
    Severity: Minor
    Found in includes/tests/qcubed-unit/QTypeTest.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class 'QQ' in method 'testDbTypeCasting'.
    Open

            $cond = QQ::Between(QQN::Project()->StartDate, $dt1, $dt2);
    Severity: Minor
    Found in includes/tests/qcubed-unit/QTypeTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Project' in method 'testDbTypeCasting'.
    Open

            $a = Project::QueryArray($cond);
    Severity: Minor
    Found in includes/tests/qcubed-unit/QTypeTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method testCasting uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                {
                $castValue = QType::Cast($case[0], $case[3]);
                $newValue = $castValue.'('.gettype($castValue).')';
                $this->assertTrue($castValue === $case[2], "$value cast as a ".$case[3]." is $newValue");
            }
    Severity: Minor
    Found in includes/tests/qcubed-unit/QTypeTest.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class 'QQ' in method 'testDbTypeCasting'.
    Open

            $cond = QQ::Between(QQN::Project()->Name, 'A', 'C');
    Severity: Minor
    Found in includes/tests/qcubed-unit/QTypeTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'QQ' in method 'testDbTypeCasting'.
    Open

            $cond = QQ::Between(QQN::Project()->Budget, 2000, 3000);
    Severity: Minor
    Found in includes/tests/qcubed-unit/QTypeTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Project' in method 'testDbTypeCasting'.
    Open

            $a = Project::QueryArray($cond);
    Severity: Minor
    Found in includes/tests/qcubed-unit/QTypeTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'QType' in method 'testCasting'.
    Open

                    QType::Cast($case[0], $case[3]);
    Severity: Minor
    Found in includes/tests/qcubed-unit/QTypeTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'ProjectStatusType' in method 'testTypeTableTypes'.
    Open

    }
    Severity: Minor
    Found in includes/tests/qcubed-unit/QTypeTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Project' in method 'testDbTypeCasting'.
    Open

            $a = Project::QueryArray($cond);
    Severity: Minor
    Found in includes/tests/qcubed-unit/QTypeTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'QType' in method 'testCasting'.
    Open

                    $castValue = QType::Cast($case[0], $case[3]);
    Severity: Minor
    Found in includes/tests/qcubed-unit/QTypeTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'ProjectStatusType' in method 'testTypeTableTypes'.
    Open

    }
    Severity: Minor
    Found in includes/tests/qcubed-unit/QTypeTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid variables with short names like $a. Configured minimum length is 3.
    Open

            $a = Project::QueryArray($cond);
    Severity: Minor
    Found in includes/tests/qcubed-unit/QTypeTest.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status