Sign upLogin

qiniu/ruby-sdk

View on GitHub
Star

Showing 47 of 47 total issues

Method _resumable_put has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def _resumable_put(bucket,
                           uptoken,
                           fh,
                           checksums,
                           progresses,
Severity: Major
Found in lib/qiniu/resumable_upload.rb - About 50 mins to fix

    Method _generate_action_params has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def _generate_action_params(local_file,
                                  bucket,
                                  key = nil,
                                  mime_type = nil,
                                  custom_meta = nil,
    Severity: Major
    Found in lib/qiniu/upload.rb - About 50 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            rescue => e
        Log.logger.warn "#{e.message} => Qiniu::HTTP.get('#{url}')"
        if e.respond_to?(:response) && e.response.respond_to?(:code) then
          return e.response.code, e.response.body, e.response.raw_headers
        end
      Severity: Minor
      Found in lib/qiniu/http.rb and 1 other location - About 45 mins to fix
      lib/qiniu/http.rb on lines 92..98

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            rescue => e
        Log.logger.warn "#{e.message} => Qiniu::HTTP.post('#{url}')"
        if e.respond_to?(:response) && e.response.respond_to?(:code) then
          return e.response.code, e.response.body, e.response.raw_headers
        end
      Severity: Minor
      Found in lib/qiniu/http.rb and 1 other location - About 45 mins to fix
      lib/qiniu/http.rb on lines 38..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method resumable_upload_with_token has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

              def resumable_upload_with_token(uptoken,
                              local_file,
                              bucket,
                              key = nil,
                              mime_type = nil,
      Severity: Minor
      Found in lib/qiniu/resumable_upload.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method _call_binary_with_token has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def _call_binary_with_token(uptoken, url, data, content_type = nil, retry_times = 0)
      Severity: Minor
      Found in lib/qiniu/resumable_upload.rb - About 35 mins to fix

        Method upload_with_token_2 has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def upload_with_token_2(uptoken,
                              local_file,
                              key = nil,
                              x_vars = nil,
                              opts = {})
        Severity: Minor
        Found in lib/qiniu/upload.rb - About 35 mins to fix

          Method _putblock has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  def _putblock(uphost, uptoken, ctx, offset, body)
          Severity: Minor
          Found in lib/qiniu/resumable_upload.rb - About 35 mins to fix

            Method upload_with_put_policy has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                  def upload_with_put_policy(put_policy,
                                 local_file,
                                 key = nil,
                                 x_vars = nil,
                                 opts = {})
            Severity: Minor
            Found in lib/qiniu/upload.rb - About 35 mins to fix

              Method upload_buffer_with_put_policy has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                    def upload_buffer_with_put_policy(put_policy,
                                 buf,
                                 key = nil,
                                 x_vars = nil,
                                 opts = {})
              Severity: Minor
              Found in lib/qiniu/upload.rb - About 35 mins to fix

                Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                      def initialize(fpath, block_index, seek_pos, read_length, result_length)
                Severity: Minor
                Found in lib/qiniu/exceptions.rb - About 35 mins to fix

                  Method _generate_cp_or_mv_opstr has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          def _generate_cp_or_mv_opstr(command, source_bucket, source_key, target_bucket, target_key)
                  Severity: Minor
                  Found in lib/qiniu/management.rb - About 35 mins to fix

                    Method upload_buffer_with_token has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                          def upload_buffer_with_token(uptoken,
                              buf,
                              key = nil,
                              x_vars = nil,
                              opts = {})
                    Severity: Minor
                    Found in lib/qiniu/upload.rb - About 35 mins to fix

                      Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                            def initialize(fpath, block_index, offset, restsize, block_size)
                      Severity: Minor
                      Found in lib/qiniu/exceptions.rb - About 35 mins to fix

                        Method _call_binary_with_token has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                                def _call_binary_with_token(uptoken, url, data, content_type = nil, retry_times = 0)
          options = {
              :headers => {
                  :content_type   => 'application/octet-stream',
                  'Authorization' => 'UpToken ' + uptoken
                        Severity: Minor
                        Found in lib/qiniu/resumable_upload.rb - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method authorize_download_url has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                                def authorize_download_url(url, args = EMPTY_ARGS)
          ### 提取AK/SK信息
          access_key = Config.settings[:access_key]
          secret_key = Config.settings[:secret_key]
                        Severity: Minor
                        Found in lib/qiniu/auth.rb - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method _mkfile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                                def _mkfile(uphost,
                    uptoken,
                    entry_uri,
                    fsize,
                    checksums,
                        Severity: Minor
                        Found in lib/qiniu/resumable_upload.rb - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            def up_host(bucket, opts = {})
      if !multi_region_support?
        "#{extract_protocol(opts)}://up.qiniu.com"
      elsif bucket
        hosts(bucket)[extract_protocol(opts)]['up'][0] rescue "#{extract_protocol(opts)}://up.qiniu.com"
                        Severity: Minor
                        Found in lib/qiniu/host_manager.rb and 1 other location - About 35 mins to fix
                        lib/qiniu/host_manager.rb on lines 24..31

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 34.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            def fetch_host(bucket, opts = {})
      if !multi_region_support?
        "#{extract_protocol(opts)}://iovip.qbox.me"
      elsif bucket
        hosts(bucket)[extract_protocol(opts)]['io'][0] rescue "#{extract_protocol(opts)}://iovip.qbox.me"
                        Severity: Minor
                        Found in lib/qiniu/host_manager.rb and 1 other location - About 35 mins to fix
                        lib/qiniu/host_manager.rb on lines 14..21

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 34.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              def upload_with_put_policy(put_policy,
                                 local_file,
                                 key = nil,
                                 x_vars = nil,
                                 opts = {})
                        Severity: Minor
                        Found in lib/qiniu/upload.rb and 1 other location - About 30 mins to fix
                        lib/qiniu/upload.rb on lines 158..170

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 32.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language