Sign upLogin

qiniu/ruby-sdk

View on GitHub
Star
lib/qiniu/resumable_upload.rb

Summary

Maintainability
D
2 days
Test Coverage

Method _resumable_put_block has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

        def _resumable_put_block(bucket,
                                 uptoken,
                                 fh,
                                 block_index,
                                 block_size,
Severity: Minor
Found in lib/qiniu/resumable_upload.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File resumable_upload.rb has 272 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'zlib'
require 'yaml'
require 'tmpdir'
require 'fileutils'
require 'mime/types'
Severity: Minor
Found in lib/qiniu/resumable_upload.rb - About 2 hrs to fix

    Method _resumable_put_block has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def _resumable_put_block(bucket,
                                 uptoken,
                                 fh,
                                 block_index,
                                 block_size,
    Severity: Major
    Found in lib/qiniu/resumable_upload.rb - About 2 hrs to fix

      Method _resumable_put has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

              def _resumable_put(bucket,
                           uptoken,
                           fh,
                           checksums,
                           progresses,
      Severity: Minor
      Found in lib/qiniu/resumable_upload.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method _resumable_upload has 10 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def _resumable_upload(uptoken,
                              fh,
                              fsize,
                              bucket,
                              key,
      Severity: Major
      Found in lib/qiniu/resumable_upload.rb - About 1 hr to fix

        Method _mkfile has 10 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                def _mkfile(uphost,
                    uptoken,
                    entry_uri,
                    fsize,
                    checksums,
        Severity: Major
        Found in lib/qiniu/resumable_upload.rb - About 1 hr to fix

          Method resumable_upload_with_token has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  def resumable_upload_with_token(uptoken,
                              local_file,
                              bucket,
                              key = nil,
                              mime_type = nil,
          Severity: Major
          Found in lib/qiniu/resumable_upload.rb - About 1 hr to fix

            Method _resumable_put_block has 9 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    def _resumable_put_block(bucket,
                                 uptoken,
                                 fh,
                                 block_index,
                                 block_size,
            Severity: Major
            Found in lib/qiniu/resumable_upload.rb - About 1 hr to fix

              Method _resumable_put has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      def _resumable_put(bucket,
                           uptoken,
                           fh,
                           checksums,
                           progresses,
              Severity: Minor
              Found in lib/qiniu/resumable_upload.rb - About 1 hr to fix

                Method _resumable_put has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        def _resumable_put(bucket,
                           uptoken,
                           fh,
                           checksums,
                           progresses,
                Severity: Major
                Found in lib/qiniu/resumable_upload.rb - About 50 mins to fix

                  Method resumable_upload_with_token has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                          def resumable_upload_with_token(uptoken,
                              local_file,
                              bucket,
                              key = nil,
                              mime_type = nil,
                  Severity: Minor
                  Found in lib/qiniu/resumable_upload.rb - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method _putblock has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          def _putblock(uphost, uptoken, ctx, offset, body)
                  Severity: Minor
                  Found in lib/qiniu/resumable_upload.rb - About 35 mins to fix

                    Method _call_binary_with_token has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            def _call_binary_with_token(uptoken, url, data, content_type = nil, retry_times = 0)
                    Severity: Minor
                    Found in lib/qiniu/resumable_upload.rb - About 35 mins to fix

                      Method _mkfile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                              def _mkfile(uphost,
                    uptoken,
                    entry_uri,
                    fsize,
                    checksums,
                      Severity: Minor
                      Found in lib/qiniu/resumable_upload.rb - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method _call_binary_with_token has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                              def _call_binary_with_token(uptoken, url, data, content_type = nil, retry_times = 0)
          options = {
              :headers => {
                  :content_type   => 'application/octet-stream',
                  'Authorization' => 'UpToken ' + uptoken
                      Severity: Minor
                      Found in lib/qiniu/resumable_upload.rb - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                                          elsif i == retry_times && data["crc32"] != body_crc32
                        Log.logger.error %Q(Uploading block error. Expected crc32: #{body_crc32}, but got: #{data["crc32"]})
                        return code, data, raw_headers
                      Severity: Minor
                      Found in lib/qiniu/resumable_upload.rb and 1 other location - About 20 mins to fix
                      lib/qiniu/resumable_upload.rb on lines 204..206

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 27.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                                          elsif i == retry_times && data["crc32"] != body_crc32
                        Log.logger.error %Q(Uploading block error. Expected crc32: #{body_crc32}, but got: #{data["crc32"]})
                        return code, data, raw_headers
                      Severity: Minor
                      Found in lib/qiniu/resumable_upload.rb and 1 other location - About 20 mins to fix
                      lib/qiniu/resumable_upload.rb on lines 169..171

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 27.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status