Sign upLogin

qiniu/ruby-sdk

View on GitHub
Star
lib/qiniu/upload.rb

Summary

Maintainability
C
1 day
Test Coverage

Method upload_buffer_with_token has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

      def upload_buffer_with_token(uptoken,
                              buf,
                              key = nil,
                              x_vars = nil,
                              opts = {})
Severity: Minor
Found in lib/qiniu/upload.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _generate_action_params has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def _generate_action_params(local_file,
                                  bucket,
                                  key = nil,
                                  mime_type = nil,
                                  custom_meta = nil,
Severity: Minor
Found in lib/qiniu/upload.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method upload_buffer_with_token has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def upload_buffer_with_token(uptoken,
                              buf,
                              key = nil,
                              x_vars = nil,
                              opts = {})
Severity: Minor
Found in lib/qiniu/upload.rb - About 1 hr to fix

    Method upload_with_token has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def upload_with_token(uptoken,
                            local_file,
                            bucket,
                            key = nil,
                            mime_type = nil,
    Severity: Major
    Found in lib/qiniu/upload.rb - About 1 hr to fix

      Method upload_with_token_2 has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def upload_with_token_2(uptoken,
                              local_file,
                              key = nil,
                              x_vars = nil,
                              opts = {})
      Severity: Minor
      Found in lib/qiniu/upload.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method _generate_action_params has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def _generate_action_params(local_file,
                                  bucket,
                                  key = nil,
                                  mime_type = nil,
                                  custom_meta = nil,
      Severity: Major
      Found in lib/qiniu/upload.rb - About 50 mins to fix

        Method upload_with_token_2 has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def upload_with_token_2(uptoken,
                              local_file,
                              key = nil,
                              x_vars = nil,
                              opts = {})
        Severity: Minor
        Found in lib/qiniu/upload.rb - About 35 mins to fix

          Method upload_buffer_with_token has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                def upload_buffer_with_token(uptoken,
                              buf,
                              key = nil,
                              x_vars = nil,
                              opts = {})
          Severity: Minor
          Found in lib/qiniu/upload.rb - About 35 mins to fix

            Method upload_buffer_with_put_policy has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                  def upload_buffer_with_put_policy(put_policy,
                                 buf,
                                 key = nil,
                                 x_vars = nil,
                                 opts = {})
            Severity: Minor
            Found in lib/qiniu/upload.rb - About 35 mins to fix

              Method upload_with_put_policy has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                    def upload_with_put_policy(put_policy,
                                 local_file,
                                 key = nil,
                                 x_vars = nil,
                                 opts = {})
              Severity: Minor
              Found in lib/qiniu/upload.rb - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      def upload_with_put_policy(put_policy,
                                 local_file,
                                 key = nil,
                                 x_vars = nil,
                                 opts = {})
                Severity: Minor
                Found in lib/qiniu/upload.rb and 1 other location - About 30 mins to fix
                lib/qiniu/upload.rb on lines 158..170

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 32.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      def upload_buffer_with_put_policy(put_policy,
                                 buf,
                                 key = nil,
                                 x_vars = nil,
                                 opts = {})
                Severity: Minor
                Found in lib/qiniu/upload.rb and 1 other location - About 30 mins to fix
                lib/qiniu/upload.rb on lines 143..155

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 32.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status