Sign upLogin

qmuntal/opc

View on GitHub
Star

Showing 8 of 8 total issues

Consider simplifying this complex logical expression.
Open

    if c == '!' || c == '$' || c == '&' || c == '\'' || c == '(' || c == ')' ||
        c == '*' || c == '+' || c == ',' || c == ';' || c == '=' {
Severity: Critical
Found in part.go - About 2 hrs to fix

    Function unescape has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
    Open

    func unescape(s string) string {
    n := 0
    for i := 0; i < len(s); {
        if s[i] == '%' {
            if i+2 < len(s) && ishex(s[i+1]) && ishex(s[i+2]) {
    Severity: Minor
    Found in part.go - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function escape has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
    Open

    func escape(s string) string {
    hexCount := 0
    for i := 0; i < len(s); i++ {
        switch s[i] {
        case '%':
    Severity: Minor
    Found in part.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function escape has 52 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func escape(s string) string {
    hexCount := 0
    for i := 0; i < len(s); i++ {
        switch s[i] {
        case '%':
    Severity: Minor
    Found in part.go - About 1 hr to fix

      Function validatePartName has 7 return statements (exceeds 4 allowed).
      Open

      func validatePartName(name string) error {
    if strings.EqualFold(name, contentTypesName) {
        return nil
    }
    if strings.TrimSpace(name) == "" {
      Severity: Major
      Found in part.go - About 45 mins to fix

        Method Writer.Close has 5 return statements (exceeds 4 allowed).
        Open

        func (w *Writer) Close() error {
    if err := w.createLastPartRelationships(); err != nil {
        w.w.Close()
        return err
    }
        Severity: Major
        Found in writer.go - About 35 mins to fix

          Function decodeContentTypes has 5 return statements (exceeds 4 allowed).
          Open

          func decodeContentTypes(r io.Reader) (*contentTypes, error) {
    ctdecode := new(contentTypesXMLReader)
    if err := xml.NewDecoder(r).Decode(ctdecode); err != nil {
        return nil, fmt.Errorf("opc: %s: cannot be decoded: %v", contentTypesName, err)
    }
          Severity: Major
          Found in reader.go - About 35 mins to fix

            Method Reader.loadPackage has 5 return statements (exceeds 4 allowed).
            Open

            func (r *Reader) loadPackage() error {
    ct, rels, err := r.loadPartProperties()
    if err != nil {
        return err
    }
            Severity: Major
            Found in reader.go - About 35 mins to fix
              Severity
              Category
              Status
              Source
              Language