Sign upLogin

qor/qor

View on GitHub
Star
utils/params.go

Summary

Maintainability
B
6 hrs
Test Coverage

Function ParamsMatch has a Cognitive Complexity of 36 (exceeds 20 allowed). Consider refactoring.
Open

func ParamsMatch(source string, pth string) (url.Values, string, bool) {
    var (
        i, j int
        p    = make(url.Values)
        ext  = path.Ext(pth)
Severity: Minor
Found in utils/params.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ParamsMatch has 55 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func ParamsMatch(source string, pth string) (url.Values, string, bool) {
    var (
        i, j int
        p    = make(url.Values)
        ext  = path.Ext(pth)
Severity: Minor
Found in utils/params.go - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                        if reg, err := regexp.Compile("^" + match + "$"); err == nil && reg.MatchString(val) {
                        j = j + index + 1
                    } else {
                        return nil, "", false
                    }
    Severity: Major
    Found in utils/params.go - About 45 mins to fix

      Function ParamsMatch has 7 return statements (exceeds 4 allowed).
      Open

      func ParamsMatch(source string, pth string) (url.Values, string, bool) {
    var (
        i, j int
        p    = make(url.Values)
        ext  = path.Ext(pth)
      Severity: Major
      Found in utils/params.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                        } else if source[len(source)-1] == ']' {
                    index = len(source) - j - 1
                }
        Severity: Major
        Found in utils/params.go - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status