Sign upLogin

quorrajs/NodeSession

View on GitHub
Star

Showing 11 of 11 total issues

Function __setCookie has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

NodeSession.prototype.__setCookie = function (request, response, name, val, options) {
    options = _.merge({}, options);

    // only send secure cookies via https
    if (!(options.secure && !this.__isSecure(request))) {
Severity: Minor
Found in index.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Store.prototype.regenerate = function (destroy) {
    if (destroy) {
        this.__handler.destroy(this.getId());
    }
Severity: Major
Found in lib/store/Store.js and 1 other location - About 1 hr to fix
lib/store/Store.js on lines 450..459

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Store.prototype.migrate = function (destroy) {
    if (destroy) {
        this.__handler.destroy(this.getId());
    }
Severity: Major
Found in lib/store/Store.js and 1 other location - About 1 hr to fix
lib/store/Store.js on lines 336..346

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function __createSessionModel has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

SessionManager.prototype.__createSessionModel = function (callback) {
    var self = this;
    var adapters = {};
    var orm = new Waterline();
    var SessionModel = Waterline.Collection.extend({
Severity: Minor
Found in lib/SessionManager.js - About 1 hr to fix

    Function __getCookie has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    NodeSession.prototype.__getCookie = function (request, name) {
    // if signed cookie is already present in request(means cookie
    // parsing is already done), we will use it straight.
    if (request.signedCookies) {
        return request.signedCookies[name];
    Severity: Minor
    Found in index.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function write has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    DatabaseSessionHandler.prototype.write = function (sessionId, data, callback) {
    var self = this;
    if (this.__exists) {
        this.__model.update(sessionId,
            {payload: JSON.stringify(data), lastActivity: (new Date()).getTime()},
    Severity: Minor
    Found in lib/handler/DatabaseSessionHandler.js - About 1 hr to fix

      Function __setCookie has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      NodeSession.prototype.__setCookie = function (request, response, name, val, options) {
    options = _.merge({}, options);

    // only send secure cookies via https
    if (!(options.secure && !this.__isSecure(request))) {
      Severity: Minor
      Found in index.js - About 1 hr to fix

        Function __setCookie has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        NodeSession.prototype.__setCookie = function (request, response, name, val, options) {
        Severity: Minor
        Found in index.js - About 35 mins to fix

          Function EncryptedStore has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function EncryptedStore(name, handler, encrypter, secret, id) {
          Severity: Minor
          Found in lib/store/EncryptedStore.js - About 35 mins to fix

            Function __isSecure has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            NodeSession.prototype.__isSecure = function (request) {
    var proto;

    // socket is https server
    if (request.connection && request.connection.encrypted) {
            Severity: Minor
            Found in index.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function __readFromHandler has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            Store.prototype.__readFromHandler = function (callback) {
    var self = this;

    this.__handler.read(this.getId(), function afterRead(data) {
        if (data) {
            Severity: Minor
            Found in lib/store/Store.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language