Sign upLogin

quran/quran.com-frontend

View on GitHub
Star

Showing 176 of 176 total issues

Function renderSingleAyah has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  renderSingleAyah() {
    const { repeat, setRepeat, chapter } = this.props;
    const array = Array(chapter.versesCount).join().split(',');

    return (
Severity: Minor
Found in src/components/Audioplayer/RepeatDropdown/index.js - About 1 hr to fix

    Function handleItemKeyDown has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      handleItemKeyDown(event, item) {
    const items = this.menu.getElementsByTagName('li');

    if (!items.length) {
      return;
    Severity: Minor
    Found in src/components/SearchAutocomplete/index.js - About 1 hr to fix

      Function elements has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const elements = keys.map((lineNum, index) => {
    const nextNum = keys[index + 1];
    const pageNum = lineNum.split('-')[0];
    const line = lines[lineNum];
    const renderText = false; // userAgent.isBot;
      Severity: Minor
      Found in src/components/PageView/index.js - About 1 hr to fix

        Function mapStateToProps has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function mapStateToProps(state, ownProps) {
  const chapterId = parseInt(ownProps.params.chapterId, 10);
  const chapter: Object = state.chapters.entities[chapterId];
  const verses: Object = state.verses.entities[chapterId];
  const verseArray = verses
        Severity: Minor
        Found in src/containers/Pdf/index.js - About 1 hr to fix

          Function SurahsList has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const SurahsList = (props) => {
  debug('component:Index', 'SurahsList');

  return (
    <ul className="col-md-4 list-unstyled">
          Severity: Minor
          Found in src/components/Home/SurahsList/index.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      <FormControl
            componentClass="select"
            value={repeat.times}
            onChange={event =>
              setRepeat({
            Severity: Major
            Found in src/components/Audioplayer/RepeatDropdown/index.js and 1 other location - About 1 hr to fix
            src/components/Audioplayer/RepeatDropdown/index.js on lines 97..115

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        <FormControl
              componentClass="select"
              value={repeat.to}
              onChange={event =>
                setRepeat({ ...repeat, to: parseInt(event.target.value, 10) })}
            Severity: Major
            Found in src/components/Audioplayer/RepeatDropdown/index.js and 1 other location - About 1 hr to fix
            src/components/Audioplayer/RepeatDropdown/index.js on lines 211..231

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            export const translationType = PropTypes.shape({
  languageName: PropTypes.string.isRequired,
  text: PropTypes.string.isRequired,
  resourceName: PropTypes.string.isRequired
});
            Severity: Major
            Found in src/customPropTypes.js and 1 other location - About 1 hr to fix
            src/customPropTypes.js on lines 189..193

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            export const words = PropTypes.shape({
  startTime: PropTypes.number.isRequired,
  endTime: PropTypes.number.isRequired,
  duration: PropTypes.number.isRequired,
});
            Severity: Major
            Found in src/customPropTypes.js and 1 other location - About 1 hr to fix
            src/customPropTypes.js on lines 127..131

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function render has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              render() {
    const { chapter, options } = this.props; // eslint-disable-line no-shadow
    debug('component:Surah', 'Render');

    if (!this.hasVerses()) {
            Severity: Minor
            Found in src/containers/Pdf/index.js - About 1 hr to fix

              Function render has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                render() {
    const { translations, translationOptions } = this.props;

    return (
      <MenuItem
              Severity: Minor
              Found in src/components/ContentDropdown/index.js - About 1 hr to fix

                Function renderText has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  renderText() {
    const {
      tooltip,
      currentVerse,
      audioActions,
                Severity: Minor
                Found in src/components/Line/index.js - About 1 hr to fix

                  Function render has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                    render() {
    const { tooltip, word, currentVerse, isPlaying, audioPosition, useTextFont } = this.props;

    let text;
    let spacer;
                  Severity: Minor
                  Found in src/components/Word/index.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function filterValidVerse has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function filterValidVerse(replaceState, chapterId, verseRange) {
  const chapterToVersesMap = {
    1: 7,
    2: 286,
    3: 200,
                  Severity: Minor
                  Found in src/utils/routeFilters.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function clientMiddleware has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  export default function clientMiddleware(client) {
  return ({ dispatch, getState }) => next => (action) => {
    if (typeof action === 'function') {
      return action(dispatch, getState);
    }
                  Severity: Minor
                  Found in src/redux/middleware/clientMiddleware.js - About 1 hr to fix

                    Function render has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      render() {
    let body;

    if (this.state.success) {
      body = this.renderSubmitSuccess();
                    Severity: Minor
                    Found in src/containers/Contact/index.js - About 1 hr to fix

                      Function reducer has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      export default function reducer(state = {}, action = {}) {
  switch (action.type) {
    case LOAD_SUCCESS:
    case SEARCH_SUCCESS: {
      const verses = action.result.entities.verses;
                      Severity: Minor
                      Found in src/redux/modules/fontFaces.js - About 1 hr to fix

                        Function render has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          render() {
    const { segments, currentVerse, currentTime } = this.props;
    const style = [];
    let currentWord = null;
                        Severity: Minor
                        Found in src/components/Audioplayer/Segments/index.js - About 1 hr to fix

                          Similar blocks of code found in 3 locations. Consider refactoring.
                          Open

                              if (isErrored) {
      return (
        <h3 className="text-center" style={{ padding: '15%' }}>
          <LocaleFormattedMessage id="search.error" defaultMessage="Sorry, there was an error with your search." />
        </h3>
                          Severity: Major
                          Found in src/containers/Search/index.js and 2 other locations - About 55 mins to fix
                          src/containers/Search/index.js on lines 99..105
                          src/containers/Search/index.js on lines 119..125

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 54.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 3 locations. Consider refactoring.
                          Open

                              if (!query || !query.q) {
      return (
        <h3 className="text-center" style={{ padding: '15%' }}>
          <LocaleFormattedMessage id="search.nothing" defaultMessage="No search query." />
        </h3>
                          Severity: Major
                          Found in src/containers/Search/index.js and 2 other locations - About 55 mins to fix
                          src/containers/Search/index.js on lines 107..113
                          src/containers/Search/index.js on lines 119..125

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 54.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language