Sign upLogin

qutip/qutip

View on GitHub
Star
qutip/solver/correlation.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function correlation_3op_2t has 11 arguments (exceeds 10 allowed). Consider refactoring.
Open

def correlation_3op_2t(H, state0, tlist, taulist, c_ops, a_op, b_op, c_op,
Severity: Major
Found in qutip/solver/correlation.py - About 35 mins to fix

    Function correlation_2op_2t has 11 arguments (exceeds 10 allowed). Consider refactoring.
    Open

    def correlation_2op_2t(H, state0, tlist, taulist, c_ops, a_op, b_op,
    Severity: Major
    Found in qutip/solver/correlation.py - About 35 mins to fix

      TODO found
      Open

              # TODO: Solver could have a ``with`` or ``copy``.
      Severity: Minor
      Found in qutip/solver/correlation.py by fixme

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if state0 is None:
        state0 = steadystate(H, c_ops)
        n = np.array([expect(state0, a_op.dag() * a_op)])
    else:
        n = solver.run(state0, taulist, e_ops=[a_op.dag() * a_op]).expect[0]
      Severity: Major
      Found in qutip/solver/correlation.py and 1 other location - About 2 hrs to fix
      qutip/solver/correlation.py on lines 410..414

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 85.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if state0 is None:
        state0 = steadystate(H, c_ops)
        n = np.array([expect(state0, a_op.dag() * a_op)])
    else:
        n = solver.run(state0, taulist, e_ops=[a_op.dag() * a_op]).expect[0]
      Severity: Major
      Found in qutip/solver/correlation.py and 1 other location - About 2 hrs to fix
      qutip/solver/correlation.py on lines 347..351

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 85.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Line too long (81 > 79 characters)
      Open

          G1 = correlation_3op(solver, state0, [0], taulist, None, a_op.dag(), a_op)[0]
      Severity: Minor
      Found in qutip/solver/correlation.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      There are no issues that match your filters.

      Category
      Status