Sign upLogin

quyse/flaw

View on GitHub
Star
flaw-visual/Flaw/Visual/Pipeline/Deferred.hs

Summary

Maintainability
Test Coverage

Reduce duplication
Open

    albedo = xyz__ albedoOcclusion
Severity: Minor
Found in flaw-visual/Flaw/Visual/Pipeline/Deferred.hs by hlint

Found

albedo = xyz__ albedoOcclusion
diffuse = x_ material
specular = y_ material
metalness = zzz__ material
glossiness = w_ material

Perhaps

Combine with flaw-visual/Flaw/Visual/Pipeline/Deferred.hs:226:5

Reduce duplication
Open

  (albedoOcclusion, material, viewNormal, depth) <- deferredPipelineLightPassInput $ zw__ screenPositionTexcoord
Severity: Minor
Found in flaw-visual/Flaw/Visual/Pipeline/Deferred.hs by hlint

Found

(albedoOcclusion, material, viewNormal,
 depth) <- deferredPipelineLightPassInput $
             zw__ screenPositionTexcoord
let albedo = xyz__ albedoOcclusion
    diffuse = x_ material
    specular = y_ material
    metalness = zzz__ material
    glossiness = w_ material
viewPositionH <- temp $
                   invProj `mul` cvec211 (xy__ screenPositionTexcoord) depth 1
viewPosition <- temp $ xyz__ viewPositionH / www__ viewPositionH

Perhaps

Combine with flaw-visual/Flaw/Visual/Pipeline/Deferred.hs:224:3

There are no issues that match your filters.

Category
Status