Sign upLogin

r4fek/django-cassandra-engine

View on GitHub
Star
django_cassandra_engine/models/django_model_methods.py

Summary

Maintainability
D
1 day
Test Coverage

Function _get_unique_checks has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

def _get_unique_checks(self, exclude=None):
    # Taken from django.db.models.base
    if exclude is None:
        exclude = []
    unique_checks = []
Severity: Minor
Found in django_cassandra_engine/models/django_model_methods.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _perform_unique_checks has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

def _perform_unique_checks(self, unique_checks):
    # Taken from django.db.models.base
    errors = {}

    for model_class, unique_check in unique_checks:
Severity: Minor
Found in django_cassandra_engine/models/django_model_methods.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function full_clean has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def full_clean(self, exclude=None, validate_unique=True):
    # Taken from django.db.models.base
    errors = {}
    if exclude is None:
        exclude = []
Severity: Minor
Found in django_cassandra_engine/models/django_model_methods.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _perform_date_checks has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def _perform_date_checks(self, date_checks):
    # Taken from django.db.models.base
    errors = {}
    for model_class, lookup_type, field, unique_for in date_checks:
        lookup_kwargs = {}
Severity: Minor
Found in django_cassandra_engine/models/django_model_methods.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function clean_fields has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def clean_fields(self, exclude=None):
    # Taken from django.db.models.base
    if exclude is None:
        exclude = []
Severity: Minor
Found in django_cassandra_engine/models/django_model_methods.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            if f.unique_for_date and f.unique_for_date not in exclude:
                date_checks.append((model_class, "date", name, f.unique_for_date))
Severity: Major
Found in django_cassandra_engine/models/django_model_methods.py and 2 other locations - About 45 mins to fix
django_cassandra_engine/models/django_model_methods.py on lines 103..104
django_cassandra_engine/models/django_model_methods.py on lines 105..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            if f.unique_for_month and f.unique_for_month not in exclude:
                date_checks.append((model_class, "month", name, f.unique_for_month))
Severity: Major
Found in django_cassandra_engine/models/django_model_methods.py and 2 other locations - About 45 mins to fix
django_cassandra_engine/models/django_model_methods.py on lines 101..102
django_cassandra_engine/models/django_model_methods.py on lines 103..104

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            if f.unique_for_year and f.unique_for_year not in exclude:
                date_checks.append((model_class, "year", name, f.unique_for_year))
Severity: Major
Found in django_cassandra_engine/models/django_model_methods.py and 2 other locations - About 45 mins to fix
django_cassandra_engine/models/django_model_methods.py on lines 101..102
django_cassandra_engine/models/django_model_methods.py on lines 105..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status