Sign upLogin

r4fterman/pdf.forms

View on GitHub
Star
src/main/java/org/pdf/forms/gui/commands/CommandListener.java

Summary

Maintainability
A
1 hr
Test Coverage
F
21%

Method getId has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    private int getId(final Object source) {
        logger.info("Action event: {}", source.getClass().getCanonicalName());
        if (source instanceof ButtonWithID) {
            return ((ButtonWithID) source).getId();
        }
Severity: Minor
Found in src/main/java/org/pdf/forms/gui/commands/CommandListener.java - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return Commands.NONE;
Severity: Major
Found in src/main/java/org/pdf/forms/gui/commands/CommandListener.java - About 30 mins to fix

    Extra separation in import group before 'org.pdf.forms.gui.components.ButtonWithID'
    Open

    import org.pdf.forms.gui.components.ButtonWithID;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/commands/CommandListener.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    There are no issues that match your filters.

    Category
    Status