Sign upLogin

r4fterman/pdf.forms

View on GitHub
Star
src/main/java/org/pdf/forms/gui/commands/PDFImportWorker.java

Summary

Maintainability
B
5 hrs
Test Coverage
F
0%

Method decodePDFPage has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

            final String pdfPath,
            final PdfDecoder pdfDecoder,
            final ProgressMonitor progressDialog,
            final int pdfPageNumber,
            final Page newPage,
Severity: Minor
Found in src/main/java/org/pdf/forms/gui/commands/PDFImportWorker.java - About 45 mins to fix

    Method decodePDFPage has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

                final PdfDecoder pdfDecoder,
            final String pdfPath,
            final int pdfPageNumber,
            final Page newPage,
            final List<IWidget> widgetsOnPage) {
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/commands/PDFImportWorker.java - About 35 mins to fix

      Provide the parametrized type for this generic.
      Open

      class PDFImportWorker extends SwingWorker {
      Severity: Major
      Found in src/main/java/org/pdf/forms/gui/commands/PDFImportWorker.java by sonar-java

      Generic types shouldn't be used raw (without type parameters) in variable declarations or return values. Doing so bypasses generic type checking, and defers the catch of unsafe code to runtime.

      Noncompliant Code Example

      List myList; // Noncompliant
Set mySet; // Noncompliant

      Compliant Solution

      List<String> myList;
Set<? extends Number> mySet;

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              for (int pdfPageNumber = 1; pdfPageNumber < pageCount + 1; pdfPageNumber++) {
            currentLastPage++;

            final Page newPage = new Page("(page " + currentLastPage + ")", pdfPath, pdfPageNumber);
      Severity: Major
      Found in src/main/java/org/pdf/forms/gui/commands/PDFImportWorker.java and 1 other location - About 1 hr to fix
      src/main/java/org/pdf/forms/gui/commands/PDFImportWorker.java on lines 134..156

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 110.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              for (int pdfPageNumber = 1; pdfPageNumber < pageCount + 1; pdfPageNumber++) {
            currentLastPage++;

            final Page newPage = new Page("(page " + currentLastPage + ")", pdfPath, pdfPageNumber);
      Severity: Major
      Found in src/main/java/org/pdf/forms/gui/commands/PDFImportWorker.java and 1 other location - About 1 hr to fix
      src/main/java/org/pdf/forms/gui/commands/PDFImportWorker.java on lines 100..122

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 110.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private PdfDecoder getDecoder(final String pdfPath) throws PdfException {
        final PdfDecoder decoder = new PdfDecoder();
        if (pdfPath.startsWith("http:") || pdfPath.startsWith("file:")) {
            decoder.openPdfFileFromURL(pdfPath);
        } else {
      Severity: Minor
      Found in src/main/java/org/pdf/forms/gui/commands/PDFImportWorker.java and 1 other location - About 40 mins to fix
      src/main/java/org/pdf/forms/gui/commands/ImportPdfCommand.java on lines 107..115

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Abbreviation in name 'decodePDFPage' must contain no more than '2' consecutive capital letters.
      Open

          private void decodePDFPage(
      Severity: Minor
      Found in src/main/java/org/pdf/forms/gui/commands/PDFImportWorker.java by checkstyle

      Validates abbreviations (consecutive capital letters) length in identifier name,it also allows to enforce camel case naming. Please read more atGoogle Style Guideto get to know how to avoid long abbreviations in names.

      allowedAbbreviationLength specifies how many consecutive capital letters areallowed in the identifier.A value of 3 indicates that up to 4 consecutive capital letters are allowed,one after the other, before a violation is printed. The identifier 'MyTEST' would beallowed, but 'MyTESTS' would not be.A value of 0 indicates that only 1 consecutive capital letter is allowed. Thisis what should be used to enforce strict camel casing. The identifier 'MyTest' wouldbe allowed, but 'MyTEst' would not be.

      ignoreFinal, ignoreStatic, and ignoreStaticFinalcontrol whether variables with the respective modifiers are to be ignored.Note that a variable that is both static and final will always be considered underignoreStaticFinal only, regardless of the values of ignoreFinaland ignoreStatic. So for example if ignoreStatic is true butignoreStaticFinal is false, then static final variables will not be ignored.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Using the '.*' form of import should be avoided - javax.swing.*.
      Open

      import javax.swing.*;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/gui/commands/PDFImportWorker.java by checkstyle

      Checks that there are no import statements that use the * notation.

      Rationale: Importing all classes from a package or staticmembers from a class leads to tight coupling between packagesor classes and might lead to problems when a new version of alibrary introduces name clashes.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Abbreviation in name 'decodePDFPage' must contain no more than '2' consecutive capital letters.
      Open

          private boolean decodePDFPage(
      Severity: Minor
      Found in src/main/java/org/pdf/forms/gui/commands/PDFImportWorker.java by checkstyle

      Validates abbreviations (consecutive capital letters) length in identifier name,it also allows to enforce camel case naming. Please read more atGoogle Style Guideto get to know how to avoid long abbreviations in names.

      allowedAbbreviationLength specifies how many consecutive capital letters areallowed in the identifier.A value of 3 indicates that up to 4 consecutive capital letters are allowed,one after the other, before a violation is printed. The identifier 'MyTEST' would beallowed, but 'MyTESTS' would not be.A value of 0 indicates that only 1 consecutive capital letter is allowed. Thisis what should be used to enforce strict camel casing. The identifier 'MyTest' wouldbe allowed, but 'MyTEst' would not be.

      ignoreFinal, ignoreStatic, and ignoreStaticFinalcontrol whether variables with the respective modifiers are to be ignored.Note that a variable that is both static and final will always be considered underignoreStaticFinal only, regardless of the values of ignoreFinaland ignoreStatic. So for example if ignoreStatic is true butignoreStaticFinal is false, then static final variables will not be ignored.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Using the '.*' form of import should be avoided - java.awt.*.
      Open

      import java.awt.*;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/gui/commands/PDFImportWorker.java by checkstyle

      Checks that there are no import statements that use the * notation.

      Rationale: Importing all classes from a package or staticmembers from a class leads to tight coupling between packagesor classes and might lead to problems when a new version of alibrary introduces name clashes.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 105).
      Open

              progressDialog.setNote("Importing page " + pdfPageNumber + " of " + progressDialog.getMaximum());
      Severity: Minor
      Found in src/main/java/org/pdf/forms/gui/commands/PDFImportWorker.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Abbreviation in name 'PDFImportWorker' must contain no more than '2' consecutive capital letters.
      Open

      class PDFImportWorker extends SwingWorker {
      Severity: Minor
      Found in src/main/java/org/pdf/forms/gui/commands/PDFImportWorker.java by checkstyle

      Validates abbreviations (consecutive capital letters) length in identifier name,it also allows to enforce camel case naming. Please read more atGoogle Style Guideto get to know how to avoid long abbreviations in names.

      allowedAbbreviationLength specifies how many consecutive capital letters areallowed in the identifier.A value of 3 indicates that up to 4 consecutive capital letters are allowed,one after the other, before a violation is printed. The identifier 'MyTEST' would beallowed, but 'MyTESTS' would not be.A value of 0 indicates that only 1 consecutive capital letter is allowed. Thisis what should be used to enforce strict camel casing. The identifier 'MyTest' wouldbe allowed, but 'MyTEst' would not be.

      ignoreFinal, ignoreStatic, and ignoreStaticFinalcontrol whether variables with the respective modifiers are to be ignored.Note that a variable that is both static and final will always be considered underignoreStaticFinal only, regardless of the values of ignoreFinaland ignoreStatic. So for example if ignoreStatic is true butignoreStaticFinal is false, then static final variables will not be ignored.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 112).
      Open

              final ProgressMonitor progressDialog = new ProgressMonitor((Component) mainFrame, "", "", 0, pageCount);
      Severity: Minor
      Found in src/main/java/org/pdf/forms/gui/commands/PDFImportWorker.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Extra separation in import group before 'javax.swing.*'
      Open

      import javax.swing.*;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/gui/commands/PDFImportWorker.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Extra separation in import group before 'org.jpedal.PdfDecoder'
      Open

      import org.jpedal.PdfDecoder;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/gui/commands/PDFImportWorker.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      There are no issues that match your filters.

      Category
      Status