Sign upLogin

r4fterman/pdf.forms

View on GitHub
Star
src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java

Summary

Maintainability
A
2 hrs
Test Coverage
F
47%

Method initComponents has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void initComponents() {
        final JLabel locationLabel = new JLabel("Location:");

        imageLocationBox = new JTextField();
        imageLocationBox.addFocusListener(new FocusAdapter() {
Severity: Major
Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java - About 2 hrs to fix

    Define a constant instead of duplicating this literal "mixed" 3 times.
    Open

            if (location != null && !location.equals("mixed")) {
    Severity: Critical
    Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java by sonar-java

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

    Compliant Solution

    private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Wrong lexicographical order for 'java.awt.event.ActionListener' import. Should be before 'java.util.stream.Collectors.toUnmodifiableList'.
    Open

    import java.awt.event.ActionListener;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'java.io.File' import. Should be before 'java.util.stream.Collectors.toUnmodifiableList'.
    Open

    import java.io.File;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Line is longer than 100 characters (found 102).
    Open

                                            .add(sizingBox, 0, GroupLayout.DEFAULT_SIZE, Short.MAX_VALUE))
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java by checkstyle

    Checks for long lines.

    Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'java.awt.event.ActionEvent' import. Should be before 'java.util.stream.Collectors.toUnmodifiableList'.
    Open

    import java.awt.event.ActionEvent;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Extra separation in import group before 'java.awt.event.ActionEvent'
    Open

    import java.awt.event.ActionEvent;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Extra separation in import group before 'javax.swing.*'
    Open

    import javax.swing.*;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Line is longer than 100 characters (found 104).
    Open

                    .map(widget -> widget.getWidgetModel().getProperties().getObject().getDraw().getSizing()
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java by checkstyle

    Checks for long lines.

    Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'java.awt.event.FocusEvent' import. Should be before 'java.util.stream.Collectors.toUnmodifiableList'.
    Open

    import java.awt.event.FocusEvent;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Using the '.*' form of import should be avoided - javax.swing.*.
    Open

    import javax.swing.*;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java by checkstyle

    Checks that there are no import statements that use the * notation.

    Rationale: Importing all classes from a package or staticmembers from a class leads to tight coupling between packagesor classes and might lead to problems when a new version of alibrary introduces name clashes.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'java.awt.event.FocusAdapter' import. Should be before 'java.util.stream.Collectors.toUnmodifiableList'.
    Open

    import java.awt.event.FocusAdapter;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Line is longer than 100 characters (found 106).
    Open

                    .map(widget -> widget.getWidgetModel().getProperties().getObject().getDraw().getLocation()
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java by checkstyle

    Checks for long lines.

    Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Line is longer than 100 characters (found 119).
    Open

                widgets.forEach(widget -> widget.getWidgetModel().getProperties().getObject().getDraw().setSizing(sizing));
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java by checkstyle

    Checks for long lines.

    Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'java.util.Collections' import. Should be before 'java.util.stream.Collectors.toUnmodifiableList'.
    Open

    import java.util.Collections;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'java.util.Set' import. Should be before 'java.util.stream.Collectors.toUnmodifiableList'.
    Open

    import java.util.Set;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Extra separation in import group before 'org.jdesktop.layout.GroupLayout'
    Open

    import org.jdesktop.layout.GroupLayout;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'java.util.Arrays' import. Should be before 'java.util.stream.Collectors.toUnmodifiableList'.
    Open

    import java.util.Arrays;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'java.util.List' import. Should be before 'java.util.stream.Collectors.toUnmodifiableList'.
    Open

    import java.util.List;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/properties/object/draw/ImageDrawPanel.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    There are no issues that match your filters.

    Category
    Status