Sign upLogin

r4fterman/pdf.forms

View on GitHub
Star
src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java

Summary

Maintainability
C
1 day
Test Coverage
F
0%

Method initComponents has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void initComponents() {
        final JLabel label = new JLabel("Radio Button Groups");

        buttonGroupsList = new JList<>();
        buttonGroupsList.setModel(new DefaultListModel<>());
Severity: Minor
Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        private Optional<String> askForNewButtonGroupName() {
        final String newName = JOptionPane.showInputDialog(parentDialog,
                "Enter new name",
                "Rename",
                JOptionPane.QUESTION_MESSAGE);
    Severity: Major
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java and 1 other location - About 1 hr to fix
    src/main/java/org/pdf/forms/gui/windows/CheckBoxButtonGroupOrganiser.java on lines 116..133

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        private String createNonExistingButtonGroupName(final String buttonGroupName) {
        for (final ButtonGroup buttonGroup: radioButtonGroups) {
            if (buttonGroup.getName().equals(buttonGroupName)) {
                final char c = buttonGroupName.charAt(buttonGroupName.length() - 1);
                final int number = Integer.parseInt(String.valueOf(c));
    Severity: Major
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java and 1 other location - About 1 hr to fix
    src/main/java/org/pdf/forms/gui/windows/CheckBoxButtonGroupOrganiser.java on lines 197..206

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 86.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            final GroupLayout.ParallelGroup parallelGroup1 = layout.createParallelGroup(LEADING, false)
                .add(TRAILING, okButton, DEFAULT_SIZE, DEFAULT_SIZE, Short.MAX_VALUE)
                .add(renameButton, DEFAULT_SIZE, DEFAULT_SIZE, Short.MAX_VALUE)
                .add(removeButton, DEFAULT_SIZE, DEFAULT_SIZE, Short.MAX_VALUE)
                .add(addButton, DEFAULT_SIZE, DEFAULT_SIZE, Short.MAX_VALUE);
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java and 1 other location - About 55 mins to fix
    src/main/java/org/pdf/forms/gui/windows/CheckBoxButtonGroupOrganiser.java on lines 66..70

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 64.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        private void removeClicked(final ActionEvent event) {
        final String selectedItem = buttonGroupsList.getSelectedValue();
        if (selectedItem == null) {
            return;
        }
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java and 1 other location - About 50 mins to fix
    src/main/java/org/pdf/forms/gui/windows/CheckBoxButtonGroupOrganiser.java on lines 143..157

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        private void renameClicked(final ActionEvent event) {
        final String selectedItem = buttonGroupsList.getSelectedValue();
        if (selectedItem == null) {
            return;
        }
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java and 1 other location - About 40 mins to fix
    src/main/java/org/pdf/forms/gui/windows/CheckBoxButtonGroupOrganiser.java on lines 103..114

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public RadioButtonGroupOrganiser(
            final JDialog parentDialog,
            final List<ButtonGroup> radioButtonGroups,
            final List<IWidget> widgetsOnPage) {
        this.parentDialog = parentDialog;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java and 1 other location - About 35 mins to fix
    src/main/java/org/pdf/forms/gui/windows/CheckBoxButtonGroupOrganiser.java on lines 27..38

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            final GroupLayout.SequentialGroup sequentialGroup2 = layout.createSequentialGroup()
                .add(addButton)
                .addPreferredGap(RELATED)
                .add(removeButton)
                .addPreferredGap(RELATED)
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java and 1 other location - About 35 mins to fix
    src/main/java/org/pdf/forms/gui/windows/CheckBoxButtonGroupOrganiser.java on lines 78..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 44.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        private void addClicked(final ActionEvent evt) {
        final ButtonGroup newButtonGroup = new ButtonGroup(IWidget.RADIO_BUTTON);
        newButtonGroup.setName(createNonExistingButtonGroupName(newButtonGroup.getName()));
        radioButtonGroups.add(newButtonGroup);
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java and 1 other location - About 30 mins to fix
    src/main/java/org/pdf/forms/gui/windows/CheckBoxButtonGroupOrganiser.java on lines 189..195

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Line is longer than 100 characters (found 115).
    Open

            final GroupLayout.ParallelGroup parallelGroup2 = layout.createParallelGroup(LEADING).add(sequentialGroup1);
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java by checkstyle

    Checks for long lines.

    Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'java.awt.event.ActionEvent' import. Should be before 'org.jdesktop.layout.LayoutStyle.RELATED'.
    Open

    import java.awt.event.ActionEvent;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Line is longer than 100 characters (found 101).
    Open

                        widget.getWidgetModel().getProperties().getObject().getValue().setDefault("Off");
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java by checkstyle

    Checks for long lines.

    Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'java.util.List' import. Should be before 'org.jdesktop.layout.LayoutStyle.RELATED'.
    Open

    import java.util.List;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Line is longer than 100 characters (found 102).
    Open

                    return buttonGroupName.replaceAll(String.valueOf(number), String.valueOf(number + 1));
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java by checkstyle

    Checks for long lines.

    Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'java.util.Optional' import. Should be before 'org.jdesktop.layout.LayoutStyle.RELATED'.
    Open

    import java.util.Optional;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'javax.swing.*' import. Should be before 'org.jdesktop.layout.LayoutStyle.RELATED'.
    Open

    import javax.swing.*;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Using the '.*' form of import should be avoided - javax.swing.*.
    Open

    import javax.swing.*;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java by checkstyle

    Checks that there are no import statements that use the * notation.

    Rationale: Importing all classes from a package or staticmembers from a class leads to tight coupling between packagesor classes and might lead to problems when a new version of alibrary introduces name clashes.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Line is longer than 100 characters (found 116).
    Open

                JOptionPane.showMessageDialog(parentDialog, "You must always have at least one button group per page.");
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java by checkstyle

    Checks for long lines.

    Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Extra separation in import group before 'java.awt.event.ActionEvent'
    Open

    import java.awt.event.ActionEvent;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Extra separation in import group before 'javax.swing.*'
    Open

    import javax.swing.*;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'org.jdesktop.layout.GroupLayout' import. Should be before 'org.jdesktop.layout.LayoutStyle.RELATED'.
    Open

    import org.jdesktop.layout.GroupLayout;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Line is longer than 100 characters (found 102).
    Open

            final DefaultListModel<String> model = (DefaultListModel<String>) buttonGroupsList.getModel();
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java by checkstyle

    Checks for long lines.

    Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Extra separation in import group before 'org.jdesktop.layout.GroupLayout'
    Open

    import org.jdesktop.layout.GroupLayout;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Line is longer than 100 characters (found 105).
    Open

                JOptionPane.showMessageDialog(parentDialog, "A button group with this name already exists.");
    Severity: Minor
    Found in src/main/java/org/pdf/forms/gui/windows/RadioButtonGroupOrganiser.java by checkstyle

    Checks for long lines.

    Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    There are no issues that match your filters.

    Category
    Status