r4fterman/pdf.forms

View on GitHub
src/main/java/org/pdf/forms/widgets/components/PdfTextField.java

Summary

Maintainability
C
1 day
Test Coverage
F
32%

Method setVerticalAlignment has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public void setVerticalAlignment(final int alignment) {
        if (alignment == SwingConstants.CENTER) {
            setUI(new BasicTextFieldUI());
            return;
Severity: Minor
Found in src/main/java/org/pdf/forms/widgets/components/PdfTextField.java - About 1 hr to fix

    Method underlineWord has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

                final Graphics graphics,
                final String text,
                final FontMetrics f,
                final int x,
                final int y) {
    Severity: Minor
    Found in src/main/java/org/pdf/forms/widgets/components/PdfTextField.java - About 35 mins to fix

      Method paintComponent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
          public void paintComponent(final Graphics graphics) {
              super.paintComponent(graphics);
      
              final String text = getText();
      Severity: Minor
      Found in src/main/java/org/pdf/forms/widgets/components/PdfTextField.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method underlineWord has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private void underlineWord(
                  final Graphics graphics,
                  final String text,
                  final FontMetrics f,
                  final int x,
      Severity: Minor
      Found in src/main/java/org/pdf/forms/widgets/components/PdfTextField.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          @Override
          public void paintComponent(final Graphics graphics) {
              super.paintComponent(graphics);
      
              final String text = getText();
      src/main/java/org/pdf/forms/widgets/components/PdfButton.java on lines 31..56
      src/main/java/org/pdf/forms/widgets/components/PdfCaption.java on lines 27..52

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 192.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          @Override
          public void setUnderlineType(final int type) {
              switch (type) {
                  case IWidget.UNDERLINE_SINGLE:
                      standardUnderline = true;
      src/main/java/org/pdf/forms/widgets/components/PdfCaption.java on lines 77..107

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 140.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          private void underlineWord(
                  final Graphics graphics,
                  final String text,
                  final FontMetrics f,
                  final int x,
      src/main/java/org/pdf/forms/widgets/components/PdfButton.java on lines 58..76
      src/main/java/org/pdf/forms/widgets/components/PdfCaption.java on lines 54..75

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 130.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Parameter name 'f' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
      Open

                  final FontMetrics f,

      Checks that method parameter names conform to a specified pattern.By using accessModifiers property it is possibleto specify different formats for methods at different visibility levels.

      To validate catch parameters please useCatchParameterName.

      To validate lambda parameters please useLambdaParameterName.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Extra separation in import group before 'javax.swing.*'
      Open

      import javax.swing.*;

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Using the '.*' form of import should be avoided - java.awt.*.
      Open

      import java.awt.*;

      Checks that there are no import statements that use the * notation.

      Rationale: Importing all classes from a package or staticmembers from a class leads to tight coupling between packagesor classes and might lead to problems when a new version of alibrary introduces name clashes.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Parameter name 'x' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
      Open

                  final int x,

      Checks that method parameter names conform to a specified pattern.By using accessModifiers property it is possibleto specify different formats for methods at different visibility levels.

      To validate catch parameters please useCatchParameterName.

      To validate lambda parameters please useLambdaParameterName.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Using the '.*' form of import should be avoided - javax.swing.*.
      Open

      import javax.swing.*;

      Checks that there are no import statements that use the * notation.

      Rationale: Importing all classes from a package or staticmembers from a class leads to tight coupling between packagesor classes and might lead to problems when a new version of alibrary introduces name clashes.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Parameter name 'y' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
      Open

                  final int y) {

      Checks that method parameter names conform to a specified pattern.By using accessModifiers property it is possibleto specify different formats for methods at different visibility levels.

      To validate catch parameters please useCatchParameterName.

      To validate lambda parameters please useLambdaParameterName.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Extra separation in import group before 'org.pdf.forms.fonts.FontHandler'
      Open

      import org.pdf.forms.fonts.FontHandler;

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      There are no issues that match your filters.

      Category
      Status