Sign upLogin

r4fterman/pdf.forms

View on GitHub
Star
src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java

Summary

Maintainability
C
1 day
Test Coverage
F
4%

WidgetAlignmentAndOrder has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

public final class WidgetAlignmentAndOrder {

    public static final String ALIGN_LEFT = "Align Left";
    public static final String ALIGN_RIGHT = "Align Right";
    public static final String ALIGN_TOP = "Align Top";
Severity: Minor
Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java - About 2 hrs to fix

    File WidgetAlignmentAndOrder.java has 255 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package org.pdf.forms.widgets.utils;

import java.awt.*;
import java.util.HashSet;
import java.util.List;
    Severity: Minor
    Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java - About 2 hrs to fix

      Method sendToBack has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private static void sendToBack(
            final List<IWidget> allWidgets,
            final int size,
            final Set<IWidget> selectedWidgets) {
        final Set<IWidget> newSet = new HashSet<>(Set.copyOf(selectedWidgets));
      Severity: Minor
      Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method sendBackwards has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private static void sendBackwards(
            final List<IWidget> allWidgets,
            final int size,
            final Set<IWidget> selectedWidgets) {
        final Set<IWidget> newSet = new HashSet<>(Set.copyOf(selectedWidgets));
      Severity: Minor
      Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Refactor the code in order to not assign to this loop counter from within the loop body.
      Open

                      i = -1;
      Severity: Major
      Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java by sonar-java

      A for loop stop condition should test the loop counter against an invariant value (i.e. one that is true at both the beginning and ending of every loop iteration). Ideally, this means that the stop condition is set to a local variable just before the loop begins.

      Stop conditions that are not invariant are slightly less efficient, as well as being difficult to understand and maintain, and likely lead to the introduction of errors in the future.

      This rule tracks three types of non-invariant stop conditions:

      • When the loop counters are updated in the body of the for loop
      • When the stop condition depend upon a method call
      • When the stop condition depends on an object property, since such properties could change during the execution of the loop.

      Noncompliant Code Example

      for (int i = 0; i < 10; i++) {
  ...
  i = i - 1; // Noncompliant; counter updated in the body of the loop
  ...
}

      Compliant Solution

      for (int i = 0; i < 10; i++) {...}

      Refactor the code in order to not assign to this loop counter from within the loop body.
      Open

                      i = -1;
      Severity: Major
      Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java by sonar-java

      A for loop stop condition should test the loop counter against an invariant value (i.e. one that is true at both the beginning and ending of every loop iteration). Ideally, this means that the stop condition is set to a local variable just before the loop begins.

      Stop conditions that are not invariant are slightly less efficient, as well as being difficult to understand and maintain, and likely lead to the introduction of errors in the future.

      This rule tracks three types of non-invariant stop conditions:

      • When the loop counters are updated in the body of the for loop
      • When the stop condition depend upon a method call
      • When the stop condition depends on an object property, since such properties could change during the execution of the loop.

      Noncompliant Code Example

      for (int i = 0; i < 10; i++) {
  ...
  i = i - 1; // Noncompliant; counter updated in the body of the loop
  ...
}

      Compliant Solution

      for (int i = 0; i < 10; i++) {...}

      Refactor the code in order to not assign to this loop counter from within the loop body.
      Open

                      i = size + 1;
      Severity: Major
      Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java by sonar-java

      A for loop stop condition should test the loop counter against an invariant value (i.e. one that is true at both the beginning and ending of every loop iteration). Ideally, this means that the stop condition is set to a local variable just before the loop begins.

      Stop conditions that are not invariant are slightly less efficient, as well as being difficult to understand and maintain, and likely lead to the introduction of errors in the future.

      This rule tracks three types of non-invariant stop conditions:

      • When the loop counters are updated in the body of the for loop
      • When the stop condition depend upon a method call
      • When the stop condition depends on an object property, since such properties could change during the execution of the loop.

      Noncompliant Code Example

      for (int i = 0; i < 10; i++) {
  ...
  i = i - 1; // Noncompliant; counter updated in the body of the loop
  ...
}

      Compliant Solution

      for (int i = 0; i < 10; i++) {...}

      Refactor the code in order to not assign to this loop counter from within the loop body.
      Open

                      i = size + 1;
      Severity: Major
      Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java by sonar-java

      A for loop stop condition should test the loop counter against an invariant value (i.e. one that is true at both the beginning and ending of every loop iteration). Ideally, this means that the stop condition is set to a local variable just before the loop begins.

      Stop conditions that are not invariant are slightly less efficient, as well as being difficult to understand and maintain, and likely lead to the introduction of errors in the future.

      This rule tracks three types of non-invariant stop conditions:

      • When the loop counters are updated in the body of the for loop
      • When the stop condition depend upon a method call
      • When the stop condition depends on an object property, since such properties could change during the execution of the loop.

      Noncompliant Code Example

      for (int i = 0; i < 10; i++) {
  ...
  i = i - 1; // Noncompliant; counter updated in the body of the loop
  ...
}

      Compliant Solution

      for (int i = 0; i < 10; i++) {...}

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              for (int i = size; i >= 0; i--) {
            final IWidget widget = allWidgets.get(i);
            if (newSet.remove(widget)) {
                if (i > 0) {
                    allWidgets.add(i - 1, allWidgets.remove(i));
      Severity: Major
      Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java and 1 other location - About 1 hr to fix
      src/main/java/org/pdf/forms/gui/commands/SendBackwardCommand.java on lines 51..59

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 82.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          private static int calculateBottomPoint(final Set<IWidget> widgets) {
        if (widgets.isEmpty()) {
            return 0;
        }
      Severity: Major
      Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java and 2 other locations - About 1 hr to fix
      src/main/java/org/pdf/forms/gui/commands/AlignRightCommand.java on lines 42..57
      src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java on lines 244..259

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 82.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          private static int calculateRightPoint(final Set<IWidget> widgets) {
        if (widgets.isEmpty()) {
            return 0;
        }
      Severity: Major
      Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java and 2 other locations - About 1 hr to fix
      src/main/java/org/pdf/forms/gui/commands/AlignRightCommand.java on lines 42..57
      src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java on lines 210..225

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 82.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              for (int i = size; i >= 0; i--) {
            final IWidget widget = allWidgets.get(i);
            if (newSet.remove(widget)) {
                if (i > 0) {
                    allWidgets.add(0, allWidgets.remove(i));
      Severity: Major
      Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java and 1 other location - About 1 hr to fix
      src/main/java/org/pdf/forms/gui/commands/SendToBackCommand.java on lines 52..60

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              for (int i = 0; i < size; i++) {
            final IWidget widget = allWidgets.get(i);
            if (newSet.remove(widget)) {
                allWidgets.add(i + 1, allWidgets.remove(i));
                i = -1;
      Severity: Major
      Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java and 1 other location - About 1 hr to fix
      src/main/java/org/pdf/forms/gui/commands/BringForwardCommand.java on lines 52..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              for (int i = 0; i < size; i++) {
            final IWidget widget = allWidgets.get(i);
            if (newSet.remove(widget)) {
                allWidgets.add(size, allWidgets.remove(i));
                i = -1;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java and 1 other location - About 55 mins to fix
      src/main/java/org/pdf/forms/gui/commands/BringToFrontCommand.java on lines 51..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          private static void alignRight(final Set<IWidget> selectedWidgets) {
        final int rightPoint = calculateRightPoint(selectedWidgets);
        for (final IWidget widget: selectedWidgets) {
            widget.setX(rightPoint - widget.getBounds().width);
        }
      Severity: Major
      Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java and 3 other locations - About 30 mins to fix
      src/main/java/org/pdf/forms/gui/commands/AlignBottomCommand.java on lines 34..39
      src/main/java/org/pdf/forms/gui/commands/AlignRightCommand.java on lines 35..40
      src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java on lines 182..187

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          private static void alignBottom(final Set<IWidget> selectedWidgets) {
        final int bottomPoint = calculateBottomPoint(selectedWidgets);
        for (final IWidget widget: selectedWidgets) {
            widget.setY(bottomPoint - widget.getBounds().height);
        }
      Severity: Major
      Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java and 3 other locations - About 30 mins to fix
      src/main/java/org/pdf/forms/gui/commands/AlignBottomCommand.java on lines 34..39
      src/main/java/org/pdf/forms/gui/commands/AlignRightCommand.java on lines 35..40
      src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java on lines 196..201

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Line is longer than 100 characters (found 109).
      Open

                              selected -> changeOrderOfSelectedWidgets(type, designerPanel.getWidgets(), selected))
      Severity: Minor
      Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Extra separation in import group before 'org.pdf.forms.gui.designer.IDesigner'
      Open

      import org.pdf.forms.gui.designer.IDesigner;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Using the '.*' form of import should be avoided - java.awt.*.
      Open

      import java.awt.*;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/widgets/utils/WidgetAlignmentAndOrder.java by checkstyle

      Checks that there are no import statements that use the * notation.

      Rationale: Importing all classes from a package or staticmembers from a class leads to tight coupling between packagesor classes and might lead to problems when a new version of alibrary introduces name clashes.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      There are no issues that match your filters.

      Category
      Status