Sign upLogin

r4fterman/pdf.forms

View on GitHub
Star
src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java

Summary

Maintainability
C
1 day
Test Coverage
F
0%

Method writeOutCaption has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void writeOutCaption(
            final IWidget widget,
            final Rectangle pageSize,
            final int currentPage,
            final GlobalPdfWriter globalPdfWriter) {
Severity: Minor
Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java - About 1 hr to fix

    Method write has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

                final IWidget widget,
            final Rectangle pageSize,
            final int currentPage,
            final PdfWriter writer,
            final GlobalPdfWriter globalPdfWriter) throws IOException, DocumentException {
    Severity: Minor
    Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java - About 35 mins to fix

      This block of commented-out lines of code should be removed.
      Open

              //Graphics2D graphics2D = cb.createGraphicsShapes(captionBounds.width, captionBounds.height, true, 0.95f);
      Severity: Major
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by sonar-java

      Programmers should not comment out code as it bloats programs and reduces readability.

      Unused code should be deleted and can be retrieved from source control history if required.

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          private void writeOutCaption(
            final IWidget widget,
            final Rectangle pageSize,
            final int currentPage,
            final GlobalPdfWriter globalPdfWriter) {
      Severity: Major
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java and 2 other locations - About 4 hrs to fix
      src/main/java/org/pdf/forms/writer/PdfTextFieldWriter.java on lines 90..143
      src/main/java/org/pdf/forms/writer/PdfTextWriter.java on lines 50..104

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 289.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 5 locations. Consider refactoring.
      Open

          private void addBorder(
            final IWidget widget,
            final BaseField baseField) {
        final Optional<BorderProperties> borderProperties = widget.getWidgetModel().getProperties().getBorder();
        if (borderProperties.isEmpty()) {
      Severity: Major
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java and 4 other locations - About 2 hrs to fix
      src/main/java/org/pdf/forms/writer/PdfButtonWriter.java on lines 75..105
      src/main/java/org/pdf/forms/writer/PdfComboBoxWriter.java on lines 156..184
      src/main/java/org/pdf/forms/writer/PdfListBoxWriter.java on lines 171..200
      src/main/java/org/pdf/forms/writer/PdfTextFieldWriter.java on lines 145..174

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 173.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 8 locations. Consider refactoring.
      Open

          private Rectangle convertJavaCoordsToPdfCoords(
            final java.awt.Rectangle bounds,
            final Rectangle pageSize) {
        final int javaX1 = bounds.x - IMainFrame.INSET;
        final int javaY1 = bounds.y - IMainFrame.INSET;
      Severity: Major
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java and 7 other locations - About 1 hr to fix
      src/main/java/org/pdf/forms/writer/PdfButtonWriter.java on lines 107..119
      src/main/java/org/pdf/forms/writer/PdfComboBoxWriter.java on lines 186..198
      src/main/java/org/pdf/forms/writer/PdfImageWriter.java on lines 64..77
      src/main/java/org/pdf/forms/writer/PdfListBoxWriter.java on lines 202..214
      src/main/java/org/pdf/forms/writer/PdfTextFieldWriter.java on lines 176..188
      src/main/java/org/pdf/forms/writer/PdfTextWriter.java on lines 106..118
      src/main/java/org/pdf/forms/writer/Writer.java on lines 557..569

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 97.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Using the '.*' form of import should be avoided - java.awt.*.
      Open

      import java.awt.*;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks that there are no import statements that use the * notation.

      Rationale: Importing all classes from a package or staticmembers from a class leads to tight coupling between packagesor classes and might lead to problems when a new version of alibrary introduces name clashes.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 115).
      Open

               * probably because the font cannot be embedded due to licensing restrictions, so substitute with Helvetica
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Wrong lexicographical order for 'com.itextpdf.text.pdf.RadioCheckField' import. Should be before 'org.slf4j.LoggerFactory'.
      Open

      import com.itextpdf.text.pdf.RadioCheckField;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 114).
      Open

              //Graphics2D graphics2D = cb.createGraphicsShapes(captionBounds.width, captionBounds.height, true, 0.95f);
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Wrong lexicographical order for 'com.itextpdf.awt.DefaultFontMapper' import. Should be before 'org.slf4j.LoggerFactory'.
      Open

      import com.itextpdf.awt.DefaultFontMapper;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 111).
      Open

              cb.concatCTM(1, 0, 0, 1, pdfCaptionBounds.getLeft(), pdfCaptionBounds.getTop() - captionBounds.height);
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Wrong lexicographical order for 'com.itextpdf.text.Rectangle' import. Should be before 'org.slf4j.LoggerFactory'.
      Open

      import com.itextpdf.text.Rectangle;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Extra separation in import group before 'com.itextpdf.awt.DefaultFontMapper'
      Open

      import com.itextpdf.awt.DefaultFontMapper;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Wrong lexicographical order for 'com.itextpdf.text.pdf.GrayColor' import. Should be before 'org.slf4j.LoggerFactory'.
      Open

      import com.itextpdf.text.pdf.GrayColor;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 108).
      Open

               * we need to make this erroneous call to awtToPdf to see if an exception is thrown, if it is, it is
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Extra separation in import group before 'org.pdf.forms.fonts.FontHandler'
      Open

      import org.pdf.forms.fonts.FontHandler;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Wrong lexicographical order for 'com.itextpdf.text.pdf.PdfFormField' import. Should be before 'org.slf4j.LoggerFactory'.
      Open

      import com.itextpdf.text.pdf.PdfFormField;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 103).
      Open

              final int color = borders.getBorderColor().map(Integer::parseInt).orElse(Color.WHITE.getRGB());
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 112).
      Open

              final Optional<BorderProperties> borderProperties = widget.getWidgetModel().getProperties().getBorder();
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 101).
      Open

                  final Caption caption = widget.getWidgetModel().getProperties().getLayout().getCaption();
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Wrong lexicographical order for 'com.itextpdf.text.DocumentException' import. Should be before 'org.slf4j.LoggerFactory'.
      Open

      import com.itextpdf.text.DocumentException;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Wrong lexicographical order for 'com.itextpdf.text.pdf.PdfBorderDictionary' import. Should be before 'org.slf4j.LoggerFactory'.
      Open

      import com.itextpdf.text.pdf.PdfBorderDictionary;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Wrong lexicographical order for 'com.itextpdf.text.pdf.PdfContentByte' import. Should be before 'org.slf4j.LoggerFactory'.
      Open

      import com.itextpdf.text.pdf.PdfContentByte;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Wrong lexicographical order for 'com.itextpdf.text.pdf.BaseField' import. Should be before 'org.slf4j.LoggerFactory'.
      Open

      import com.itextpdf.text.pdf.BaseField;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Wrong lexicographical order for 'com.itextpdf.text.pdf.PdfWriter' import. Should be before 'org.slf4j.LoggerFactory'.
      Open

      import com.itextpdf.text.pdf.PdfWriter;
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 119).
      Open

              final Graphics2D graphics2D = cb.createGraphics(captionBounds.width, captionBounds.height, mapper, true, .95f);
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 112).
      Open

              final RadioCheckField check = new RadioCheckField(writer, pdfValueBounds, widget.getWidgetName(), "On");
      Severity: Minor
      Found in src/main/java/org/pdf/forms/writer/PdfCheckBoxWriter.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      There are no issues that match your filters.

      Category
      Status