Sign upLogin

rabobank-blockchain/ula-vp-controller

View on GitHub
Star
src/vp-controller.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Function handleEvent has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public async handleEvent (message: Message, callback: any): Promise<string> {
    if (message.properties.type.match('accept-consent')) {
      return this.handleConsent(message, callback)
    }
Severity: Major
Found in src/vp-controller.ts - About 3 hrs to fix

    Function handleEvent has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      public async handleEvent (message: Message, callback: any): Promise<string> {
    if (message.properties.type.match('accept-consent')) {
      return this.handleConsent(message, callback)
    }
    Severity: Minor
    Found in src/vp-controller.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return 'success'
    Severity: Major
    Found in src/vp-controller.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return this.handleConsent(new Message(nextMessage.body), callback)
      Severity: Major
      Found in src/vp-controller.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return 'error'
        Severity: Major
        Found in src/vp-controller.ts - About 30 mins to fix

          Function handleConsent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            private async handleConsent (message: Message, callback: any): Promise<string> {
    // Send challengeresponse (VP) and process the response from the endpoint
    const challengeRequest = message.properties.payload.challengeRequest as ChallengeRequest
    const selfAttestedVP = message.properties.payload.verifiablePresentation as VerifiablePresentation
    const response = await this._httpService.postRequest(challengeRequest.postEndpoint, selfAttestedVP)
          Severity: Minor
          Found in src/vp-controller.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status