Sign upLogin

radar-parlamentar/radar

View on GitHub
Star
radar_parlamentar/importadores/cmsp.py

Summary

Maintainability
C
1 day
Test Coverage

Function guarantee_existence_of_proposition has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def guarantee_existence_of_proposition(self,
Severity: Minor
Found in radar_parlamentar/importadores/cmsp.py - About 35 mins to fix

    Avoid too many return statements within this function.
    Open

                return models.ABSTENCAO
    Severity: Major
    Found in radar_parlamentar/importadores/cmsp.py - About 30 mins to fix

      Function votos_from_tree has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def votos_from_tree(self, vot_tree, votacao):
        """Extrai lista de votos do XML da votação e as salva no banco de dados

        Argumentos:
           vot_tree -- etree dos votos
      Severity: Minor
      Found in radar_parlamentar/importadores/cmsp.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def converte_data(self, data_str):
        """Converte string "d/m/a para objeto datetime;
        retona None se data_str é inválido"""
        DATA_REGEX = '(\d\d?)/(\d\d?)/(\d{4})'
        res = re.match(DATA_REGEX, data_str)
      Severity: Major
      Found in radar_parlamentar/importadores/cmsp.py and 1 other location - About 3 hrs to fix
      radar_parlamentar/importadores/cdep.py on lines 266..277

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def salvar_cmsp(self):
        cmsp = models.CasaLegislativa()
        cmsp.nome = 'Câmara Municipal de São Paulo'
        cmsp.nome_curto = 'cmsp'
        cmsp.esfera = models.MUNICIPAL
      Severity: Major
      Found in radar_parlamentar/importadores/cmsp.py and 1 other location - About 2 hrs to fix
      radar_parlamentar/importadores/conv.py on lines 50..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          def _init_parlamentares(self):
        """retorna dicionário (nome_parlamentar, nome_partido) ->\
        Parlamentar"""
        parlamentares = {}
        for p in models.Parlamentar.objects.filter(casa_legislativa=self.cmsp):
      Severity: Major
      Found in radar_parlamentar/importadores/cmsp.py and 3 other locations - About 2 hrs to fix
      radar_parlamentar/importadores/cdep.py on lines 310..316
      radar_parlamentar/importadores/cdep.py on lines 331..337
      radar_parlamentar/importadores/sen.py on lines 80..87

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if partido is None:
            logger.info('Nao achou o partido %s' % nome_partido)
            partido = models.Partido.get_sem_partido()
      Severity: Minor
      Found in radar_parlamentar/importadores/cmsp.py and 1 other location - About 50 mins to fix
      radar_parlamentar/importadores/sen.py on lines 139..141

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 36.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Line too long (93 > 79 characters)
      Open

                      return res.group(1).upper()+" "+res.group(2).upper()+"/"+res.group(3).upper()
      Severity: Minor
      Found in radar_parlamentar/importadores/cmsp.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Invalid escape sequence '\d'
      Open

              DATA_REGEX = '(\d\d?)/(\d\d?)/(\d{4})'
      Severity: Minor
      Found in radar_parlamentar/importadores/cmsp.py by pep8

      Invalid escape sequences are deprecated in Python 3.6.

      Okay: regex = r'\.png$'
W605: regex = '\.png$'

      Line too long (97 > 79 characters)
      Open

          XML_URL = 'https://splegispdarmazenamento.blob.core.windows.net/containersip/VOTACOES_%d.xml'
      Severity: Minor
      Found in radar_parlamentar/importadores/cmsp.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Expected 2 blank lines, found 1
      Open

      class AcessoXmlCmsp(object):
      Severity: Minor
      Found in radar_parlamentar/importadores/cmsp.py by pep8

      Separate top-level function and class definitions with two blank lines.

      Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass

      Invalid escape sequence '\d'
      Open

              DATA_REGEX = '(\d\d?)/(\d\d?)/(\d{4})'
      Severity: Minor
      Found in radar_parlamentar/importadores/cmsp.py by pep8

      Invalid escape sequences are deprecated in Python 3.6.

      Okay: regex = r'\.png$'
W605: regex = '\.png$'

      Invalid escape sequence '\d'
      Open

              DATA_REGEX = '(\d\d?)/(\d\d?)/(\d{4})'
      Severity: Minor
      Found in radar_parlamentar/importadores/cmsp.py by pep8

      Invalid escape sequences are deprecated in Python 3.6.

      Okay: regex = r'\.png$'
W605: regex = '\.png$'

      Invalid escape sequence '\d'
      Open

              DATA_REGEX = '(\d\d?)/(\d\d?)/(\d{4})'
      Severity: Minor
      Found in radar_parlamentar/importadores/cmsp.py by pep8

      Invalid escape sequences are deprecated in Python 3.6.

      Okay: regex = r'\.png$'
W605: regex = '\.png$'

      Invalid escape sequence '\d'
      Open

              DATA_REGEX = '(\d\d?)/(\d\d?)/(\d{4})'
      Severity: Minor
      Found in radar_parlamentar/importadores/cmsp.py by pep8

      Invalid escape sequences are deprecated in Python 3.6.

      Okay: regex = r'\.png$'
W605: regex = '\.png$'

      Line too long (99 > 79 characters)
      Open

                  raise ValueError("ano informado = %d, mas não pode ser menor que %d." % (ano, ANO_MIN))
      Severity: Minor
      Found in radar_parlamentar/importadores/cmsp.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      There are no issues that match your filters.

      Category
      Status