Sign upLogin

radar-parlamentar/radar

View on GitHub
Star
radar_parlamentar/modelagem/utils.py

Summary

Maintainability
B
5 hrs
Test Coverage

Cyclomatic complexity is too high in method _data_inicio_prox_periodo. (14)
Open

    def _data_inicio_prox_periodo(self, data_inicio_periodo):
        # TODO tb extrair e fazer testes
        # dia
        dia_inicial = 1
        # mês
Severity: Minor
Found in radar_parlamentar/modelagem/utils.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function _data_inicio_prox_periodo has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def _data_inicio_prox_periodo(self, data_inicio_periodo):
        # TODO tb extrair e fazer testes
        # dia
        dia_inicial = 1
        # mês
Severity: Minor
Found in radar_parlamentar/modelagem/utils.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity is too high in method _inicio_primeiro_periodo. (7)
Open

    def _inicio_primeiro_periodo(self):
        # TODO extrair e fazer teste de unidade só pra esse método
        # dia
        dia_inicial = 1
        # mês
Severity: Minor
Found in radar_parlamentar/modelagem/utils.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in class PeriodosRetriever. (6)
Open

class PeriodosRetriever:

    """Recupera os períodos com um mínimo de votações de uma casa legislativa
        entre data_da_primeira_votacao e data_da_ultima_votacao
        Argumentos:
Severity: Minor
Found in radar_parlamentar/modelagem/utils.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function _inicio_primeiro_periodo has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def _inicio_primeiro_periodo(self):
        # TODO extrair e fazer teste de unidade só pra esse método
        # dia
        dia_inicial = 1
        # mês
Severity: Minor
Found in radar_parlamentar/modelagem/utils.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, casa_legislativa, periodicidade,
Severity: Minor
Found in radar_parlamentar/modelagem/utils.py - About 35 mins to fix

    Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed.
    Open

        def _data_inicio_prox_periodo(self, data_inicio_periodo):
    Severity: Critical
    Found in radar_parlamentar/modelagem/utils.py by sonar-python

    Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

    See

    TODO found
    Open

                # TODO a query abaixo poderia usar um ORDER BY
    Severity: Minor
    Found in radar_parlamentar/modelagem/utils.py by fixme

    TODO found
    Open

            # TODO extrair e fazer teste de unidade só pra esse método
    Severity: Minor
    Found in radar_parlamentar/modelagem/utils.py by fixme

    TODO found
    Open

            # TODO tb extrair e fazer testes
    Severity: Minor
    Found in radar_parlamentar/modelagem/utils.py by fixme

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            elif self.periodicidade == SEMESTRE:
            if data_inicio_periodo.month < 7:
                ano_inicial = data_inicio_periodo.year
            else:
                ano_inicial = data_inicio_periodo.year + 1
    Severity: Minor
    Found in radar_parlamentar/modelagem/utils.py and 1 other location - About 35 mins to fix
    radar_parlamentar/modelagem/utils.py on lines 174..178

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if self.periodicidade == MES:
            if data_inicio_periodo.month < 12:
                ano_inicial = data_inicio_periodo.year
            else:
                ano_inicial = data_inicio_periodo.year + 1
    Severity: Minor
    Found in radar_parlamentar/modelagem/utils.py and 1 other location - About 35 mins to fix
    radar_parlamentar/modelagem/utils.py on lines 179..183

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Invalid escape sequence '\i'
    Open

                de 4 anos começando em 2009 + i*4, i \in Z
    Severity: Minor
    Found in radar_parlamentar/modelagem/utils.py by pep8

    Invalid escape sequences are deprecated in Python 3.6.

    Okay: regex = r'\.png$'
W605: regex = '\.png$'

    Invalid escape sequence '\i'
    Open

                em 2011 + i*4, i \in Z
    Severity: Minor
    Found in radar_parlamentar/modelagem/utils.py by pep8

    Invalid escape sequences are deprecated in Python 3.6.

    Okay: regex = r'\.png$'
W605: regex = '\.png$'

    There are no issues that match your filters.

    Category
    Status