Sign upLogin

radar/twist-v2

View on GitHub
Star

Showing 143 of 143 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    gridRowStart: {
      auto: 'auto',
      '1': '1',
      '2': '2',
      '3': '3',
Severity: Minor
Found in frontend/tailwind.js and 1 other location - About 35 mins to fix
frontend/tailwind.js on lines 517..526

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    gridRowEnd: {
      auto: 'auto',
      '1': '1',
      '2': '2',
      '3': '3',
Severity: Minor
Found in frontend/tailwind.js and 1 other location - About 35 mins to fix
frontend/tailwind.js on lines 507..516

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  change do
    create_table :images do
      primary_key :id
      column :filename, String
      column :image_data, String
Severity: Minor
Found in backend/db/migrate/20180319055837_create_images.rb and 1 other location - About 35 mins to fix
backend/db/migrate/20180319055339_create_elements.rb on lines 2..12

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const renderPreviousChapterLink = () => {
    if (previousChapter) {
      return (
        <PreviousChapterLink
          {...previousChapter}
Severity: Minor
Found in frontend/src/Book/Chapter/index.tsx and 1 other location - About 30 mins to fix
frontend/src/Book/Chapter/index.tsx on lines 66..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const renderNextChapterLink = () => {
    if (nextChapter) {
      return (
        <NextChapterLink
          {...nextChapter}
Severity: Minor
Found in frontend/src/Book/Chapter/index.tsx and 1 other location - About 30 mins to fix
frontend/src/Book/Chapter/index.tsx on lines 54..64

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

export type RemoveReaderMutationVariables = Exact<{
  bookId: Scalars['ID'];
  userId: Scalars['ID'];
}>;
Severity: Major
Found in frontend/src/graphql/types.ts and 9 other locations - About 30 mins to fix
frontend/src/graphql/types.ts on lines 422..425
frontend/src/graphql/types.ts on lines 430..433
frontend/src/graphql/types.ts on lines 482..485
frontend/src/graphql/types.ts on lines 507..510
frontend/src/graphql/types.ts on lines 544..547
frontend/src/graphql/types.ts on lines 574..577
frontend/src/graphql/types.ts on lines 582..585
frontend/src/graphql/types.ts on lines 603..606
frontend/src/graphql/types.ts on lines 646..649

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

export type NoteQueryVariables = Exact<{
  bookPermalink: Scalars['String'];
  number: Scalars['Int'];
}>;
Severity: Major
Found in frontend/src/graphql/types.ts and 9 other locations - About 30 mins to fix
frontend/src/graphql/types.ts on lines 422..425
frontend/src/graphql/types.ts on lines 430..433
frontend/src/graphql/types.ts on lines 482..485
frontend/src/graphql/types.ts on lines 507..510
frontend/src/graphql/types.ts on lines 522..525
frontend/src/graphql/types.ts on lines 544..547
frontend/src/graphql/types.ts on lines 574..577
frontend/src/graphql/types.ts on lines 603..606
frontend/src/graphql/types.ts on lines 646..649

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

export type ChapterNotesQueryVariables = Exact<{
  elementId: Scalars['String'];
  bookPermalink: Scalars['String'];
}>;
Severity: Major
Found in frontend/src/graphql/types.ts and 9 other locations - About 30 mins to fix
frontend/src/graphql/types.ts on lines 422..425
frontend/src/graphql/types.ts on lines 430..433
frontend/src/graphql/types.ts on lines 507..510
frontend/src/graphql/types.ts on lines 522..525
frontend/src/graphql/types.ts on lines 544..547
frontend/src/graphql/types.ts on lines 574..577
frontend/src/graphql/types.ts on lines 582..585
frontend/src/graphql/types.ts on lines 603..606
frontend/src/graphql/types.ts on lines 646..649

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

export type LoginMutationMutationVariables = Exact<{
  email: Scalars['String'];
  password: Scalars['String'];
}>;
Severity: Major
Found in frontend/src/graphql/types.ts and 9 other locations - About 30 mins to fix
frontend/src/graphql/types.ts on lines 422..425
frontend/src/graphql/types.ts on lines 430..433
frontend/src/graphql/types.ts on lines 482..485
frontend/src/graphql/types.ts on lines 507..510
frontend/src/graphql/types.ts on lines 522..525
frontend/src/graphql/types.ts on lines 544..547
frontend/src/graphql/types.ts on lines 574..577
frontend/src/graphql/types.ts on lines 582..585
frontend/src/graphql/types.ts on lines 603..606

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

export type InviteUserMutationVariables = Exact<{
  bookId: Scalars['ID'];
  userId: Scalars['ID'];
}>;
Severity: Major
Found in frontend/src/graphql/types.ts and 9 other locations - About 30 mins to fix
frontend/src/graphql/types.ts on lines 422..425
frontend/src/graphql/types.ts on lines 430..433
frontend/src/graphql/types.ts on lines 482..485
frontend/src/graphql/types.ts on lines 522..525
frontend/src/graphql/types.ts on lines 544..547
frontend/src/graphql/types.ts on lines 574..577
frontend/src/graphql/types.ts on lines 582..585
frontend/src/graphql/types.ts on lines 603..606
frontend/src/graphql/types.ts on lines 646..649

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

export type AddCommentMutationMutationVariables = Exact<{
  noteId: Scalars['ID'];
  text: Scalars['String'];
}>;
Severity: Major
Found in frontend/src/graphql/types.ts and 9 other locations - About 30 mins to fix
frontend/src/graphql/types.ts on lines 422..425
frontend/src/graphql/types.ts on lines 430..433
frontend/src/graphql/types.ts on lines 482..485
frontend/src/graphql/types.ts on lines 507..510
frontend/src/graphql/types.ts on lines 522..525
frontend/src/graphql/types.ts on lines 574..577
frontend/src/graphql/types.ts on lines 582..585
frontend/src/graphql/types.ts on lines 603..606
frontend/src/graphql/types.ts on lines 646..649

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

export type UpdateBranchMutationVariables = Exact<{
  bookPermalink: Scalars['String'];
  branchName: Scalars['String'];
}>;
Severity: Major
Found in frontend/src/graphql/types.ts and 9 other locations - About 30 mins to fix
frontend/src/graphql/types.ts on lines 430..433
frontend/src/graphql/types.ts on lines 482..485
frontend/src/graphql/types.ts on lines 507..510
frontend/src/graphql/types.ts on lines 522..525
frontend/src/graphql/types.ts on lines 544..547
frontend/src/graphql/types.ts on lines 574..577
frontend/src/graphql/types.ts on lines 582..585
frontend/src/graphql/types.ts on lines 603..606
frontend/src/graphql/types.ts on lines 646..649

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

export type BranchQueryVariables = Exact<{
  bookPermalink: Scalars['String'];
  name: Scalars['String'];
}>;
Severity: Major
Found in frontend/src/graphql/types.ts and 9 other locations - About 30 mins to fix
frontend/src/graphql/types.ts on lines 422..425
frontend/src/graphql/types.ts on lines 482..485
frontend/src/graphql/types.ts on lines 507..510
frontend/src/graphql/types.ts on lines 522..525
frontend/src/graphql/types.ts on lines 544..547
frontend/src/graphql/types.ts on lines 574..577
frontend/src/graphql/types.ts on lines 582..585
frontend/src/graphql/types.ts on lines 603..606
frontend/src/graphql/types.ts on lines 646..649

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

export type UpdateNoteMutationMutationVariables = Exact<{
  id: Scalars['ID'];
  text: Scalars['String'];
}>;
Severity: Major
Found in frontend/src/graphql/types.ts and 9 other locations - About 30 mins to fix
frontend/src/graphql/types.ts on lines 422..425
frontend/src/graphql/types.ts on lines 430..433
frontend/src/graphql/types.ts on lines 482..485
frontend/src/graphql/types.ts on lines 507..510
frontend/src/graphql/types.ts on lines 522..525
frontend/src/graphql/types.ts on lines 544..547
frontend/src/graphql/types.ts on lines 574..577
frontend/src/graphql/types.ts on lines 582..585
frontend/src/graphql/types.ts on lines 646..649

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

export type UpdateCommentMutationMutationVariables = Exact<{
  id: Scalars['ID'];
  text: Scalars['String'];
}>;
Severity: Major
Found in frontend/src/graphql/types.ts and 9 other locations - About 30 mins to fix
frontend/src/graphql/types.ts on lines 422..425
frontend/src/graphql/types.ts on lines 430..433
frontend/src/graphql/types.ts on lines 482..485
frontend/src/graphql/types.ts on lines 507..510
frontend/src/graphql/types.ts on lines 522..525
frontend/src/graphql/types.ts on lines 544..547
frontend/src/graphql/types.ts on lines 582..585
frontend/src/graphql/types.ts on lines 603..606
frontend/src/graphql/types.ts on lines 646..649

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    view_query = self[:notes]
    .join(:elements, id: :element_id)
    .join(:chapters, id: :chapter_id)
    .join(:commits, id: :commit_id)
    .join(:branches, id: :branch_id)
Severity: Minor
Found in backend/db/migrate/20190403215406_update_book_notes_view.rb and 1 other location - About 30 mins to fix
backend/db/migrate/20180405234855_create_book_notes_view.rb on lines 3..9

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    view_query = self[:notes]
      .join(:elements, id: :element_id)
      .join(:chapters, id: :chapter_id)
      .join(:commits, id: :commit_id)
      .join(:branches, id: :branch_id)
Severity: Minor
Found in backend/db/migrate/20180405234855_create_book_notes_view.rb and 1 other location - About 30 mins to fix
backend/db/migrate/20190403215406_update_book_notes_view.rb on lines 3..9

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function Element has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

const Element: React.FC<ElementProps> = (props) => {
  const { noteCount: initialNoteCount, id, bookPermalink } = props;
  const [noteCount, setNoteCount] = useState<number>(initialNoteCount);
  const [showNotes, setShowNotes] = useState<boolean>(false);
Severity: Minor
Found in frontend/src/Book/Chapter/Element.tsx - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_div has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def process_div(element)
          return unless element["class"]

          classes = element["class"].split(" ")
Severity: Minor
Found in backend/lib/twist/processors/asciidoc/chapter_processor.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def call(token)
          return Failure("no token specified") if !token || token.length == 0

          token = token.split.last
          return Failure("no token specified") unless token
Severity: Minor
Found in backend/lib/twist/transactions/users/find_current_user.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language