Sign upLogin

radgrad/radgrad2

View on GitHub
Star
app/imports/api/user/UserCollection.ts

Summary

Maintainability
A
2 hrs
Test Coverage

Function define has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  public define({ username, role }: { username: string; role: string; }) {
    // console.log('Users.define', username, role);
    if (Meteor.isServer) {
      Roles.createRole(role, { unlessExists: true });
      // In test Meteor.settings is not set from settings.development.json so we use _.get to see if it is set.
Severity: Minor
Found in app/imports/api/user/UserCollection.ts - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

      return [this.getAdminProfile()];
Severity: Major
Found in app/imports/api/user/UserCollection.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return undefined;
    Severity: Major
    Found in app/imports/api/user/UserCollection.ts - About 30 mins to fix

      Function findProfilesWithRole has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        public findProfilesWithRole(role, selector, options) {
    const theSelector = (typeof selector === 'undefined') ? {} : selector;
    if (role === ROLE.STUDENT) { // TODO why isn't this a switch?
      theSelector.isAlumni = false;
      return StudentProfiles.findNonRetired(theSelector, options);
      Severity: Minor
      Found in app/imports/api/user/UserCollection.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status