Sign upLogin

radgrad/radgrad2

View on GitHub
Star
app/imports/ui/pages/admin/AdminAnalyticsNewsletterPage.tsx

Summary

Maintainability
B
5 hrs
Test Coverage

Function iceRecHelper has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

const iceRecHelper = (student: StudentProfile, value, component): string => {
  let html = '';
  if (value >= 100) {
    html += `Congratulations! You have achieved 100 ${iceMap[component].name} points!`;
    return html;
Severity: Minor
Found in app/imports/ui/pages/admin/AdminAnalyticsNewsletterPage.tsx - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function AdminAnalyticsNewsletterPage has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

const AdminAnalyticsNewsletterPage: React.FC = () => {

  const [testNewsletterWorking, setTestNewsletterWorking] = useStickyState('Newsletter.test', false);
  const [levelNewsletterWorking, setLevelNewsletterWorking] = useStickyState('Newsletter.level', false);
  const [allNewsletterWorking, setAllNewsletterWorking] = useStickyState('Newsletter.all', false);
Severity: Minor
Found in app/imports/ui/pages/admin/AdminAnalyticsNewsletterPage.tsx - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

      return ' <em><a href="https://radgrad.ics.hawaii.edu">' +
        ' Add more Interests to your profile so we can provide opportunity recommendations!</a></em>';
Severity: Major
Found in app/imports/ui/pages/admin/AdminAnalyticsNewsletterPage.tsx - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

      return html;
    Severity: Major
    Found in app/imports/ui/pages/admin/AdminAnalyticsNewsletterPage.tsx - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status