Sign upLogin

radiorabe/raar

View on GitHub
Star

Showing 14 of 14 total issues

Class Composer has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Composer

      include Loggable

      COMMON_FLAC_FRAME_SIZE = 1024
Severity: Minor
Found in app/services/import/recording/composer.rb - About 3 hrs to fix

    Method crud_swagger_paths has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def crud_swagger_paths(options = {})
        route_prefix = options[:route_prefix]
        route_key = options[:route_key] || model_class.model_name.route_key
        model_name = options[:model_name] ||
                     model_class.model_name.singular.humanize(capitalize: false)
    Severity: Major
    Found in app/controllers/concerns/admin/crud_swag.rb - About 2 hrs to fix

      Class Ffmpeg has 24 methods (exceeds 20 allowed). Consider refactoring.
      Open

        class Ffmpeg < Base

    # The possible ID3 tags and their corresponding ffmpeg metadata names.
    METADATA_TAGS = { title: :title,
                      artist: :artist,
      Severity: Minor
      Found in app/services/audio_processor/ffmpeg.rb - About 2 hrs to fix

        Method define_tasks has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def define_tasks # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
      namespace :artifact do
        desc 'Copy repo to releases'
        task :create_release do
          on release_roles(:all) do
        Severity: Minor
        Found in lib/capistrano/artifact_plugin.rb - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            swagger_path '/shows/{show_id}/tracks' do
    operation :get do
      key :description, 'Returns a list of tracks of the given show.'
      key :tags, [:track, :public]
          Severity: Major
          Found in app/controllers/tracks_controller.rb and 1 other location - About 1 hr to fix
          app/controllers/tracks_controller.rb on lines 84..105

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            swagger_path('/broadcasts/{broadcast_id}/tracks') do
    operation :get do
      key :description, 'Returns a list of tracks of the given broadcast.'
      key :tags, [:track, :public]
          Severity: Major
          Found in app/controllers/tracks_controller.rb and 1 other location - About 1 hr to fix
          app/controllers/tracks_controller.rb on lines 60..81

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method define_tasks has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              def define_tasks # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
      namespace :artifact do
        desc 'Copy repo to releases'
        task :create_release do
          on release_roles(:all) do
          Severity: Minor
          Found in lib/capistrano/artifact_plugin.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method search_other_table_condition has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def search_other_table_condition(word, broadcast_field, table_name, select_field, *fields)
          Severity: Minor
          Found in app/controllers/broadcasts_controller.rb - About 35 mins to fix

            Method convert_list_to_flac has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                  def convert_list_to_flac(list, format)
        retries ||= 0
        frame_size ||= COMMON_FLAC_FRAME_SIZE
        convert_file_list(list) { |file| convert_to_flac(file, format, frame_size) }
      rescue AudioProcessor::FailingFrameSizeError
            Severity: Minor
            Found in app/services/import/recording/composer.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method crud_swagger_paths has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                  def crud_swagger_paths(options = {})
        route_prefix = options[:route_prefix]
        route_key = options[:route_key] || model_class.model_name.route_key
        model_name = options[:model_name] ||
                     model_class.model_name.singular.humanize(capitalize: false)
            Severity: Minor
            Found in app/controllers/concerns/admin/crud_swag.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method fetch_user_and_update_user has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def fetch_user_and_update_user(username, groups, first_name, last_name)
      return if username.blank?

      User.where(username: username).first_or_initialize.tap do |user|
        user.groups = groups if groups.present?
            Severity: Minor
            Found in app/controllers/auth/remote_header.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                operation :patch do
      key :description, 'Updates the description of a show.'
      key :tags, [:show]

      parameter_id('show', 'update')
            Severity: Minor
            Found in app/controllers/shows_controller.rb and 1 other location - About 30 mins to fix
            app/controllers/broadcasts_controller.rb on lines 137..150

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 33.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                operation :patch do
      key :description, 'Updates the description of an existing broadcast.'
      key :tags, [:broadcast]

      parameter_id('broadcast', 'update')
            Severity: Minor
            Found in app/controllers/broadcasts_controller.rb and 1 other location - About 30 mins to fix
            app/controllers/shows_controller.rb on lines 51..64

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 33.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method fetch_entries has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def fetch_entries
    sortable = sortable?
    if sortable || default_sort
      clause = [sortable ? sort_expression : nil, default_sort]
      super.reorder(Arel.sql(clause.compact.join(', ')))
            Severity: Minor
            Found in app/controllers/concerns/sortable.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language