radiorabe/raar

View on GitHub

Showing 10 of 14 total issues

Class Composer has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Composer

      include Loggable

      COMMON_FLAC_FRAME_SIZE = 1024
Severity: Minor
Found in app/services/import/recording/composer.rb - About 3 hrs to fix

    Method crud_swagger_paths has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def crud_swagger_paths(options = {})
            route_prefix = options[:route_prefix]
            route_key = options[:route_key] || model_class.model_name.route_key
            model_name = options[:model_name] ||
                         model_class.model_name.singular.humanize(capitalize: false)
    Severity: Major
    Found in app/controllers/concerns/admin/crud_swag.rb - About 2 hrs to fix

      Class Ffmpeg has 24 methods (exceeds 20 allowed). Consider refactoring.
      Open

        class Ffmpeg < Base
      
          # The possible ID3 tags and their corresponding ffmpeg metadata names.
          METADATA_TAGS = { title: :title,
                            artist: :artist,
      Severity: Minor
      Found in app/services/audio_processor/ffmpeg.rb - About 2 hrs to fix

        Method define_tasks has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def define_tasks # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
              namespace :artifact do
                desc 'Copy repo to releases'
                task :create_release do
                  on release_roles(:all) do
        Severity: Minor
        Found in lib/capistrano/artifact_plugin.rb - About 1 hr to fix

          Method define_tasks has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              def define_tasks # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
                namespace :artifact do
                  desc 'Copy repo to releases'
                  task :create_release do
                    on release_roles(:all) do
          Severity: Minor
          Found in lib/capistrano/artifact_plugin.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method search_other_table_condition has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def search_other_table_condition(word, broadcast_field, table_name, select_field, *fields)
          Severity: Minor
          Found in app/controllers/broadcasts_controller.rb - About 35 mins to fix

            Method convert_list_to_flac has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                  def convert_list_to_flac(list, format)
                    retries ||= 0
                    frame_size ||= COMMON_FLAC_FRAME_SIZE
                    convert_file_list(list) { |file| convert_to_flac(file, format, frame_size) }
                  rescue AudioProcessor::FailingFrameSizeError
            Severity: Minor
            Found in app/services/import/recording/composer.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method crud_swagger_paths has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                  def crud_swagger_paths(options = {})
                    route_prefix = options[:route_prefix]
                    route_key = options[:route_key] || model_class.model_name.route_key
                    model_name = options[:model_name] ||
                                 model_class.model_name.singular.humanize(capitalize: false)
            Severity: Minor
            Found in app/controllers/concerns/admin/crud_swag.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method fetch_user_and_update_user has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def fetch_user_and_update_user(username, groups, first_name, last_name)
                  return if username.blank?
            
                  User.where(username: username).first_or_initialize.tap do |user|
                    user.groups = groups if groups.present?
            Severity: Minor
            Found in app/controllers/auth/remote_header.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method fetch_entries has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def fetch_entries
                sortable = sortable?
                if sortable || default_sort
                  clause = [sortable ? sort_expression : nil, default_sort]
                  super.reorder(Arel.sql(clause.compact.join(', ')))
            Severity: Minor
            Found in app/controllers/concerns/sortable.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language