Sign upLogin

railpage/railpagecore

View on GitHub
Star
lib/GTFS/AU/SA/AdelaideMetro/AdelaideMetro.php

Summary

Maintainability
A
55 mins
Test Coverage

Avoid unused private fields such as '$allowed_routes'.
Open

    private $allowed_routes = array(
        "BEL", 
        "GAW",
        "GAWC",
        "GRNG",
Severity: Minor
Found in lib/GTFS/AU/SA/AdelaideMetro/AdelaideMetro.php by phpmd

UnusedPrivateField

Since: 0.2

Detects when a private field is declared and/or assigned a value, but not used.

Example

class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private $allowed_routes = array(
        "BEL", 
        "GAW",
        "GAWC",
        "GRNG",
Severity: Minor
Found in lib/GTFS/AU/SA/AdelaideMetro/AdelaideMetro.php and 1 other location - About 55 mins to fix
lib/Images/Provider/SmugMug.php on lines 152..154

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status