Sign upLogin

railpage/railpagecore

View on GitHub
Star
lib/Images/Utility/CompNotify.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method notifyWinner has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function notifyWinner(Competition $compObject) {
            
        if (isset($compObject->meta['winnernotified']) && $compObject->meta['winnernotified'] === true) {
            return $this;
        }
Severity: Minor
Found in lib/Images/Utility/CompNotify.php - About 1 hr to fix

    Function notifyWinner has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function notifyWinner(Competition $compObject) {
            
        if (isset($compObject->meta['winnernotified']) && $compObject->meta['winnernotified'] === true) {
            return $this;
        }
    Severity: Minor
    Found in lib/Images/Utility/CompNotify.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid using undefined variables such as '$this' which will lead to PHP notices.
    Open

                return $this;
    Severity: Minor
    Found in lib/Images/Utility/CompNotify.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid assigning values to variables in if clauses and the like (line '53', column '13').
    Open

        public static function notifyWinner(Competition $compObject) {
            
        if (isset($compObject->meta['winnernotified']) && $compObject->meta['winnernotified'] === true) {
            return $this;
        }
    Severity: Minor
    Found in lib/Images/Utility/CompNotify.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                $Notification->AddRecipient($Photo->Author->id, $Photo->Author->username, $Photo->Author->contact_email);
    Severity: Major
    Found in lib/Images/Utility/CompNotify.php and 2 other locations - About 50 mins to fix
    lib/PrivateMessages/Message.php on lines 424..424
    lib/Reminders/Reminder.php on lines 372..372

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

                    $body = wpautop(format_post($body));
    Severity: Major
    Found in lib/Images/Utility/CompNotify.php and 6 other locations - About 30 mins to fix
    lib/Images/Utility/ImageUtility.php on lines 94..94
    lib/Jobs/Locations.php on lines 78..78
    lib/Railcams/Camera.php on lines 856..856
    lib/AppCore.php on lines 561..561
    lib/ContentUtility.php on lines 109..109
    lib/Memcached.php on lines 65..65

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 21.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                $Notification->body = $Smarty->Fetch($Smarty->ResolveTemplate("template.generic"));
    Severity: Major
    Found in lib/Images/Utility/CompNotify.php and 3 other locations - About 30 mins to fix
    lib/Images/Utility/CompetitionUtility.php on lines 469..469
    lib/BanControl/BanControl.php on lines 332..332
    lib/BanControl/BanControl.php on lines 485..485

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 21.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                if (function_exists("wpautop") && function_exists("format_post")) {
                $body = wpautop(format_post($body));
            }
    Severity: Minor
    Found in lib/Images/Utility/CompNotify.php and 1 other location - About 30 mins to fix
    lib/Images/Utility/CompetitionUtility.php on lines 450..452

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 20.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status