lib/Locations/DateType.php
The method __construct has a boolean flag argument $id, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function __construct($id = false) {- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid assigning values to variables in if clauses and the like (line '43', column '21'). Open
Open
public function __construct($id = false) {
parent::__construct();
if (filter_var($id, FILTER_VALIDATE_INT)) {
$query = "SELECT * FROM location_datetypes WHERE id = ?";- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
There must be one blank line after the namespace declaration Open
Open
namespace Railpage\Locations;- Exclude checks
Line indented incorrectly; expected 0 spaces, found 4 Open
Open
class DateType extends Locations {- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
public $id;- Exclude checks
Line indented incorrectly; expected 8 spaces, found 12 Open
Open
if (filter_var($id, FILTER_VALIDATE_INT)) {- Exclude checks
Line indented incorrectly; expected 0 spaces, found 4 Open
Open
}- Exclude checks
Line indented incorrectly; expected 8 spaces, found 12 Open
Open
}- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
public function __construct($id = false) {- Exclude checks
Line indented incorrectly; expected 12 spaces, found 16 Open
Open
}- Exclude checks
Line indented incorrectly; expected 12 spaces, found 16 Open
Open
if ($row = $this->db->fetchRow($query, $id)) {- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
}- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
public $name;- Exclude checks