Sign upLogin

railpage/railpagecore

View on GitHub
Star
lib/Locos/Type.php

Summary

Maintainability
D
2 days
Test Coverage

The method commit uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $this->db->insert("loco_type", $data);
            $this->id = $this->db->lastInsertId();
        }
Severity: Minor
Found in lib/Locos/Type.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function commit() {
        $this->validate();
        
        $data = array(
            "title" => $this->name,
Severity: Major
Found in lib/Locos/Type.php and 1 other location - About 5 hrs to fix
lib/Jobs/Classification.php on lines 119..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (empty($this->slug)) {
            $proposal = ContentUtility::generateUrlSlug($this->name, 30);
            
            $query = "SELECT id FROM loco_type WHERE slug = ?";
            $result = $this->db->fetchAll($query, $proposal);
Severity: Major
Found in lib/Locos/Type.php and 1 other location - About 4 hrs to fix
lib/Locos/Manufacturer.php on lines 100..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

            $this->url = new Url(sprintf("%s/type/%s", $this->Module->url, $this->slug));
Severity: Major
Found in lib/Locos/Type.php and 11 other locations - About 1 hr to fix
lib/Events/Event.php on lines 475..475
lib/Events/EventCategory.php on lines 232..232
lib/Gallery/Image.php on lines 207..207
lib/Glossary/Entry.php on lines 227..227
lib/Ideas/Idea.php on lines 186..186
lib/Jobs/Job.php on lines 195..195
lib/Jobs/Job.php on lines 315..315
lib/Locations/Region.php on lines 149..149
lib/Locos/Type.php on lines 106..106
lib/News/Topic.php on lines 147..147
lib/Timetables/Point.php on lines 114..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

        $this->url = new Url(sprintf("%s/type/%s", $this->Module->url, $this->slug));
Severity: Major
Found in lib/Locos/Type.php and 11 other locations - About 1 hr to fix
lib/Events/Event.php on lines 475..475
lib/Events/EventCategory.php on lines 232..232
lib/Gallery/Image.php on lines 207..207
lib/Glossary/Entry.php on lines 227..227
lib/Ideas/Idea.php on lines 186..186
lib/Jobs/Job.php on lines 195..195
lib/Jobs/Job.php on lines 315..315
lib/Locations/Region.php on lines 149..149
lib/Locos/Type.php on lines 133..133
lib/News/Topic.php on lines 147..147
lib/Timetables/Point.php on lines 114..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (!is_array($row) || count($row) === 0) {
            return false;
        }
Severity: Major
Found in lib/Locos/Type.php and 1 other location - About 1 hr to fix
lib/Locos/WheelArrangement.php on lines 97..99

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function getArray() {
        return array(
            "id" => $this->id,
            "name" => $this->name,
            "url" => $this->url->getURLs()
Severity: Major
Found in lib/Locos/Type.php and 1 other location - About 1 hr to fix
lib/Glossary/Type.php on lines 108..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        foreach ($this->db->fetchAll($query, $this->id) as $row) {
            $LocoClass = new LocoClass($row['id']);
            
            $return[] = $LocoClass->getArray();
        }
Severity: Major
Found in lib/Locos/Type.php and 4 other locations - About 1 hr to fix
lib/Images/Competitions.php on lines 123..126
lib/Locos/Manufacturer.php on lines 192..196
lib/Newsletters/Newsletters.php on lines 85..88
lib/Sightings/Sightings.php on lines 119..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (!is_null($id)) {
            $row = $this->db->fetchRow("SELECT * FROM loco_type WHERE slug = ?", $id);
            $this->load($row);
        }
Severity: Minor
Found in lib/Locos/Type.php and 1 other location - About 55 mins to fix
lib/Locos/Type.php on lines 61..64

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (filter_var($id, FILTER_VALIDATE_INT)) {
            $row = $this->db->fetchRow("SELECT * FROM loco_type WHERE id = ?", $id);
            $this->load($row); 
        }
Severity: Minor
Found in lib/Locos/Type.php and 1 other location - About 55 mins to fix
lib/Locos/Type.php on lines 68..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 18 locations. Consider refactoring.
Open

        if (empty($this->name)) {
            throw new Exception("Cannot validate changes to this loco type: name cannot be empty");
            return false;
        }
Severity: Major
Found in lib/Locos/Type.php and 17 other locations - About 45 mins to fix
lib/Jobs/Job.php on lines 230..233
lib/Jobs/Job.php on lines 243..246
lib/Links/Link.php on lines 136..139
lib/Links/Link.php on lines 141..144
lib/Links/Link.php on lines 146..149
lib/Locations/Location.php on lines 881..884
lib/Locations/Location.php on lines 899..902
lib/Locos/WheelArrangement.php on lines 161..164
lib/News/Topic.php on lines 337..340
lib/News/Topic.php on lines 356..359
lib/Sightings/Sighting.php on lines 219..222
lib/Sightings/Sighting.php on lines 224..227
lib/Sightings/Sighting.php on lines 229..232
lib/Sightings/Sighting.php on lines 234..237
lib/SiteEvent.php on lines 148..151
lib/SiteEvent.php on lines 153..156
lib/SiteEvent.php on lines 158..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status