Sign upLogin

railpage/railpagecore

View on GitHub
Star
lib/News/Feed.php

Summary

Maintainability
D
2 days
Test Coverage

Function findArticles has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

        public function findArticles($offset = 0, $limit = 25, $orderby = "story_time_unix") {
            
            if (empty($this->filter_topics) || empty($this->filter_words)) {
                $this->getFilters();
            }
Severity: Minor
Found in lib/News/Feed.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method findArticles has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public function findArticles($offset = 0, $limit = 25, $orderby = "story_time_unix") {
            
            if (empty($this->filter_topics) || empty($this->filter_words)) {
                $this->getFilters();
            }
Severity: Minor
Found in lib/News/Feed.php - About 1 hr to fix

    Function addFilter has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            public function addFilter($filter) {
            
            if (!$this->hasFilter($filter)) {
                $this->filters[] = $filter; 
            }
    Severity: Minor
    Found in lib/News/Feed.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getFilters has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            public function getFilters() {
            if (!$this->User instanceof User) {
                throw new Exception("Cannot get filters for news feed because no valid user was specified");
            }
    Severity: Minor
    Found in lib/News/Feed.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method findArticles() has an NPath complexity of 9000. The configured NPath complexity threshold is 200.
    Open

            public function findArticles($offset = 0, $limit = 25, $orderby = "story_time_unix") {
            
            if (empty($this->filter_topics) || empty($this->filter_words)) {
                $this->getFilters();
            }
    Severity: Minor
    Found in lib/News/Feed.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
    function bar() {
        // lots of complicated code
    }
}

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method findArticles() has a Cyclomatic Complexity of 18. The configured cyclomatic complexity threshold is 10.
    Open

            public function findArticles($offset = 0, $limit = 25, $orderby = "story_time_unix") {
            
            if (empty($this->filter_topics) || empty($this->filter_words)) {
                $this->getFilters();
            }
    Severity: Minor
    Found in lib/News/Feed.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Avoid assigning values to variables in if clauses and the like (line '227', column '18').
    Open

            public function getFilters() {
            if (!$this->User instanceof User) {
                throw new Exception("Cannot get filters for news feed because no valid user was specified");
            }
    Severity: Minor
    Found in lib/News/Feed.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid assigning values to variables in if clauses and the like (line '228', column '21').
    Open

            public function getFilters() {
            if (!$this->User instanceof User) {
                throw new Exception("Cannot get filters for news feed because no valid user was specified");
            }
    Severity: Minor
    Found in lib/News/Feed.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid assigning values to variables in if clauses and the like (line '266', column '17').
    Open

            public function setFilters() {
            if (!$this->User instanceof User) {
                throw new Exception("Cannot get filters for news feed because no valid user was specified");
            }
    Severity: Minor
    Found in lib/News/Feed.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    The method setFilters uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                $this->db->insert("news_feed", $data);
            }
    Severity: Minor
    Found in lib/News/Feed.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if ($filter == self::FILTER_READ) {
                $key = $this->hasFilter(self::FILTER_UNREAD);
                
                if ($key !== false) {
                    unset($this->filters[$key]);
    Severity: Major
    Found in lib/News/Feed.php and 1 other location - About 1 hr to fix
    lib/News/Feed.php on lines 179..185

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if ($filter == self::FILTER_UNREAD) {
                $key = $this->hasFilter(self::FILTER_READ);
                
                if ($key !== false) {
                    unset($this->filters[$key]);
    Severity: Major
    Found in lib/News/Feed.php and 1 other location - About 1 hr to fix
    lib/News/Feed.php on lines 187..193

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if (count($article_ids)) {
                    $query->where("story_id", "IN", $article_ids);
                }
    Severity: Minor
    Found in lib/News/Feed.php and 1 other location - About 50 mins to fix
    lib/News/Feed.php on lines 117..119

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if (count($article_ids)) {
                    $query->where("story_id", "NOT IN", $article_ids); 
                }
    Severity: Minor
    Found in lib/News/Feed.php and 1 other location - About 50 mins to fix
    lib/News/Feed.php on lines 133..135

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 23 locations. Consider refactoring.
    Open

                    $this->filter_topics = json_decode($row['topics'], true);
    Severity: Major
    Found in lib/News/Feed.php and 22 other locations - About 45 mins to fix
    lib/Assets/Asset.php on lines 150..150
    lib/Chronicle/Entry.php on lines 156..156
    lib/Events/Event.php on lines 207..207
    lib/Events/EventDate.php on lines 154..154
    lib/Gallery/Album.php on lines 136..136
    lib/Gallery/Image.php on lines 208..208
    lib/Ideas/Idea.php on lines 166..166
    lib/Images/Camera.php on lines 116..116
    lib/Images/Competition.php on lines 180..180
    lib/Images/Competition.php on lines 790..790
    lib/Locos/Date.php on lines 158..158
    lib/Locos/LocoClass.php on lines 417..417
    lib/News/Feed.php on lines 234..234
    lib/Newsletters/Newsletter.php on lines 128..128
    lib/Newsletters/Newsletter.php on lines 129..129
    lib/Railcams/Storage.php on lines 201..201
    lib/Sightings/Sighting.php on lines 161..161
    lib/Sightings/Sighting.php on lines 162..162
    lib/Timetables/Train.php on lines 174..174
    lib/Users/Group.php on lines 168..168
    lib/Users/User.php on lines 1068..1068
    lib/SiteEvent.php on lines 135..135

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 23 locations. Consider refactoring.
    Open

                    $this->filter_words = json_decode($row['keywords'], true);
    Severity: Major
    Found in lib/News/Feed.php and 22 other locations - About 45 mins to fix
    lib/Assets/Asset.php on lines 150..150
    lib/Chronicle/Entry.php on lines 156..156
    lib/Events/Event.php on lines 207..207
    lib/Events/EventDate.php on lines 154..154
    lib/Gallery/Album.php on lines 136..136
    lib/Gallery/Image.php on lines 208..208
    lib/Ideas/Idea.php on lines 166..166
    lib/Images/Camera.php on lines 116..116
    lib/Images/Competition.php on lines 180..180
    lib/Images/Competition.php on lines 790..790
    lib/Locos/Date.php on lines 158..158
    lib/Locos/LocoClass.php on lines 417..417
    lib/News/Feed.php on lines 235..235
    lib/Newsletters/Newsletter.php on lines 128..128
    lib/Newsletters/Newsletter.php on lines 129..129
    lib/Railcams/Storage.php on lines 201..201
    lib/Sightings/Sighting.php on lines 161..161
    lib/Sightings/Sighting.php on lines 162..162
    lib/Timetables/Train.php on lines 174..174
    lib/Users/Group.php on lines 168..168
    lib/Users/User.php on lines 1068..1068
    lib/SiteEvent.php on lines 135..135

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    $this->db->update("news_feed", $data, array("id = ?" => $id));
    Severity: Minor
    Found in lib/News/Feed.php and 1 other location - About 40 mins to fix
    lib/Users/User.php on lines 1627..1627

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 23.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                if (is_string($this->filter_words)) {
                $this->filter_words = explode(",", $this->filter_words);
            }
    Severity: Major
    Found in lib/News/Feed.php and 3 other locations - About 35 mins to fix
    lib/Images/Image.php on lines 307..309
    lib/Images/Utility/Url.php on lines 29..31
    lib/Module.php on lines 147..149

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 22.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                foreach ($this->filter_words as $id => $word) {
                $this->filter_words[$id] = trim($word);
            }
    Severity: Minor
    Found in lib/News/Feed.php and 1 other location - About 30 mins to fix
    lib/Assets/Asset.php on lines 159..161

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 21.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    foreach (Utility\ArticleUtility::getReadArticlesForUser($this->User) as $row) {
                    $article_ids[] = intval($row['story_id']); 
                }
    Severity: Minor
    Found in lib/News/Feed.php and 1 other location - About 30 mins to fix
    lib/Users/User.php on lines 2487..2489

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 21.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if ($id = $this->db->fetchOne("SELECT id FROM news_feed WHERE user_id = ?", $this->User->id)) {
                $this->db->update("news_feed", $data, array("id = ?" => $id));
            } else {
                $this->db->insert("news_feed", $data);
            }
    Severity: Minor
    Found in lib/News/Feed.php and 1 other location - About 30 mins to fix
    lib/News/Feed.php on lines 228..230

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 21.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if ($row = $this->db->fetchRow("SELECT keywords, topics FROM news_feed WHERE user_id = ?", $this->User->id)) {
                    $this->Memcached->save(sprintf("rp:news.feed=%d", $this->User->id), $row);
                }
    Severity: Minor
    Found in lib/News/Feed.php and 1 other location - About 30 mins to fix
    lib/News/Feed.php on lines 266..270

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 21.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if (!empty($this->filter_topics) && count($this->filter_topics)) {
    Severity: Minor
    Found in lib/News/Feed.php and 1 other location - About 30 mins to fix
    lib/News/Feed.php on lines 142..142

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 20.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if (!empty($this->filter_words) && count($this->filter_words) && !(count($this->filter_words) === 1 && $this->filter_words[0] == "")) {
    Severity: Minor
    Found in lib/News/Feed.php and 1 other location - About 30 mins to fix
    lib/News/Feed.php on lines 102..102

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 20.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function closing brace must go on the next line following the body; found 1 blank lines before brace
    Open

            }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Function closing brace must go on the next line following the body; found 1 blank lines before brace
    Open

            }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if ($filter == self::FILTER_UNREAD) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 12 spaces, found 16
    Open

                    foreach (Utility\ArticleUtility::getReadArticlesForUser($this->User) as $row) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 12 spaces, found 16
    Open

                    }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if ($this->hasFilter(self::FILTER_LAST_30_DAYS) !== false) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 12 spaces, found 16
    Open

                    if ($key !== false) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if (empty($this->filter_topics) || empty($this->filter_words)) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 12 spaces, found 16
    Open

                    foreach (Utility\ArticleUtility::getReadArticlesForUser($this->User) as $row) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            public function setFilters() {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if (!$this->User instanceof User) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            private $filters;
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 12 spaces, found 16
    Open

                    if ($key !== false) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                } else {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        class Feed extends News {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            public function findArticles($offset = 0, $limit = 25, $orderby = "story_time_unix") {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 12 spaces, found 16
    Open

                    if (count($article_ids)) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 12 spaces, found 16
    Open

                    if (count($article_ids)) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            public function addFilter($filter) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if ($filter == self::FILTER_READ) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 12 spaces, found 16
    Open

                    }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if (!in_array($filter, $this->filters)) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                foreach ($this->filter_words as $id => $word) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if (!empty($this->filter_topics) && count($this->filter_topics)) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            public $filter_topics;
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if (!$this->User instanceof User) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if (!$limit) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 12 spaces, found 16
    Open

                    }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 12 spaces, found 16
    Open

                    }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            public function getFilters() {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if (!$row = $this->Memcached->fetch(sprintf("rp:news.feed=%d", $this->User->id))) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 12 spaces, found 16
    Open

                    if ($row = $this->db->fetchRow("SELECT keywords, topics FROM news_feed WHERE user_id = ?", $this->User->id)) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if (!empty($this->filter_words) && count($this->filter_words) && !(count($this->filter_words) === 1 && $this->filter_words[0] == "")) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                foreach ($matches as $id => $row) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 12 spaces, found 16
    Open

                    }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 12 spaces, found 16
    Open

                    }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            public $filter_words;
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 12 spaces, found 16
    Open

                    }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if ($this->hasFilter(self::FILTER_READ) !== false) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if (isset($row) && is_array($row)) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if ($this->hasFilter(self::FILTER_UNREAD) !== false) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if (!$this->hasFilter($filter)) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            public function hasFilter($filter) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if (is_string($this->filter_words)) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if ($id = $this->db->fetchOne("SELECT id FROM news_feed WHERE user_id = ?", $this->User->id)) {
    Severity: Minor
    Found in lib/News/Feed.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status