Function CreateOrganisation has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public static function CreateOrganisation($id = false) {
$Memcached = AppCore::getMemcached();
$Redis = AppCore::getRedis();
$Registry = Registry::getInstance(); - Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method CreateOrganisation has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function CreateOrganisation($id = false) {
$Memcached = AppCore::getMemcached();
$Redis = AppCore::getRedis();
$Registry = Registry::getInstance(); The method CreateOrganisation has a boolean flag argument $id, which is a certain sign of a Single Responsibility Principle violation. Open
public static function CreateOrganisation($id = false) {- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid assigning values to variables in if clauses and the like (line '60', column '42'). Open
public static function CreateOrganisation($id = false) {
$Memcached = AppCore::getMemcached();
$Redis = AppCore::getRedis();
$Registry = Registry::getInstance(); - Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid unused local variables such as '$Memcached'. Open
$Memcached = AppCore::getMemcached(); - Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (!filter_var($id, FILTER_VALIDATE_INT)) {
$slugkey = sprintf(Organisation::REGISTRY_KEY, $id);
try {
$id = $Registry->get($slugkey);- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 105.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function closing brace must go on the next line following the body; found 1 blank lines before brace Open
}- Exclude checks
Line indented incorrectly; expected 8 spaces, found 12 Open
} catch (Exception $e) {- Exclude checks
Line indented incorrectly; expected 12 spaces, found 16 Open
try {- Exclude checks
Line indented incorrectly; expected 12 spaces, found 16 Open
}- Exclude checks
Line indented incorrectly; expected 12 spaces, found 16 Open
if (!self::USE_REDIS || !$Organisation = $Redis->fetch($cachekey)) {- Exclude checks
Line indented incorrectly; expected 8 spaces, found 12 Open
} - Exclude checks
Line indented incorrectly; expected 16 spaces, found 20 Open
}- Exclude checks
Line indented incorrectly; expected 12 spaces, found 16 Open
}- Exclude checks
Line indented incorrectly; expected 0 spaces, found 4 Open
}- Exclude checks
Line indented incorrectly; expected 8 spaces, found 12 Open
}- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
}- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
public static function CreateOrganisation($id = false) {- Exclude checks
Line indented incorrectly; expected 0 spaces, found 4 Open
class Factory {- Exclude checks
Line indented incorrectly; expected 8 spaces, found 12 Open
if (!filter_var($id, FILTER_VALIDATE_INT)) {- Exclude checks
Line indented incorrectly; expected 8 spaces, found 12 Open
try {- Exclude checks
Line indented incorrectly; expected 16 spaces, found 20 Open
if (self::USE_REDIS) {- Exclude checks
Line indented incorrectly; expected 12 spaces, found 16 Open
} catch (Exception $e) {- Exclude checks