Sign upLogin

rails-api/active_model_serializers

View on GitHub
Star
lib/active_model/serializer/concerns/caching.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class Serializer has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Serializer
    UndefinedCacheKey = Class.new(StandardError)
    module Caching
      extend ActiveSupport::Concern
Severity: Minor
Found in lib/active_model/serializer/concerns/caching.rb - About 2 hrs to fix

    Method object_cache_key has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def object_cache_key
        if object.respond_to?(:cache_key_with_version)
          object.cache_key_with_version
        elsif object.respond_to?(:cache_key)
          object.cache_key
    Severity: Minor
    Found in lib/active_model/serializer/concerns/caching.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method object_cache_key has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def object_cache_key(serializer, adapter_instance)
          return unless serializer.present? && serializer.object.present?

          (serializer.class.cache_enabled? || serializer.class.fragment_cache_enabled?) ? serializer.cache_key(adapter_instance) : nil
        end
    Severity: Minor
    Found in lib/active_model/serializer/concerns/caching.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status