Sign upLogin

rails/rails

View on GitHub
Star
actionpack/lib/action_controller/metal/http_authentication.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method validate_digest_response has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def validate_digest_response(request, realm, &password_procedure)
        secret_key  = secret_token(request)
        credentials = decode_credentials_header(request)
        valid_nonce = validate_nonce(secret_key, request, credentials[:nonce])
Severity: Minor
Found in actionpack/lib/action_controller/metal/http_authentication.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method expected_response has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def expected_response(http_method, uri, credentials, password, password_is_ha1 = true)
Severity: Minor
Found in actionpack/lib/action_controller/metal/http_authentication.rb - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status