Sign upLogin

rails/rails

View on GitHub
Star
actionpack/lib/action_dispatch/http/cache.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method merge_and_normalize_cache_control! has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

        def merge_and_normalize_cache_control!(cache_control)
          control = cache_control_headers

          return if control.empty? && cache_control.empty?  # Let middleware handle default behavior
Severity: Minor
Found in actionpack/lib/action_dispatch/http/cache.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method merge_and_normalize_cache_control! has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def merge_and_normalize_cache_control!(cache_control)
          control = cache_control_headers

          return if control.empty? && cache_control.empty?  # Let middleware handle default behavior
Severity: Minor
Found in actionpack/lib/action_dispatch/http/cache.rb - About 1 hr to fix

    Method fresh? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            def fresh?(response)
          last_modified = if_modified_since
          etag          = if_none_match

          return false unless last_modified || etag
    Severity: Minor
    Found in actionpack/lib/action_dispatch/http/cache.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status