Sign upLogin

rails/rails

View on GitHub
Star
actionpack/lib/action_dispatch/http/url.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method build_host_url has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

          def build_host_url(host, port, protocol, options, path)
            if match = host.match(HOST_REGEXP)
              protocol ||= match[1] unless protocol == false
              host       = match[2]
              port       = match[3] unless options.key? :port
Severity: Minor
Found in actionpack/lib/action_dispatch/http/url.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method normalize_port has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

          def normalize_port(port, protocol)
            return unless port

            case protocol
            when "//" then yield port
Severity: Minor
Found in actionpack/lib/action_dispatch/http/url.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method normalize_host has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

          def normalize_host(_host, options)
            return _host unless named_host?(_host)

            tld_length = options[:tld_length] || @@tld_length
            subdomain  = options.fetch :subdomain, true
Severity: Minor
Found in actionpack/lib/action_dispatch/http/url.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_host_url has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

          def build_host_url(host, port, protocol, options, path)
Severity: Minor
Found in actionpack/lib/action_dispatch/http/url.rb - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status