actionpack/lib/action_dispatch/journey/gtg/builder.rb

Summary

Maintainability
C
1 day
Test Coverage

Method transition_table has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

        def transition_table
          dtrans   = TransitionTable.new
          marked   = {}.compare_by_identity
          state_id = Hash.new { |h, k| h[k] = h.length }.compare_by_identity
          dstates  = [firstpos(root)]
Severity: Minor
Found in actionpack/lib/action_dispatch/journey/gtg/builder.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method lastpos has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        def lastpos(node)
          case node
          when Nodes::Star
            lastpos(node.left)
          when Nodes::Or
Severity: Minor
Found in actionpack/lib/action_dispatch/journey/gtg/builder.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method firstpos has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        def firstpos(node)
          case node
          when Nodes::Star
            firstpos(node.left)
          when Nodes::Cat
Severity: Minor
Found in actionpack/lib/action_dispatch/journey/gtg/builder.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method transition_table has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def transition_table
          dtrans   = TransitionTable.new
          marked   = {}.compare_by_identity
          state_id = Hash.new { |h, k| h[k] = h.length }.compare_by_identity
          dstates  = [firstpos(root)]
Severity: Minor
Found in actionpack/lib/action_dispatch/journey/gtg/builder.rb - About 1 hr to fix

    Method nullable? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def nullable?(node)
              case node
              when Nodes::Group
                true
              when Nodes::Star
    Severity: Minor
    Found in actionpack/lib/action_dispatch/journey/gtg/builder.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status