Sign upLogin

rails/rails

View on GitHub
Star
actionpack/lib/action_dispatch/middleware/cookies.rb

Summary

Maintainability
C
1 day
Test Coverage

File cookies.rb has 436 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "active_support/core_ext/hash/keys"
require "active_support/key_generator"
require "active_support/message_verifier"
require "active_support/json"
require "rack/utils"
Severity: Minor
Found in actionpack/lib/action_dispatch/middleware/cookies.rb - About 6 hrs to fix

    Method handle_options has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

            def handle_options(options)
          if options[:expires].respond_to?(:from_now)
            options[:expires] = options[:expires].from_now
          end
    Severity: Minor
    Found in actionpack/lib/action_dispatch/middleware/cookies.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method handle_options has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def handle_options(options)
          if options[:expires].respond_to?(:from_now)
            options[:expires] = options[:expires].from_now
          end
    Severity: Minor
    Found in actionpack/lib/action_dispatch/middleware/cookies.rb - About 1 hr to fix

      Method parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              def parse(name, dumped, force_reserialize: false, **)
          if dumped
            begin
              value = serializer.load(dumped)
            rescue StandardError
      Severity: Minor
      Found in actionpack/lib/action_dispatch/middleware/cookies.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status